* [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
@ 2016-05-09 13:23 Marius Vlad
2016-05-09 15:25 ` Damien Lespiau
2016-05-10 14:32 ` [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror Marius Vlad
0 siblings, 2 replies; 7+ messages in thread
From: Marius Vlad @ 2016-05-09 13:23 UTC (permalink / raw)
To: intel-gfx; +Cc: daniel.vetter
Easier to catch compilation errors.
Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
benchmarks/Makefile.am | 2 +-
demos/Makefile.am | 3 ++-
overlay/Makefile.am | 3 ++-
tests/Makefile.am | 2 +-
tools/Makefile.am | 4 +++-
5 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
index 2c2d100..46992f8 100644
--- a/benchmarks/Makefile.am
+++ b/benchmarks/Makefile.am
@@ -2,7 +2,7 @@
include Makefile.sources
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -Werror
LDADD = $(top_builddir)/lib/libintel_tools.la
benchmarks_LTLIBRARIES = gem_exec_tracer.la
diff --git a/demos/Makefile.am b/demos/Makefile.am
index e6fbb3b..9eacd16 100644
--- a/demos/Makefile.am
+++ b/demos/Makefile.am
@@ -3,5 +3,6 @@ bin_PROGRAMS = \
$(NULL)
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
+ $(LIBUNWIND_CFLAGS) -Werror
LDADD = $(top_builddir)/lib/libintel_tools.la
diff --git a/overlay/Makefile.am b/overlay/Makefile.am
index c648875..ec68489 100644
--- a/overlay/Makefile.am
+++ b/overlay/Makefile.am
@@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
endif
AM_CPPFLAGS = -I.
-AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
+ $(OVERLAY_CFLAGS) -Werror
LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
intel_gpu_overlay_SOURCES = \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 45e3359..22256ce 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
-include "$(srcdir)/../lib/check-ndebug.h" \
-DIGT_SRCDIR=\""$(abs_srcdir)"\" \
-DIGT_DATADIR=\""$(pkgdatadir)"\" \
- $(LIBUNWIND_CFLAGS) \
+ $(LIBUNWIND_CFLAGS) -Werror \
$(NULL)
LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index df48d94..0ba1ff7 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -3,7 +3,9 @@ include Makefile.sources
SUBDIRS = null_state_gen registers
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
+AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \
+ $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
+ -DPKGDATADIR=\"$(pkgdatadir)\" -Werror
LDADD = $(top_builddir)/lib/libintel_tools.la
AM_LDFLAGS = -Wl,--as-needed
--
2.8.0.rc3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
2016-05-09 13:23 [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default Marius Vlad
@ 2016-05-09 15:25 ` Damien Lespiau
2016-05-09 15:55 ` Marius Vlad
2016-05-10 14:32 ` [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror Marius Vlad
1 sibling, 1 reply; 7+ messages in thread
From: Damien Lespiau @ 2016-05-09 15:25 UTC (permalink / raw)
To: Marius Vlad; +Cc: daniel.vetter, intel-gfx
On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote:
> Easier to catch compilation errors.
Having -Werror by default is a no go as you cannot control/predict the
set of warnings (and the quality of those) of all previous and future
gcc/clang versions.
Always using this flag will cause distributions to hate us.
Adding a test (with patchwork integration!) that ensures each commit
posted on this mailing-list compiles without new warning with a chosen
toolchain (and even passes distcheck!) would be nice.
--
Damien
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
> benchmarks/Makefile.am | 2 +-
> demos/Makefile.am | 3 ++-
> overlay/Makefile.am | 3 ++-
> tests/Makefile.am | 2 +-
> tools/Makefile.am | 4 +++-
> 5 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
> index 2c2d100..46992f8 100644
> --- a/benchmarks/Makefile.am
> +++ b/benchmarks/Makefile.am
> @@ -2,7 +2,7 @@
> include Makefile.sources
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -Werror
> LDADD = $(top_builddir)/lib/libintel_tools.la
>
> benchmarks_LTLIBRARIES = gem_exec_tracer.la
> diff --git a/demos/Makefile.am b/demos/Makefile.am
> index e6fbb3b..9eacd16 100644
> --- a/demos/Makefile.am
> +++ b/demos/Makefile.am
> @@ -3,5 +3,6 @@ bin_PROGRAMS = \
> $(NULL)
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> + $(LIBUNWIND_CFLAGS) -Werror
> LDADD = $(top_builddir)/lib/libintel_tools.la
> diff --git a/overlay/Makefile.am b/overlay/Makefile.am
> index c648875..ec68489 100644
> --- a/overlay/Makefile.am
> +++ b/overlay/Makefile.am
> @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
> endif
>
> AM_CPPFLAGS = -I.
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> + $(OVERLAY_CFLAGS) -Werror
> LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
>
> intel_gpu_overlay_SOURCES = \
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 45e3359..22256ce 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
> -include "$(srcdir)/../lib/check-ndebug.h" \
> -DIGT_SRCDIR=\""$(abs_srcdir)"\" \
> -DIGT_DATADIR=\""$(pkgdatadir)"\" \
> - $(LIBUNWIND_CFLAGS) \
> + $(LIBUNWIND_CFLAGS) -Werror \
> $(NULL)
>
> LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index df48d94..0ba1ff7 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -3,7 +3,9 @@ include Makefile.sources
> SUBDIRS = null_state_gen registers
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
> +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \
> + $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
> + -DPKGDATADIR=\"$(pkgdatadir)\" -Werror
> LDADD = $(top_builddir)/lib/libintel_tools.la
> AM_LDFLAGS = -Wl,--as-needed
>
> --
> 2.8.0.rc3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
2016-05-09 15:25 ` Damien Lespiau
@ 2016-05-09 15:55 ` Marius Vlad
2016-05-09 15:57 ` Damien Lespiau
2016-05-09 16:01 ` Morton, Derek J
0 siblings, 2 replies; 7+ messages in thread
From: Marius Vlad @ 2016-05-09 15:55 UTC (permalink / raw)
To: Damien Lespiau; +Cc: daniel.vetter, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4429 bytes --]
On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote:
> On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote:
> > Easier to catch compilation errors.
>
>
> Having -Werror by default is a no go as you cannot control/predict the
> set of warnings (and the quality of those) of all previous and future
> gcc/clang versions.
>
> Always using this flag will cause distributions to hate us.
I assumed that much.
>
> Adding a test (with patchwork integration!) that ensures each commit
> posted on this mailing-list compiles without new warning with a chosen
> toolchain (and even passes distcheck!) would be nice.
We have this for check and distcheck internally. The whole point of
Werror was to catch warnings as well when building, and letting us know
so we can fix it. The problem is (unfortunately) that not all patches
arrive thru m-l. Don't really know how much traction some CI/buildbot
for i-g-t will have.
>
> --
> Damien
>
> > Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> > ---
> > benchmarks/Makefile.am | 2 +-
> > demos/Makefile.am | 3 ++-
> > overlay/Makefile.am | 3 ++-
> > tests/Makefile.am | 2 +-
> > tools/Makefile.am | 4 +++-
> > 5 files changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
> > index 2c2d100..46992f8 100644
> > --- a/benchmarks/Makefile.am
> > +++ b/benchmarks/Makefile.am
> > @@ -2,7 +2,7 @@
> > include Makefile.sources
> >
> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> > -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> > +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -Werror
> > LDADD = $(top_builddir)/lib/libintel_tools.la
> >
> > benchmarks_LTLIBRARIES = gem_exec_tracer.la
> > diff --git a/demos/Makefile.am b/demos/Makefile.am
> > index e6fbb3b..9eacd16 100644
> > --- a/demos/Makefile.am
> > +++ b/demos/Makefile.am
> > @@ -3,5 +3,6 @@ bin_PROGRAMS = \
> > $(NULL)
> >
> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> > -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> > + $(LIBUNWIND_CFLAGS) -Werror
> > LDADD = $(top_builddir)/lib/libintel_tools.la
> > diff --git a/overlay/Makefile.am b/overlay/Makefile.am
> > index c648875..ec68489 100644
> > --- a/overlay/Makefile.am
> > +++ b/overlay/Makefile.am
> > @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
> > endif
> >
> > AM_CPPFLAGS = -I.
> > -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
> > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> > + $(OVERLAY_CFLAGS) -Werror
> > LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
> >
> > intel_gpu_overlay_SOURCES = \
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index 45e3359..22256ce 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
> > -include "$(srcdir)/../lib/check-ndebug.h" \
> > -DIGT_SRCDIR=\""$(abs_srcdir)"\" \
> > -DIGT_DATADIR=\""$(pkgdatadir)"\" \
> > - $(LIBUNWIND_CFLAGS) \
> > + $(LIBUNWIND_CFLAGS) -Werror \
> > $(NULL)
> >
> > LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index df48d94..0ba1ff7 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -3,7 +3,9 @@ include Makefile.sources
> > SUBDIRS = null_state_gen registers
> >
> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> > -AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
> > +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \
> > + $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
> > + -DPKGDATADIR=\"$(pkgdatadir)\" -Werror
> > LDADD = $(top_builddir)/lib/libintel_tools.la
> > AM_LDFLAGS = -Wl,--as-needed
> >
> > --
> > 2.8.0.rc3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
2016-05-09 15:55 ` Marius Vlad
@ 2016-05-09 15:57 ` Damien Lespiau
2016-05-09 16:01 ` Morton, Derek J
1 sibling, 0 replies; 7+ messages in thread
From: Damien Lespiau @ 2016-05-09 15:57 UTC (permalink / raw)
To: intel-gfx, daniel.vetter, Chris Wilson
On Mon, May 09, 2016 at 06:55:12PM +0300, Marius Vlad wrote:
> > Adding a test (with patchwork integration!) that ensures each commit
> > posted on this mailing-list compiles without new warning with a chosen
> > toolchain (and even passes distcheck!) would be nice.
> We have this for check and distcheck internally. The whole point of
> Werror was to catch warnings as well when building, and letting us know
> so we can fix it. The problem is (unfortunately) that not all patches
> arrive thru m-l. Don't really know how much traction some CI/buildbot
> for i-g-t will have.
Oh, CI for i-g-t patches is a must have and on the roadmap. Can't really
keep on testing kernel patches if we can just regress everything with
random i-g-t patches.
Doing the distcheck for every patch on the ml would already be a nice
thing.
Alternatively, you could have an --enable-werror configure flag
developers may wish to use.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
2016-05-09 15:55 ` Marius Vlad
2016-05-09 15:57 ` Damien Lespiau
@ 2016-05-09 16:01 ` Morton, Derek J
1 sibling, 0 replies; 7+ messages in thread
From: Morton, Derek J @ 2016-05-09 16:01 UTC (permalink / raw)
To: Vlad, Marius C, Lespiau, Damien
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
>
>
>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
>Behalf Of Marius Vlad
>Sent: Monday, May 9, 2016 4:55 PM
>To: Lespiau, Damien <damien.lespiau@intel.com>
>Cc: daniel.vetter@ffwll.ch; intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
>
>On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote:
>> On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote:
>> > Easier to catch compilation errors.
>>
>>
>> Having -Werror by default is a no go as you cannot control/predict
>> the set of warnings (and the quality of those) of all previous and
>> future gcc/clang versions.
>>
>> Always using this flag will cause distributions to hate us.
>I assumed that much.
Building IGT for android generates large numbers of warnings as the compiler used for android is more paranoid. If you make all warnings errors you would have to also fix a lot of warnings for android.
>
>>
>> Adding a test (with patchwork integration!) that ensures each commit
>> posted on this mailing-list compiles without new warning with a
>> chosen toolchain (and even passes distcheck!) would be nice.
>We have this for check and distcheck internally. The whole point of Werror was to catch warnings as well when building, and letting us know so we can fix it. The problem is (unfortunately) that not all patches arrive thru m-l. Don't really know how much traction some CI/buildbot for i-g-t will have.
>>
>> --
>> Damien
>>
>> > Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>> > ---
>> > benchmarks/Makefile.am | 2 +-
>> > demos/Makefile.am | 3 ++-
>> > overlay/Makefile.am | 3 ++-
>> > tests/Makefile.am | 2 +-
>> > tools/Makefile.am | 4 +++-
>> > 5 files changed, 9 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am index
>> > 2c2d100..46992f8 100644
>> > --- a/benchmarks/Makefile.am
>> > +++ b/benchmarks/Makefile.am
>> > @@ -2,7 +2,7 @@
>> > include Makefile.sources
>> >
>> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib -AM_CFLAGS =
>> > $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
>> > +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS)
>> > +$(LIBUNWIND_CFLAGS) -Werror
>> > LDADD = $(top_builddir)/lib/libintel_tools.la
>> >
>> > benchmarks_LTLIBRARIES = gem_exec_tracer.la diff --git
>> > a/demos/Makefile.am b/demos/Makefile.am index e6fbb3b..9eacd16
>> > 100644
>> > --- a/demos/Makefile.am
>> > +++ b/demos/Makefile.am
>> > @@ -3,5 +3,6 @@ bin_PROGRAMS = \
>> > $(NULL)
>> >
>> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib -AM_CFLAGS =
>> > $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS)
>> > $(LIBUNWIND_CFLAGS)
>> > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
>> > + $(LIBUNWIND_CFLAGS) -Werror
>> > LDADD = $(top_builddir)/lib/libintel_tools.la
>> > diff --git a/overlay/Makefile.am b/overlay/Makefile.am index
>> > c648875..ec68489 100644
>> > --- a/overlay/Makefile.am
>> > +++ b/overlay/Makefile.am
>> > @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay endif
>> >
>> > AM_CPPFLAGS = -I.
>> > -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS)
>> > $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
>> > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
>> > + $(OVERLAY_CFLAGS) -Werror
>> > LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS)
>> > $(OVERLAY_LIBS)
>> >
>> > intel_gpu_overlay_SOURCES = \
>> > diff --git a/tests/Makefile.am b/tests/Makefile.am index
>> > 45e3359..22256ce 100644
>> > --- a/tests/Makefile.am
>> > +++ b/tests/Makefile.am
>> > @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
>> > -include "$(srcdir)/../lib/check-ndebug.h" \
>> > -DIGT_SRCDIR=\""$(abs_srcdir)"\" \
>> > -DIGT_DATADIR=\""$(pkgdatadir)"\" \
>> > - $(LIBUNWIND_CFLAGS) \
>> > + $(LIBUNWIND_CFLAGS) -Werror \
>> > $(NULL)
>> >
>> > LDADD = ../lib/libintel_tools.la $(GLIB_LIBS) diff --git
>> > a/tools/Makefile.am b/tools/Makefile.am index df48d94..0ba1ff7
>> > 100644
>> > --- a/tools/Makefile.am
>> > +++ b/tools/Makefile.am
>> > @@ -3,7 +3,9 @@ include Makefile.sources SUBDIRS = null_state_gen
>> > registers
>> >
>> > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib -AM_CFLAGS =
>> > $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
>> > +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \
>> > + $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
>> > + -DPKGDATADIR=\"$(pkgdatadir)\" -Werror
>> > LDADD = $(top_builddir)/lib/libintel_tools.la
>> > AM_LDFLAGS = -Wl,--as-needed
>> >
>> > --
>> > 2.8.0.rc3
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror.
2016-05-09 13:23 [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default Marius Vlad
2016-05-09 15:25 ` Damien Lespiau
@ 2016-05-10 14:32 ` Marius Vlad
2016-05-10 15:42 ` Damien Lespiau
1 sibling, 1 reply; 7+ messages in thread
From: Marius Vlad @ 2016-05-10 14:32 UTC (permalink / raw)
To: intel-gfx
v2: Initially added Werror by default. Make it optional so it doesn't
break android build and (potential) distros maintaing the package
(Hinted by Damien Lespiau).
--enable-werror will enable -Werror compiler flag.
Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
benchmarks/Makefile.am | 3 ++-
configure.ac | 10 ++++++++++
demos/Makefile.am | 3 ++-
overlay/Makefile.am | 3 ++-
tests/Makefile.am | 2 +-
tools/Makefile.am | 4 +++-
6 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
index 2c2d100..49d2f64 100644
--- a/benchmarks/Makefile.am
+++ b/benchmarks/Makefile.am
@@ -2,7 +2,8 @@
include Makefile.sources
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
+ $(WERROR_CFLAGS)
LDADD = $(top_builddir)/lib/libintel_tools.la
benchmarks_LTLIBRARIES = gem_exec_tracer.la
diff --git a/configure.ac b/configure.ac
index 0589782..11b1d46 100644
--- a/configure.ac
+++ b/configure.ac
@@ -229,6 +229,11 @@ AC_ARG_ENABLE(debug,
[Build tests without debug symbols]),
[], [enable_debug=yes])
+AC_ARG_ENABLE(werror,
+ AS_HELP_STRING([--enable-werror],
+ [Fail on warnings]),
+ [], [enable_werror=no])
+
if test "x$enable_debug" = xyes; then
AS_COMPILER_FLAG([-g3], [DEBUG_CFLAGS="-g3"], [DEBUG_CFLAGS="-g"])
AS_COMPILER_FLAG([-Og], [DEBUG_CFLAGS+=" -Og -Wno-maybe-uninitialized"], # disable maybe-uninitialized due to false positives
@@ -236,6 +241,10 @@ if test "x$enable_debug" = xyes; then
AC_SUBST([DEBUG_CFLAGS])
fi
+if test "x$enable_werror" = xyes; then
+ AS_COMPILER_FLAG([-Werror], [WERROR_CFLAGS="-Werror"])
+fi
+
# prevent relinking the world on every commit for developers
AC_ARG_ENABLE(git-hash,
AS_HELP_STRING([--disable-git-hash],
@@ -313,6 +322,7 @@ echo " Overlay : X: ${enable_overlay_xlib}, Xv: ${enable_overla
echo " x86-specific tools : ${build_x86}"
echo ""
echo " • API-Documentation : ${enable_gtk_doc}"
+echo " • Fail on warnings: : ${enable_werror}"
echo ""
# vim: set ft=config ts=8 sw=8 tw=0 noet :
diff --git a/demos/Makefile.am b/demos/Makefile.am
index e6fbb3b..f5725f4 100644
--- a/demos/Makefile.am
+++ b/demos/Makefile.am
@@ -3,5 +3,6 @@ bin_PROGRAMS = \
$(NULL)
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
+ $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) $(WERROR_CFLAGS)
LDADD = $(top_builddir)/lib/libintel_tools.la
diff --git a/overlay/Makefile.am b/overlay/Makefile.am
index c648875..c926557 100644
--- a/overlay/Makefile.am
+++ b/overlay/Makefile.am
@@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
endif
AM_CPPFLAGS = -I.
-AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
+AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
+ $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS) $(WERROR_CLFAGS)
LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
intel_gpu_overlay_SOURCES = \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 45e3359..32b9115 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
-include "$(srcdir)/../lib/check-ndebug.h" \
-DIGT_SRCDIR=\""$(abs_srcdir)"\" \
-DIGT_DATADIR=\""$(pkgdatadir)"\" \
- $(LIBUNWIND_CFLAGS) \
+ $(LIBUNWIND_CFLAGS) $(WERROR_CFLAGS) \
$(NULL)
LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index df48d94..5f45144 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -3,7 +3,9 @@ include Makefile.sources
SUBDIRS = null_state_gen registers
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
-AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
+AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
+ $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\" \
+ $(WERROR_CFLAGS)
LDADD = $(top_builddir)/lib/libintel_tools.la
AM_LDFLAGS = -Wl,--as-needed
--
2.8.0.rc3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror.
2016-05-10 14:32 ` [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror Marius Vlad
@ 2016-05-10 15:42 ` Damien Lespiau
0 siblings, 0 replies; 7+ messages in thread
From: Damien Lespiau @ 2016-05-10 15:42 UTC (permalink / raw)
To: Marius Vlad; +Cc: intel-gfx
On Tue, May 10, 2016 at 05:32:15PM +0300, Marius Vlad wrote:
> v2: Initially added Werror by default. Make it optional so it doesn't
> break android build and (potential) distros maintaing the package
> (Hinted by Damien Lespiau).
>
> --enable-werror will enable -Werror compiler flag.
>
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
Looks like some people might want to use this:
Acked-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> benchmarks/Makefile.am | 3 ++-
> configure.ac | 10 ++++++++++
> demos/Makefile.am | 3 ++-
> overlay/Makefile.am | 3 ++-
> tests/Makefile.am | 2 +-
> tools/Makefile.am | 4 +++-
> 6 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
> index 2c2d100..49d2f64 100644
> --- a/benchmarks/Makefile.am
> +++ b/benchmarks/Makefile.am
> @@ -2,7 +2,8 @@
> include Makefile.sources
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
> + $(WERROR_CFLAGS)
> LDADD = $(top_builddir)/lib/libintel_tools.la
>
> benchmarks_LTLIBRARIES = gem_exec_tracer.la
> diff --git a/configure.ac b/configure.ac
> index 0589782..11b1d46 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -229,6 +229,11 @@ AC_ARG_ENABLE(debug,
> [Build tests without debug symbols]),
> [], [enable_debug=yes])
>
> +AC_ARG_ENABLE(werror,
> + AS_HELP_STRING([--enable-werror],
> + [Fail on warnings]),
> + [], [enable_werror=no])
> +
> if test "x$enable_debug" = xyes; then
> AS_COMPILER_FLAG([-g3], [DEBUG_CFLAGS="-g3"], [DEBUG_CFLAGS="-g"])
> AS_COMPILER_FLAG([-Og], [DEBUG_CFLAGS+=" -Og -Wno-maybe-uninitialized"], # disable maybe-uninitialized due to false positives
> @@ -236,6 +241,10 @@ if test "x$enable_debug" = xyes; then
> AC_SUBST([DEBUG_CFLAGS])
> fi
>
> +if test "x$enable_werror" = xyes; then
> + AS_COMPILER_FLAG([-Werror], [WERROR_CFLAGS="-Werror"])
> +fi
> +
> # prevent relinking the world on every commit for developers
> AC_ARG_ENABLE(git-hash,
> AS_HELP_STRING([--disable-git-hash],
> @@ -313,6 +322,7 @@ echo " Overlay : X: ${enable_overlay_xlib}, Xv: ${enable_overla
> echo " x86-specific tools : ${build_x86}"
> echo ""
> echo " • API-Documentation : ${enable_gtk_doc}"
> +echo " • Fail on warnings: : ${enable_werror}"
> echo ""
>
> # vim: set ft=config ts=8 sw=8 tw=0 noet :
> diff --git a/demos/Makefile.am b/demos/Makefile.am
> index e6fbb3b..f5725f4 100644
> --- a/demos/Makefile.am
> +++ b/demos/Makefile.am
> @@ -3,5 +3,6 @@ bin_PROGRAMS = \
> $(NULL)
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
> + $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) $(WERROR_CFLAGS)
> LDADD = $(top_builddir)/lib/libintel_tools.la
> diff --git a/overlay/Makefile.am b/overlay/Makefile.am
> index c648875..c926557 100644
> --- a/overlay/Makefile.am
> +++ b/overlay/Makefile.am
> @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
> endif
>
> AM_CPPFLAGS = -I.
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
> + $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS) $(WERROR_CLFAGS)
> LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
>
> intel_gpu_overlay_SOURCES = \
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 45e3359..32b9115 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
> -include "$(srcdir)/../lib/check-ndebug.h" \
> -DIGT_SRCDIR=\""$(abs_srcdir)"\" \
> -DIGT_DATADIR=\""$(pkgdatadir)"\" \
> - $(LIBUNWIND_CFLAGS) \
> + $(LIBUNWIND_CFLAGS) $(WERROR_CFLAGS) \
> $(NULL)
>
> LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index df48d94..5f45144 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -3,7 +3,9 @@ include Makefile.sources
> SUBDIRS = null_state_gen registers
>
> AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
> +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
> + $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\" \
> + $(WERROR_CFLAGS)
> LDADD = $(top_builddir)/lib/libintel_tools.la
> AM_LDFLAGS = -Wl,--as-needed
>
> --
> 2.8.0.rc3
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-05-10 15:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 13:23 [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default Marius Vlad
2016-05-09 15:25 ` Damien Lespiau
2016-05-09 15:55 ` Marius Vlad
2016-05-09 15:57 ` Damien Lespiau
2016-05-09 16:01 ` Morton, Derek J
2016-05-10 14:32 ` [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror Marius Vlad
2016-05-10 15:42 ` Damien Lespiau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.