From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Thu, 12 May 2016 12:55:36 +0200 [thread overview]
Message-ID: <20160512105536.GA17154@c203.arch.suse.de> (raw)
In-Reply-To: <20160511191632.GC31047@localhost.localdomain>
On Wed, May 11, 2016@03:16:33PM -0400, Keith Busch wrote:
> On Wed, May 11, 2016@11:25:16AM +0200, Johannes Thumshirn wrote:
> > What ever happened to this patch?
> > I can easily reproduce the bug using
> > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done
>
> This patch was supposed to fix using a doorbell between resets when the
> driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
> patch shouldn't be necessary: the doorbell is already set during queue
> allocation before requset_irq.
>
> The test doesn't seem like this patch would help either. It sounds
> more like you're hitting somethine else if you don't have this fix:
>
> https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
>
> If you do have that fix already, I'd like to see the panic stack trace
> (assuming that's what happened).
So for whatever reason I cannot reproduce it anymore with mainline, though I'm
sure I _did_ test mainline and it failed as well.
Sorry,
Johannes
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Wenbo Wang <mail_weber_wang@163.com>,
axboe@fb.com, stable@vger.kernel.org, wenwei.tao@memblaze.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Thu, 12 May 2016 12:55:36 +0200 [thread overview]
Message-ID: <20160512105536.GA17154@c203.arch.suse.de> (raw)
In-Reply-To: <20160511191632.GC31047@localhost.localdomain>
On Wed, May 11, 2016 at 03:16:33PM -0400, Keith Busch wrote:
> On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote:
> > What ever happened to this patch?
> > I can easily reproduce the bug using
> > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done
>
> This patch was supposed to fix using a doorbell between resets when the
> driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
> patch shouldn't be necessary: the doorbell is already set during queue
> allocation before requset_irq.
>
> The test doesn't seem like this patch would help either. It sounds
> more like you're hitting somethine else if you don't have this fix:
>
> https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
>
> If you do have that fix already, I'd like to see the panic stack trace
> (assuming that's what happened).
So for whatever reason I cannot reproduce it anymore with mainline, though I'm
sure I _did_ test mainline and it failed as well.
Sorry,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Wenbo Wang <mail_weber_wang@163.com>,
axboe@fb.com, stable@vger.kernel.org, wenwei.tao@memblaze.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Thu, 12 May 2016 12:55:36 +0200 [thread overview]
Message-ID: <20160512105536.GA17154@c203.arch.suse.de> (raw)
In-Reply-To: <20160511191632.GC31047@localhost.localdomain>
On Wed, May 11, 2016 at 03:16:33PM -0400, Keith Busch wrote:
> On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote:
> > What ever happened to this patch?
> > I can easily reproduce the bug using
> > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done
>
> This patch was supposed to fix using a doorbell between resets when the
> driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
> patch shouldn't be necessary: the doorbell is already set during queue
> allocation before requset_irq.
>
> The test doesn't seem like this patch would help either. It sounds
> more like you're hitting somethine else if you don't have this fix:
>
> https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
>
> If you do have that fix already, I'd like to see the panic stack trace
> (assuming that's what happened).
So for whatever reason I cannot reproduce it anymore with mainline, though I'm
sure I _did_ test mainline and it failed as well.
Sorry,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-05-12 10:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:48 [PATH v2] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20 10:48 ` Wenbo Wang
2016-01-20 12:34 ` Sagi Grimberg
2016-01-20 12:34 ` Sagi Grimberg
2016-01-20 14:57 ` Keith Busch
2016-01-20 14:57 ` Keith Busch
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 17:12 ` Greg KH
2016-01-20 17:12 ` Greg KH
2016-01-20 17:17 ` Jens Axboe
2016-01-20 17:17 ` Jens Axboe
2016-05-10 9:13 ` Johannes Thumshirn
2016-05-10 9:13 ` Johannes Thumshirn
2016-04-25 9:14 ` Johannes Thumshirn
2016-04-25 9:14 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 19:16 ` Keith Busch
2016-05-11 19:16 ` Keith Busch
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn [this message]
2016-05-12 10:55 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512105536.GA17154@c203.arch.suse.de \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.