From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 14:34:43 +0200 [thread overview]
Message-ID: <569F7EE3.1020504@dev.mellanox.co.il> (raw)
In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com>
> From: Wenbo Wang <wenbo.wang at memblaze.com>
>
> During reset process, the nvme_dev->bar (ioremapped) may change,
> so nvmeq->q_db shall be also updated by nvme_init_queue().
>
> Currently nvmeq irq is enabled before queue init, so a spurious
> interrupt triggered nvme_process_cq may access nvmeq->q_db just
> before it is updated, this could cause kernel panic.
>
> Signed-off-by: Wenbo Wang <wenbo.wang at memblaze.com>
> Reviewed-by: Wenwei Tao <wenwei.tao at memblaze.com>
You should add Cc: stable at vger.kernel.org here,
git-send-email will take care of the CC for you.
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Wenbo Wang <mail_weber_wang@163.com>,
keith.busch@intel.com, axboe@fb.com
Cc: stable@vger.kernel.org, wenwei.tao@memblaze.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 14:34:43 +0200 [thread overview]
Message-ID: <569F7EE3.1020504@dev.mellanox.co.il> (raw)
In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com>
> From: Wenbo Wang <wenbo.wang@memblaze.com>
>
> During reset process, the nvme_dev->bar (ioremapped) may change,
> so nvmeq->q_db shall be also updated by nvme_init_queue().
>
> Currently nvmeq irq is enabled before queue init, so a spurious
> interrupt triggered nvme_process_cq may access nvmeq->q_db just
> before it is updated, this could cause kernel panic.
>
> Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
> Reviewed-by: Wenwei Tao <wenwei.tao@memblaze.com>
You should add Cc: stable@vger.kernel.org here,
git-send-email will take care of the CC for you.
next prev parent reply other threads:[~2016-01-20 12:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:48 [PATH v2] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20 10:48 ` Wenbo Wang
2016-01-20 12:34 ` Sagi Grimberg [this message]
2016-01-20 12:34 ` Sagi Grimberg
2016-01-20 14:57 ` Keith Busch
2016-01-20 14:57 ` Keith Busch
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 17:12 ` Greg KH
2016-01-20 17:12 ` Greg KH
2016-01-20 17:17 ` Jens Axboe
2016-01-20 17:17 ` Jens Axboe
2016-05-10 9:13 ` Johannes Thumshirn
2016-05-10 9:13 ` Johannes Thumshirn
2016-04-25 9:14 ` Johannes Thumshirn
2016-04-25 9:14 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 19:16 ` Keith Busch
2016-05-11 19:16 ` Keith Busch
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F7EE3.1020504@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.