From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure
Date: Tue, 17 May 2016 10:27:12 +0900 [thread overview]
Message-ID: <20160517012712.GA497@swordfish> (raw)
In-Reply-To: <20160517011418.GB31335@bbox>
On (05/17/16 10:14), Minchan Kim wrote:
[..]
> > can we also switch create_cache() to errnos? I just like a bit
> > better
> > return -ENOMEM;
> > else
> > return 0;
> >
> > than
> >
> > return 1;
> > else
> > return 0;
> >
>
> Hmm, of course, I can do it easily.
> But zs_create_pool returns NULL without error propagation from sub
> functions so I don't see any gain from returning errno from
> create_cache. I don't mean I hate it but just need a justificaion
> to persuade grumpy me.
:) not married to those errnos. can skip it.
> > > +static struct zspage *isolate_zspage(struct size_class *class, bool source)
> > > {
> > > + struct zspage *zspage;
> > > + enum fullness_group fg[2] = {ZS_ALMOST_EMPTY, ZS_ALMOST_FULL};
> > > + if (!source) {
> > > + fg[0] = ZS_ALMOST_FULL;
> > > + fg[1] = ZS_ALMOST_EMPTY;
> > > + }
> > > +
> > > + for (i = 0; i < 2; i++) {
> >
> > sorry, why not "for (i = ZS_ALMOST_EMPTY; i <= ZS_ALMOST_FULL ..." ?
>
> For source zspage, the policy is to find a fragment object from ZS_ALMOST_EMPTY.
> For target zspage, the policy is to find a fragment object from ZS_ALMOST_FULL.
>
> Do I misunderstand your question?
ahhh... sorry, it's just me being silly. I got it now.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v5 08/12] zsmalloc: introduce zspage structure
Date: Tue, 17 May 2016 10:27:12 +0900 [thread overview]
Message-ID: <20160517012712.GA497@swordfish> (raw)
In-Reply-To: <20160517011418.GB31335@bbox>
On (05/17/16 10:14), Minchan Kim wrote:
[..]
> > can we also switch create_cache() to errnos? I just like a bit
> > better
> > return -ENOMEM;
> > else
> > return 0;
> >
> > than
> >
> > return 1;
> > else
> > return 0;
> >
>
> Hmm, of course, I can do it easily.
> But zs_create_pool returns NULL without error propagation from sub
> functions so I don't see any gain from returning errno from
> create_cache. I don't mean I hate it but just need a justificaion
> to persuade grumpy me.
:) not married to those errnos. can skip it.
> > > +static struct zspage *isolate_zspage(struct size_class *class, bool source)
> > > {
> > > + struct zspage *zspage;
> > > + enum fullness_group fg[2] = {ZS_ALMOST_EMPTY, ZS_ALMOST_FULL};
> > > + if (!source) {
> > > + fg[0] = ZS_ALMOST_FULL;
> > > + fg[1] = ZS_ALMOST_EMPTY;
> > > + }
> > > +
> > > + for (i = 0; i < 2; i++) {
> >
> > sorry, why not "for (i = ZS_ALMOST_EMPTY; i <= ZS_ALMOST_FULL ..." ?
>
> For source zspage, the policy is to find a fragment object from ZS_ALMOST_EMPTY.
> For target zspage, the policy is to find a fragment object from ZS_ALMOST_FULL.
>
> Do I misunderstand your question?
ahhh... sorry, it's just me being silly. I got it now.
-ss
next prev parent reply other threads:[~2016-05-17 1:27 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 2:20 [PATCH v5 00/13] Support non-lru page migration Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` [PATCH v5 01/12] mm: use put_page to free page instead of putback_lru_page Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 7:04 ` Sergey Senozhatsky
2016-05-16 7:04 ` Sergey Senozhatsky
2016-05-16 7:04 ` Sergey Senozhatsky
2016-05-17 1:16 ` Minchan Kim
2016-05-17 1:16 ` Minchan Kim
2016-05-17 1:16 ` Minchan Kim
2016-05-16 7:17 ` Sergey Senozhatsky
2016-05-16 7:17 ` Sergey Senozhatsky
2016-05-16 7:17 ` Sergey Senozhatsky
2016-05-17 1:18 ` Minchan Kim
2016-05-17 1:18 ` Minchan Kim
2016-05-17 1:18 ` Minchan Kim
2016-05-17 1:30 ` Sergey Senozhatsky
2016-05-17 1:30 ` Sergey Senozhatsky
2016-05-17 1:30 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 03/12] mm: balloon: use general non-lru movable page feature Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 19:16 ` kbuild test robot
2016-05-16 19:16 ` kbuild test robot
2016-05-16 19:16 ` kbuild test robot
2016-05-09 2:20 ` [PATCH v5 04/12] zsmalloc: keep max_object in size_class Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` [PATCH v5 05/12] zsmalloc: use bit_spin_lock Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 1:17 ` Sergey Senozhatsky
2016-05-16 1:17 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 06/12] zsmalloc: use accessor Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 1:48 ` Sergey Senozhatsky
2016-05-16 1:48 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 07/12] zsmalloc: factor page chain functionality out Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 2:14 ` Sergey Senozhatsky
2016-05-16 2:14 ` Sergey Senozhatsky
2016-05-17 1:02 ` Minchan Kim
2016-05-17 1:02 ` Minchan Kim
2016-05-09 2:20 ` [PATCH v5 08/12] zsmalloc: introduce zspage structure Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 3:09 ` Sergey Senozhatsky
2016-05-16 3:09 ` Sergey Senozhatsky
2016-05-17 1:14 ` Minchan Kim
2016-05-17 1:14 ` Minchan Kim
2016-05-17 1:27 ` Sergey Senozhatsky [this message]
2016-05-17 1:27 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 09/12] zsmalloc: separate free_zspage from putback_zspage Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 3:15 ` Sergey Senozhatsky
2016-05-16 3:15 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 10/12] zsmalloc: use freeobj for index Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-09 2:20 ` [PATCH v5 11/12] zsmalloc: page migration support Minchan Kim
2016-05-09 2:20 ` Minchan Kim
2016-05-16 19:33 ` kbuild test robot
2016-05-16 19:33 ` kbuild test robot
2016-05-09 2:20 ` [PATCH v5 12/12] zram: use __GFP_MOVABLE for memory allocation Minchan Kim
2016-05-09 2:20 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517012712.GA497@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.