Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Rik van Riel <riel@redhat.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Rafael Aquini <aquini@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Hugh Dickins <hughd@google.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	John Einar Reitan <john.reitan@foss.arm.com>,
	linux-mm@kvack.org, Gioh Kim <gi-oh.kim@profitbricks.com>,
	Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration
Date: Tue, 17 May 2016 10:18:50 +0900	[thread overview]
Message-ID: <20160517011850.GD31335@bbox> (raw)
In-Reply-To: <20160516071751.GA32079@swordfish>

On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> [..]
> > +++ b/include/linux/migrate.h
> > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES];
> >  
> >  #ifdef CONFIG_MIGRATION
> >  
> > +extern int PageMovable(struct page *page);
> > +extern void __SetPageMovable(struct page *page, struct address_space *mapping);
> > +extern void __ClearPageMovable(struct page *page);
> >  extern void putback_movable_pages(struct list_head *l);
> >  extern int migrate_page(struct address_space *,
> >  			struct page *, struct page *, enum migrate_mode);
> >  extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> >  		unsigned long private, enum migrate_mode mode, int reason);
> > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
> > +extern void putback_movable_page(struct page *page);
> >  
> >  extern int migrate_prep(void);
> >  extern int migrate_prep_local(void);
> 
> given that some of Movable users can be built as modules, shouldn't
> at least some of those symbols be exported via EXPORT_SYMBOL?

Those functions aim for VM compaction so driver shouldn't use it.
Only driver should be aware of are __SetPageMovable and __CleraPageMovable.
I will export them.

Thanks for the review, Sergey!
> 
> 	-ss

WARNING: multiple messages have this Message-ID (diff)

From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
	Rafael Aquini <aquini@redhat.com>,
	virtualization@lists.linux-foundation.org,
	Jonathan Corbet <corbet@lwn.net>,
	John Einar Reitan <john.reitan@foss.arm.com>,
	dri-devel@lists.freedesktop.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Gioh Kim <gi-oh.kim@profitbricks.com>
Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration
Date: Tue, 17 May 2016 10:18:50 +0900	[thread overview]
Message-ID: <20160517011850.GD31335@bbox> (raw)
In-Reply-To: <20160516071751.GA32079@swordfish>

On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> [..]
> > +++ b/include/linux/migrate.h
> > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES];
> >  
> >  #ifdef CONFIG_MIGRATION
> >  
> > +extern int PageMovable(struct page *page);
> > +extern void __SetPageMovable(struct page *page, struct address_space *mapping);
> > +extern void __ClearPageMovable(struct page *page);
> >  extern void putback_movable_pages(struct list_head *l);
> >  extern int migrate_page(struct address_space *,
> >  			struct page *, struct page *, enum migrate_mode);
> >  extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> >  		unsigned long private, enum migrate_mode mode, int reason);
> > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
> > +extern void putback_movable_page(struct page *page);
> >  
> >  extern int migrate_prep(void);
> >  extern int migrate_prep_local(void);
> 
> given that some of Movable users can be built as modules, shouldn't
> at least some of those symbols be exported via EXPORT_SYMBOL?

Those functions aim for VM compaction so driver shouldn't use it.
Only driver should be aware of are __SetPageMovable and __CleraPageMovable.
I will export them.

Thanks for the review, Sergey!
> 
> 	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
	Rafael Aquini <aquini@redhat.com>,
	<virtualization@lists.linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	John Einar Reitan <john.reitan@foss.arm.com>,
	<dri-devel@lists.freedesktop.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Gioh Kim <gi-oh.kim@profitbricks.com>
Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration
Date: Tue, 17 May 2016 10:18:50 +0900	[thread overview]
Message-ID: <20160517011850.GD31335@bbox> (raw)
In-Reply-To: <20160516071751.GA32079@swordfish>

On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> [..]
> > +++ b/include/linux/migrate.h
> > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES];
> >  
> >  #ifdef CONFIG_MIGRATION
> >  
> > +extern int PageMovable(struct page *page);
> > +extern void __SetPageMovable(struct page *page, struct address_space *mapping);
> > +extern void __ClearPageMovable(struct page *page);
> >  extern void putback_movable_pages(struct list_head *l);
> >  extern int migrate_page(struct address_space *,
> >  			struct page *, struct page *, enum migrate_mode);
> >  extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> >  		unsigned long private, enum migrate_mode mode, int reason);
> > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
> > +extern void putback_movable_page(struct page *page);
> >  
> >  extern int migrate_prep(void);
> >  extern int migrate_prep_local(void);
> 
> given that some of Movable users can be built as modules, shouldn't
> at least some of those symbols be exported via EXPORT_SYMBOL?

Those functions aim for VM compaction so driver shouldn't use it.
Only driver should be aware of are __SetPageMovable and __CleraPageMovable.
I will export them.

Thanks for the review, Sergey!
> 
> 	-ss

next prev parent reply	other threads:[~2016-05-17  1:18 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09  2:20 [PATCH v5 00/13] Support non-lru page migration Minchan Kim
2016-05-09  2:20 ` Minchan Kim
2016-05-09  2:20 ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 01/12] mm: use put_page to free page instead of putback_lru_page Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  7:04   ` Sergey Senozhatsky
2016-05-16  7:04     ` Sergey Senozhatsky
2016-05-17  1:16     ` Minchan Kim
2016-05-17  1:16       ` Minchan Kim
2016-05-17  1:16     ` Minchan Kim
2016-05-16  7:04   ` Sergey Senozhatsky
2016-05-16  7:17   ` Sergey Senozhatsky
2016-05-16  7:17     ` Sergey Senozhatsky
2016-05-16  7:17     ` Sergey Senozhatsky
2016-05-17  1:18     ` Minchan Kim [this message]
2016-05-17  1:18       ` Minchan Kim
2016-05-17  1:18       ` Minchan Kim
2016-05-17  1:30       ` Sergey Senozhatsky
2016-05-17  1:30         ` Sergey Senozhatsky
2016-05-17  1:30       ` Sergey Senozhatsky
2016-05-09  2:20 ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 03/12] mm: balloon: use general non-lru movable page feature Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16 19:16   ` kbuild test robot
2016-05-16 19:16     ` kbuild test robot
2016-05-16 19:16     ` kbuild test robot
2016-05-09  2:20 ` [PATCH v5 04/12] zsmalloc: keep max_object in size_class Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 05/12] zsmalloc: use bit_spin_lock Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  1:17   ` Sergey Senozhatsky
2016-05-16  1:17     ` Sergey Senozhatsky
2016-05-09  2:20 ` [PATCH v5 06/12] zsmalloc: use accessor Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  1:48   ` Sergey Senozhatsky
2016-05-16  1:48     ` Sergey Senozhatsky
2016-05-09  2:20 ` [PATCH v5 07/12] zsmalloc: factor page chain functionality out Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  2:14   ` Sergey Senozhatsky
2016-05-16  2:14     ` Sergey Senozhatsky
2016-05-17  1:02     ` Minchan Kim
2016-05-17  1:02       ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 08/12] zsmalloc: introduce zspage structure Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  3:09   ` Sergey Senozhatsky
2016-05-16  3:09     ` Sergey Senozhatsky
2016-05-17  1:14     ` Minchan Kim
2016-05-17  1:14       ` Minchan Kim
2016-05-17  1:27       ` Sergey Senozhatsky
2016-05-17  1:27         ` Sergey Senozhatsky
2016-05-09  2:20 ` [PATCH v5 09/12] zsmalloc: separate free_zspage from putback_zspage Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16  3:15   ` Sergey Senozhatsky
2016-05-16  3:15     ` Sergey Senozhatsky
2016-05-09  2:20 ` [PATCH v5 10/12] zsmalloc: use freeobj for index Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-09  2:20 ` [PATCH v5 11/12] zsmalloc: page migration support Minchan Kim
2016-05-09  2:20   ` Minchan Kim
2016-05-16 19:33   ` kbuild test robot
2016-05-16 19:33     ` kbuild test robot
2016-05-09  2:20 ` [PATCH v5 12/12] zram: use __GFP_MOVABLE for memory allocation Minchan Kim
2016-05-09  2:20   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517011850.GD31335@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gi-oh.kim@profitbricks.com \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=john.reitan@foss.arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.