All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Jonathan Liu <net147@gmail.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	David Daney <david.daney@cavium.com>,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
	Dann Frazier <dann.frazier@canonical.com>,
	Ming Lei <ming.lei@canonical.com>, Jiri Slaby <jslaby@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	"Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	stable@vger.kernel.org, ddaney.cavm@gmail.com,
	Alistair Popple <alistair@popple.id.au>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid
Date: Thu, 19 May 2016 09:01:39 +0000	[thread overview]
Message-ID: <20160519090139.GA1539@amd> (raw)
In-Reply-To: <alpine.DEB.2.10.1605182252230.12118@laptop>

Hi!

> Two current [1] and three previous [2] systems locked during boot
> because the cursor flash timer was set using an ops->cur_blink_jiffies
> value of 0. Previous patches attempted to solve the problem by moving
> variable initialization earlier in the setup sequence [2].
> 
> Use the normal cursor blink default interval of 200 ms if
> ops->cur_blink_jiffies is not in the range specified in commit
> bd63364caa8d. Since invalid values are not used, specific system
> initialization timings should not cause lockups.
> 
> [1] https://bugs.launchpad.net/bugs/1574814
> [2] see commits: 2a17d7e80f1d, f235f664a8af, a1e533ec07d5

Acked-by: Pavel Machek <pavel@ucw.cz>

>  static void cursor_timer_handler(unsigned long dev_addr)
>  {
>  	struct fb_info *info = (struct fb_info *) dev_addr;
>  	struct fbcon_ops *ops = info->fbcon_par;
>  
>  	queue_work(system_power_efficient_wq, &info->queue);
> -	mod_timer(&ops->cursor_timer, jiffies + ops->cur_blink_jiffies);
> +	mod_timer(&ops->cursor_timer, jiffies +
> +	    cursor_blink_jiffies(ops->cur_blink_jiffies));
>  }
>  
>  static void fbcon_add_cursor_timer(struct fb_info *info)

And actually... perhaps mod_timer should have some check for too low
timeouts..?

WARN_ON?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Jonathan Liu <net147@gmail.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	David Daney <david.daney@cavium.com>,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
	Dann Frazier <dann.frazier@canonical.com>,
	Ming Lei <ming.lei@canonical.com>, Jiri Slaby <jslaby@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	"Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	stable@vger.kernel.org, ddaney.cavm@gmail.com,
	Alistair Popple <alistair@popple.id.au>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid
Date: Thu, 19 May 2016 11:01:39 +0200	[thread overview]
Message-ID: <20160519090139.GA1539@amd> (raw)
In-Reply-To: <alpine.DEB.2.10.1605182252230.12118@laptop>

Hi!

> Two current [1] and three previous [2] systems locked during boot
> because the cursor flash timer was set using an ops->cur_blink_jiffies
> value of 0. Previous patches attempted to solve the problem by moving
> variable initialization earlier in the setup sequence [2].
> 
> Use the normal cursor blink default interval of 200 ms if
> ops->cur_blink_jiffies is not in the range specified in commit
> bd63364caa8d. Since invalid values are not used, specific system
> initialization timings should not cause lockups.
> 
> [1] https://bugs.launchpad.net/bugs/1574814
> [2] see commits: 2a17d7e80f1d, f235f664a8af, a1e533ec07d5

Acked-by: Pavel Machek <pavel@ucw.cz>

>  static void cursor_timer_handler(unsigned long dev_addr)
>  {
>  	struct fb_info *info = (struct fb_info *) dev_addr;
>  	struct fbcon_ops *ops = info->fbcon_par;
>  
>  	queue_work(system_power_efficient_wq, &info->queue);
> -	mod_timer(&ops->cursor_timer, jiffies + ops->cur_blink_jiffies);
> +	mod_timer(&ops->cursor_timer, jiffies +
> +	    cursor_blink_jiffies(ops->cur_blink_jiffies));
>  }
>  
>  static void fbcon_add_cursor_timer(struct fb_info *info)

And actually... perhaps mod_timer should have some check for too low
timeouts..?

WARN_ON?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	David Daney <david.daney@cavium.com>,
	Ming Lei <ming.lei@canonical.com>,
	Dann Frazier <dann.frazier@canonical.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	Jonathan Liu <net147@gmail.com>,
	Alistair Popple <alistair@popple.id.au>,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
	"Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, David Airlie <airlied@linux.ie>,
	ddaney.cavm@gmail.com, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid
Date: Thu, 19 May 2016 11:01:39 +0200	[thread overview]
Message-ID: <20160519090139.GA1539@amd> (raw)
In-Reply-To: <alpine.DEB.2.10.1605182252230.12118@laptop>

Hi!

> Two current [1] and three previous [2] systems locked during boot
> because the cursor flash timer was set using an ops->cur_blink_jiffies
> value of 0. Previous patches attempted to solve the problem by moving
> variable initialization earlier in the setup sequence [2].
> 
> Use the normal cursor blink default interval of 200 ms if
> ops->cur_blink_jiffies is not in the range specified in commit
> bd63364caa8d. Since invalid values are not used, specific system
> initialization timings should not cause lockups.
> 
> [1] https://bugs.launchpad.net/bugs/1574814
> [2] see commits: 2a17d7e80f1d, f235f664a8af, a1e533ec07d5

Acked-by: Pavel Machek <pavel@ucw.cz>

>  static void cursor_timer_handler(unsigned long dev_addr)
>  {
>  	struct fb_info *info = (struct fb_info *) dev_addr;
>  	struct fbcon_ops *ops = info->fbcon_par;
>  
>  	queue_work(system_power_efficient_wq, &info->queue);
> -	mod_timer(&ops->cursor_timer, jiffies + ops->cur_blink_jiffies);
> +	mod_timer(&ops->cursor_timer, jiffies +
> +	    cursor_blink_jiffies(ops->cur_blink_jiffies));
>  }
>  
>  static void fbcon_add_cursor_timer(struct fb_info *info)

And actually... perhaps mod_timer should have some check for too low
timeouts..?

WARN_ON?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2016-05-19  9:01 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 18:41 [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer David Daney
2016-05-17 20:49 ` Pavel Machek
2016-05-18  0:42   ` Ming Lei
2016-05-18 20:24     ` Scot Doyle
2016-05-18 20:38       ` David Daney
2016-05-18 20:38         ` David Daney
2016-05-19  4:21         ` [PATCH] fbcon: use default if cursor blink interval is not valid Scot Doyle
2016-05-19  4:21           ` Scot Doyle
2016-05-19  7:25           ` Jeremy Kerr
2016-05-19  7:25             ` Jeremy Kerr
2016-05-19  8:29           ` Ming Lei
2016-05-19  8:29             ` Ming Lei
2016-05-19  9:01           ` Pavel Machek [this message]
2016-05-19  9:01             ` Pavel Machek
2016-05-19  9:01             ` Pavel Machek
2016-05-19 14:22             ` Scot Doyle
2016-05-19 14:22               ` Scot Doyle
2016-05-19 15:31               ` Ming Lei
2016-05-19 15:31                 ` Ming Lei
2016-05-19 15:59           ` David Daney
2016-05-19 15:59             ` David Daney
2016-05-19 15:59             ` David Daney
2016-05-19 22:25             ` Scot Doyle
2016-05-19 22:25               ` Scot Doyle
2016-05-19 22:31               ` [PATCH] fbcon: warn on invalid cursor blink intervals Scot Doyle
2016-05-19 22:31                 ` Scot Doyle
2016-05-19 22:50                 ` David Daney
2016-05-19 22:50                   ` David Daney
2016-05-19 22:50                   ` David Daney
2016-05-20  1:21                 ` Jeremy Kerr
2016-05-20  1:21                   ` Jeremy Kerr
2016-05-20  2:17                 ` Ming Lei
2016-05-20  2:17                   ` Ming Lei
2016-05-20  2:26                   ` Jeremy Kerr
2016-05-20  2:26                     ` Jeremy Kerr
2016-05-20  2:48                     ` Ming Lei
2016-05-20  2:48                       ` Ming Lei
2016-05-20  5:04                       ` Jeremy Kerr
2016-05-20  5:04                         ` Jeremy Kerr
2016-05-20 16:27                         ` Scot Doyle
2016-05-20 16:27                           ` Scot Doyle
2016-05-24  1:19                           ` Scot Doyle
2016-05-24  1:19                             ` Scot Doyle
2016-05-28 11:48                           ` Henrique de Moraes Holschuh
2016-05-28 11:48                             ` Henrique de Moraes Holschuh
2016-06-12  5:05                             ` Chintakuntla, Radha
2016-05-28 11:45                 ` Henrique de Moraes Holschuh
2016-05-28 11:45                   ` Henrique de Moraes Holschuh
2016-05-19  0:27       ` [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer Ming Lei
2016-05-19  7:08         ` Pavel Machek
2016-05-19 22:35 ` Scot Doyle
2016-05-28 11:44 ` Henrique de Moraes Holschuh
2016-06-14 16:22 ` Ping: " David Daney
2016-06-14 16:22   ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519090139.GA1539@amd \
    --to=pavel@ucw.cz \
    --cc=Radha.Chintakuntla@caviumnetworks.com \
    --cc=alistair@popple.id.au \
    --cc=dann.frazier@canonical.com \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jean-philippe.brucker@arm.com \
    --cc=jslaby@suse.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml14@scotdoyle.com \
    --cc=ming.lei@canonical.com \
    --cc=net147@gmail.com \
    --cc=peter@hurleysoftware.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=stable@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.