From: carlo@caione.org (Carlo Caione)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms
Date: Fri, 20 May 2016 11:10:50 +0200 [thread overview]
Message-ID: <20160520091050.GC19888@mephisto> (raw)
In-Reply-To: <573ED06F.9070909@baylibre.com>
On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> index 832815d..2463e04 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> @@ -129,6 +129,12 @@
> >> #size-cells = <2>;
> >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
> >>
> >> + reset: reset-controller at 4404 {
> >> + compatible = "amlogic,meson-gxbb-reset";
> >> + reg = <0x0 0x04404 0x0 0x20>;
> >> + #reset-cells = <1>;
> >> + };
> >> +
> >> uart_A: serial at 84c0 {
> >> compatible = "amlogic,meson-uart";
> >> reg = <0x0 0x084c0 0x0 0x14>;
> >
> > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> >
> > Thanks,
> >
>
> Shouldn't we wait until the reset bindings are actually used in the dtsi ?
> I'm quite sure kevin will post it with the Ethernet nodes.
Why? The header file is related to the reset controller. Better add it
now with this patchset.
Cheers,
--
Carlo Caione
WARNING: multiple messages have this Message-ID (diff)
From: carlo@caione.org (Carlo Caione)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms
Date: Fri, 20 May 2016 11:10:50 +0200 [thread overview]
Message-ID: <20160520091050.GC19888@mephisto> (raw)
In-Reply-To: <573ED06F.9070909@baylibre.com>
On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> index 832815d..2463e04 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> @@ -129,6 +129,12 @@
> >> #size-cells = <2>;
> >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
> >>
> >> + reset: reset-controller at 4404 {
> >> + compatible = "amlogic,meson-gxbb-reset";
> >> + reg = <0x0 0x04404 0x0 0x20>;
> >> + #reset-cells = <1>;
> >> + };
> >> +
> >> uart_A: serial at 84c0 {
> >> compatible = "amlogic,meson-uart";
> >> reg = <0x0 0x084c0 0x0 0x14>;
> >
> > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> >
> > Thanks,
> >
>
> Shouldn't we wait until the reset bindings are actually used in the dtsi ?
> I'm quite sure kevin will post it with the Ethernet nodes.
Why? The header file is related to the reset controller. Better add it
now with this patchset.
Cheers,
--
Carlo Caione
WARNING: multiple messages have this Message-ID (diff)
From: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
To: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xing.xu-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org,
victor.wan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms
Date: Fri, 20 May 2016 11:10:50 +0200 [thread overview]
Message-ID: <20160520091050.GC19888@mephisto> (raw)
In-Reply-To: <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> index 832815d..2463e04 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> @@ -129,6 +129,12 @@
> >> #size-cells = <2>;
> >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
> >>
> >> + reset: reset-controller@4404 {
> >> + compatible = "amlogic,meson-gxbb-reset";
> >> + reg = <0x0 0x04404 0x0 0x20>;
> >> + #reset-cells = <1>;
> >> + };
> >> +
> >> uart_A: serial@84c0 {
> >> compatible = "amlogic,meson-uart";
> >> reg = <0x0 0x084c0 0x0 0x14>;
> >
> > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> >
> > Thanks,
> >
>
> Shouldn't we wait until the reset bindings are actually used in the dtsi ?
> I'm quite sure kevin will post it with the Ethernet nodes.
Why? The header file is related to the reset controller. Better add it
now with this patchset.
Cheers,
--
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Carlo Caione <carlo@caione.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: devicetree@vger.kernel.org, xing.xu@amlogic.com,
victor.wan@amlogic.com, linux-kernel@vger.kernel.org,
p.zabel@pengutronix.de, jerry.cao@amlogic.com,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms
Date: Fri, 20 May 2016 11:10:50 +0200 [thread overview]
Message-ID: <20160520091050.GC19888@mephisto> (raw)
In-Reply-To: <573ED06F.9070909@baylibre.com>
On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> index 832815d..2463e04 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> @@ -129,6 +129,12 @@
> >> #size-cells = <2>;
> >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
> >>
> >> + reset: reset-controller@4404 {
> >> + compatible = "amlogic,meson-gxbb-reset";
> >> + reg = <0x0 0x04404 0x0 0x20>;
> >> + #reset-cells = <1>;
> >> + };
> >> +
> >> uart_A: serial@84c0 {
> >> compatible = "amlogic,meson-uart";
> >> reg = <0x0 0x084c0 0x0 0x14>;
> >
> > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> >
> > Thanks,
> >
>
> Shouldn't we wait until the reset bindings are actually used in the dtsi ?
> I'm quite sure kevin will post it with the Ethernet nodes.
Why? The header file is related to the reset controller. Better add it
now with this patchset.
Cheers,
--
Carlo Caione
next prev parent reply other threads:[~2016-05-20 9:10 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:27 [PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 10:04 ` Carlo Caione
2016-05-20 10:04 ` Carlo Caione
2016-05-20 10:04 ` Carlo Caione
2016-05-20 12:20 ` Neil Armstrong
2016-05-20 12:20 ` Neil Armstrong
2016-05-20 12:20 ` Neil Armstrong
2016-05-20 12:25 ` Carlo Caione
2016-05-20 12:25 ` Carlo Caione
2016-05-20 12:25 ` Carlo Caione
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 8:27 ` [PATCH 2/3] dt-bindings: reset: Add bindings for the " Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 9:08 ` Carlo Caione
2016-05-20 9:08 ` Carlo Caione
2016-05-20 9:08 ` Carlo Caione
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-23 21:04 ` Rob Herring
2016-05-23 21:04 ` Rob Herring
2016-05-23 21:04 ` Rob Herring
2016-05-20 8:27 ` [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 9:10 ` Carlo Caione [this message]
2016-05-20 9:10 ` Carlo Caione
2016-05-20 9:10 ` Carlo Caione
2016-05-20 9:10 ` Carlo Caione
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:23 ` Neil Armstrong
2016-05-20 12:23 ` Neil Armstrong
2016-05-20 12:23 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520091050.GC19888@mephisto \
--to=carlo@caione.org \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.