From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Fri, 20 May 2016 14:20:25 +0200 [thread overview]
Message-ID: <573F0109.9080302@baylibre.com> (raw)
In-Reply-To: <20160520100437.GA21213@mephisto>
On 05/20/2016 12:04 PM, Carlo Caione wrote:
> On 20/05/16 11:10, Neil Armstrong wrote:
>> On 05/20/2016 11:04 AM, Carlo Caione wrote:
>>> On 20/05/16 10:27, Neil Armstrong wrote:
>>>> This patch adds the platform driver for the Amlogic Meson GXBB Reset
>>>> Controller.
>>>>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> drivers/reset/Kconfig | 6 ++
>>>> drivers/reset/Makefile | 1 +
>>>> drivers/reset/reset-meson-gxbb.c | 129 +++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 136 insertions(+)
>>>> create mode 100644 drivers/reset/reset-meson-gxbb.c
>>>
>>> Do we really need to be that specific (-gxbb)? This driver looks generic
>>> and simple enough to be used for several Amlogic families. You are
>>> already differentiating between them with the include file defining the
>>> reset indexes for the SoC.
>>
>> This is a good question, do the S805 have similar registers ? Same count and width ?
>> I no, it should need a rework to add a data structure per-SoC.
>
> According to the datasheet on S805 we have 7 registers with 16 reset
> bits per register.
It will fit, I made the change to be generic. Do you know if the meson8 and previous meson6 has these registers ?
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Fri, 20 May 2016 14:20:25 +0200 [thread overview]
Message-ID: <573F0109.9080302@baylibre.com> (raw)
In-Reply-To: <20160520100437.GA21213@mephisto>
On 05/20/2016 12:04 PM, Carlo Caione wrote:
> On 20/05/16 11:10, Neil Armstrong wrote:
>> On 05/20/2016 11:04 AM, Carlo Caione wrote:
>>> On 20/05/16 10:27, Neil Armstrong wrote:
>>>> This patch adds the platform driver for the Amlogic Meson GXBB Reset
>>>> Controller.
>>>>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> drivers/reset/Kconfig | 6 ++
>>>> drivers/reset/Makefile | 1 +
>>>> drivers/reset/reset-meson-gxbb.c | 129 +++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 136 insertions(+)
>>>> create mode 100644 drivers/reset/reset-meson-gxbb.c
>>>
>>> Do we really need to be that specific (-gxbb)? This driver looks generic
>>> and simple enough to be used for several Amlogic families. You are
>>> already differentiating between them with the include file defining the
>>> reset indexes for the SoC.
>>
>> This is a good question, do the S805 have similar registers ? Same count and width ?
>> I no, it should need a rework to add a data structure per-SoC.
>
> According to the datasheet on S805 we have 7 registers with 16 reset
> bits per register.
It will fit, I made the change to be generic. Do you know if the meson8 and previous meson6 has these registers ?
Neil
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Carlo Caione <carlo@caione.org>
Cc: xing.xu@amlogic.com, victor.wan@amlogic.com,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
jerry.cao@amlogic.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Fri, 20 May 2016 14:20:25 +0200 [thread overview]
Message-ID: <573F0109.9080302@baylibre.com> (raw)
In-Reply-To: <20160520100437.GA21213@mephisto>
On 05/20/2016 12:04 PM, Carlo Caione wrote:
> On 20/05/16 11:10, Neil Armstrong wrote:
>> On 05/20/2016 11:04 AM, Carlo Caione wrote:
>>> On 20/05/16 10:27, Neil Armstrong wrote:
>>>> This patch adds the platform driver for the Amlogic Meson GXBB Reset
>>>> Controller.
>>>>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> drivers/reset/Kconfig | 6 ++
>>>> drivers/reset/Makefile | 1 +
>>>> drivers/reset/reset-meson-gxbb.c | 129 +++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 136 insertions(+)
>>>> create mode 100644 drivers/reset/reset-meson-gxbb.c
>>>
>>> Do we really need to be that specific (-gxbb)? This driver looks generic
>>> and simple enough to be used for several Amlogic families. You are
>>> already differentiating between them with the include file defining the
>>> reset indexes for the SoC.
>>
>> This is a good question, do the S805 have similar registers ? Same count and width ?
>> I no, it should need a rework to add a data structure per-SoC.
>
> According to the datasheet on S805 we have 7 registers with 16 reset
> bits per register.
It will fit, I made the change to be generic. Do you know if the meson8 and previous meson6 has these registers ?
Neil
next prev parent reply other threads:[~2016-05-20 12:20 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:27 [PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:04 ` Carlo Caione
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:10 ` Neil Armstrong
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 9:28 ` Philipp Zabel
2016-05-20 10:04 ` Carlo Caione
2016-05-20 10:04 ` Carlo Caione
2016-05-20 10:04 ` Carlo Caione
2016-05-20 12:20 ` Neil Armstrong [this message]
2016-05-20 12:20 ` Neil Armstrong
2016-05-20 12:20 ` Neil Armstrong
2016-05-20 12:25 ` Carlo Caione
2016-05-20 12:25 ` Carlo Caione
2016-05-20 12:25 ` Carlo Caione
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 9:27 ` Philipp Zabel
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 8:27 ` [PATCH 2/3] dt-bindings: reset: Add bindings for the " Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 9:08 ` Carlo Caione
2016-05-20 9:08 ` Carlo Caione
2016-05-20 9:08 ` Carlo Caione
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-20 12:18 ` Neil Armstrong
2016-05-23 21:04 ` Rob Herring
2016-05-23 21:04 ` Rob Herring
2016-05-23 21:04 ` Rob Herring
2016-05-20 8:27 ` [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:27 ` Neil Armstrong
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 8:53 ` Neil Armstrong
2016-05-20 9:10 ` Carlo Caione
2016-05-20 9:10 ` Carlo Caione
2016-05-20 9:10 ` Carlo Caione
2016-05-20 9:10 ` Carlo Caione
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:23 ` Neil Armstrong
2016-05-20 12:23 ` Neil Armstrong
2016-05-20 12:23 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573F0109.9080302@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.