All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	"Xiao, Guangrong" <guangrong.xiao@intel.com>,
	kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, "Lai,
	Paul C" <paul.c.lai@intel.com>,
	mtosatti@redhat.com, qemu-devel@nongnu.org, "Yu,
	Fenghua" <fenghua.yu@intel.com>,
	"Wang, Yong Y" <yong.y.wang@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
	imammedo@redhat.com, dan.j.williams@intel.com, "Kasten,
	Robert A" <robert.a.kasten@intel.com>,
	"ruwang@redhat.com" <ruwang@redhat.com>,
	rth@twiddle.net
Subject: [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model
Date: Fri, 20 May 2016 18:39:30 -0300	[thread overview]
Message-ID: <20160520213930.GA24914@thinpad.lan.raisama.net> (raw)
In-Reply-To: <573471D6.8050102@redhat.com>

Introduce Skylake-Client CPU model, which inherits the features
from Broadwell and supports some additional features that are:
MPX, XSAVEC, and XGETBV1.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Remove XSAVES, edited commit message
---
 target-i386/cpu.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 895a386..9c5aabc 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1239,6 +1239,51 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .model_id = "Intel Core Processor (Broadwell)",
     },
     {
+        .name = "Skylake-Client",
+        .level = 0xd,
+        .vendor = CPUID_VENDOR_INTEL,
+        .family = 6,
+        .model = 94,
+        .stepping = 3,
+        .features[FEAT_1_EDX] =
+            CPUID_VME | CPUID_SSE2 | CPUID_SSE | CPUID_FXSR | CPUID_MMX |
+            CPUID_CLFLUSH | CPUID_PSE36 | CPUID_PAT | CPUID_CMOV | CPUID_MCA |
+            CPUID_PGE | CPUID_MTRR | CPUID_SEP | CPUID_APIC | CPUID_CX8 |
+            CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE |
+            CPUID_DE | CPUID_FP87,
+        .features[FEAT_1_ECX] =
+            CPUID_EXT_AVX | CPUID_EXT_XSAVE | CPUID_EXT_AES |
+            CPUID_EXT_POPCNT | CPUID_EXT_X2APIC | CPUID_EXT_SSE42 |
+            CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 |
+            CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 |
+            CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_FMA | CPUID_EXT_MOVBE |
+            CPUID_EXT_PCID | CPUID_EXT_F16C | CPUID_EXT_RDRAND,
+        .features[FEAT_8000_0001_EDX] =
+            CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX |
+            CPUID_EXT2_SYSCALL,
+        .features[FEAT_8000_0001_ECX] =
+            CPUID_EXT3_ABM | CPUID_EXT3_LAHF_LM | CPUID_EXT3_3DNOWPREFETCH,
+        .features[FEAT_7_0_EBX] =
+            CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 |
+            CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP |
+            CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_INVPCID |
+            CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_ADX |
+            CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_MPX,
+        /* Missing: XSAVES (not supported by some Linux versions,
+         * including v4.1 to v4.6).
+         * KVM doesn't yet expose any XSAVES state save component,
+         * and the only one defined in Skylake (processor tracing)
+         * probably will block migration anyway.
+         */
+        .features[FEAT_XSAVE] =
+            CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XSAVEC |
+            CPUID_XSAVE_XGETBV1,
+        .features[FEAT_6_EAX] =
+            CPUID_6_EAX_ARAT,
+        .xlevel = 0x80000008,
+        .model_id = "Intel Core Processor (Skylake)",
+    },
+    {
         .name = "Opteron_G1",
         .level = 5,
         .vendor = CPUID_VENDOR_AMD,
-- 
2.5.5


WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	"Xiao, Guangrong" <guangrong.xiao@intel.com>,
	kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, "Lai,
	Paul C" <paul.c.lai@intel.com>,
	mtosatti@redhat.com, "Yu, Fenghua" <fenghua.yu@intel.com>,
	"Wang, Yong Y" <yong.y.wang@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
	imammedo@redhat.com, dan.j.williams@intel.com, "Kasten,
	Robert A" <robert.a.kasten@intel.com>,
	"ruwang@redhat.com" <ruwang@redhat.com>,
	rth@twiddle.net
Subject: [Qemu-devel] [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model
Date: Fri, 20 May 2016 18:39:30 -0300	[thread overview]
Message-ID: <20160520213930.GA24914@thinpad.lan.raisama.net> (raw)
In-Reply-To: <573471D6.8050102@redhat.com>

Introduce Skylake-Client CPU model, which inherits the features
from Broadwell and supports some additional features that are:
MPX, XSAVEC, and XGETBV1.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Remove XSAVES, edited commit message
---
 target-i386/cpu.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 895a386..9c5aabc 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1239,6 +1239,51 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .model_id = "Intel Core Processor (Broadwell)",
     },
     {
+        .name = "Skylake-Client",
+        .level = 0xd,
+        .vendor = CPUID_VENDOR_INTEL,
+        .family = 6,
+        .model = 94,
+        .stepping = 3,
+        .features[FEAT_1_EDX] =
+            CPUID_VME | CPUID_SSE2 | CPUID_SSE | CPUID_FXSR | CPUID_MMX |
+            CPUID_CLFLUSH | CPUID_PSE36 | CPUID_PAT | CPUID_CMOV | CPUID_MCA |
+            CPUID_PGE | CPUID_MTRR | CPUID_SEP | CPUID_APIC | CPUID_CX8 |
+            CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE |
+            CPUID_DE | CPUID_FP87,
+        .features[FEAT_1_ECX] =
+            CPUID_EXT_AVX | CPUID_EXT_XSAVE | CPUID_EXT_AES |
+            CPUID_EXT_POPCNT | CPUID_EXT_X2APIC | CPUID_EXT_SSE42 |
+            CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 |
+            CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 |
+            CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_FMA | CPUID_EXT_MOVBE |
+            CPUID_EXT_PCID | CPUID_EXT_F16C | CPUID_EXT_RDRAND,
+        .features[FEAT_8000_0001_EDX] =
+            CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX |
+            CPUID_EXT2_SYSCALL,
+        .features[FEAT_8000_0001_ECX] =
+            CPUID_EXT3_ABM | CPUID_EXT3_LAHF_LM | CPUID_EXT3_3DNOWPREFETCH,
+        .features[FEAT_7_0_EBX] =
+            CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 |
+            CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP |
+            CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_INVPCID |
+            CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_ADX |
+            CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_MPX,
+        /* Missing: XSAVES (not supported by some Linux versions,
+         * including v4.1 to v4.6).
+         * KVM doesn't yet expose any XSAVES state save component,
+         * and the only one defined in Skylake (processor tracing)
+         * probably will block migration anyway.
+         */
+        .features[FEAT_XSAVE] =
+            CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XSAVEC |
+            CPUID_XSAVE_XGETBV1,
+        .features[FEAT_6_EAX] =
+            CPUID_6_EAX_ARAT,
+        .xlevel = 0x80000008,
+        .model_id = "Intel Core Processor (Skylake)",
+    },
+    {
         .name = "Opteron_G1",
         .level = 5,
         .vendor = CPUID_VENDOR_AMD,
-- 
2.5.5

  reply	other threads:[~2016-05-20 21:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  8:13 [PATCH] target-i386: add Skylake-Client cpu mode Xiao Guangrong
2016-04-27  8:13 ` [Qemu-devel] " Xiao Guangrong
2016-04-27 11:56 ` Eduardo Habkost
2016-04-27 11:56   ` [Qemu-devel] " Eduardo Habkost
2016-04-28 17:34 ` Eduardo Habkost
2016-05-03  6:38   ` Xiao Guangrong
2016-05-03 16:11     ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Client cpu mode) Eduardo Habkost
2016-05-03 16:11       ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Eduardo Habkost
2016-05-03 17:44       ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Xiao Guangrong
2016-05-03 17:44         ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Xiao Guangrong
2016-05-03 17:53         ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Dave Hansen
2016-05-03 17:53           ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Dave Hansen
2016-05-03 18:23           ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Eduardo Habkost
2016-05-03 18:23             ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Eduardo Habkost
2016-05-03 18:29             ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Dave Hansen
2016-05-03 18:29               ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Dave Hansen
2016-05-09 13:44           ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Paolo Bonzini
2016-05-09 13:44             ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Paolo Bonzini
2016-05-12 12:03             ` Eduardo Habkost
2016-05-12 12:03               ` [Qemu-devel] " Eduardo Habkost
2016-05-12 12:06               ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Paolo Bonzini
2016-05-12 12:06                 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Paolo Bonzini
2016-05-20 21:39                 ` Eduardo Habkost [this message]
2016-05-20 21:39                   ` [Qemu-devel] [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model Eduardo Habkost
2016-05-23 13:46                   ` Paolo Bonzini
2016-05-23 13:46                     ` [Qemu-devel] " Paolo Bonzini
2016-06-03  3:50                     ` Xiao Guangrong
2016-06-03  3:50                       ` [Qemu-devel] " Xiao Guangrong
2016-06-03 17:27                       ` Eduardo Habkost
2016-06-03 17:27                         ` [Qemu-devel] " Eduardo Habkost
2016-04-29  3:11 ` [PATCH] target-i386: add Skylake-Client cpu mode Huang, Kai
2016-04-29  3:11   ` [Qemu-devel] " Huang, Kai
2016-04-29  3:28   ` Xiao Guangrong
2016-04-29  3:28     ` [Qemu-devel] " Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160520213930.GA24914@thinpad.lan.raisama.net \
    --to=ehabkost@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=gleb@kernel.org \
    --cc=guangrong.xiao@intel.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paul.c.lai@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=robert.a.kasten@intel.com \
    --cc=rth@twiddle.net \
    --cc=ruwang@redhat.com \
    --cc=yong.y.wang@intel.com \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.