From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
imammedo@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net,
"Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
"virt-intel-list@redhat.com" <virt-intel-list@redhat.com>,
"Kasten, Robert A" <robert.a.kasten@intel.com>,
"Lai, Paul C" <paul.c.lai@intel.com>,
"Xiao, Guangrong" <guangrong.xiao@intel.com>,
"ruwang@redhat.com" <ruwang@redhat.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>
Subject: Re: XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Client cpu mode)
Date: Thu, 12 May 2016 14:06:46 +0200 [thread overview]
Message-ID: <573471D6.8050102@redhat.com> (raw)
In-Reply-To: <20160512120331.GM4457@thinpad.lan.raisama.net>
On 12/05/2016 14:03, Eduardo Habkost wrote:
> > Item number 2 on the other hand means that it's okay to add Skylake CPU
> > models without XSAVES. Because of the large number of kernels in the
> > wild that block XSAVES, I'm inclined to do that.
>
> Agreed. Now, should we name the CPU model without XSAVES
> "Skylake" or "Skylake-noXSAVES"? I'm inclined towards the latter,
> to follow the same pattern we used for "Haswell-noTSX".
Do we have a plan to add Skylake with XSAVES? I think no, so it should
be fine to do
.name = "Skylake",
.features[FEATURE_XSAVE] = CPUID_XSAVE_XSAVEOPT |
CPUID_XSAVE_XGETBV1 | CPUID_XSAVE_XSAVEC
/* omitting CPUID_XSAVE_XSAVES because... */
Haswell-noTSX was added only because we already had a model with TSX.
If we hadn't we probably would have had:
- Haswell without TSX
- Broadwell without TSX
- Broadwell-EX with TSX (or something like that).
Thanks,
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
imammedo@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net,
"Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
"virt-intel-list@redhat.com" <virt-intel-list@redhat.com>,
"Kasten, Robert A" <robert.a.kasten@intel.com>,
"Lai, Paul C" <paul.c.lai@intel.com>,
"Xiao, Guangrong" <guangrong.xiao@intel.com>,
"ruwang@redhat.com" <ruwang@redhat.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>
Subject: Re: [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was Re: [PATCH] target-i386: add Skylake-Client cpu mode)
Date: Thu, 12 May 2016 14:06:46 +0200 [thread overview]
Message-ID: <573471D6.8050102@redhat.com> (raw)
In-Reply-To: <20160512120331.GM4457@thinpad.lan.raisama.net>
On 12/05/2016 14:03, Eduardo Habkost wrote:
> > Item number 2 on the other hand means that it's okay to add Skylake CPU
> > models without XSAVES. Because of the large number of kernels in the
> > wild that block XSAVES, I'm inclined to do that.
>
> Agreed. Now, should we name the CPU model without XSAVES
> "Skylake" or "Skylake-noXSAVES"? I'm inclined towards the latter,
> to follow the same pattern we used for "Haswell-noTSX".
Do we have a plan to add Skylake with XSAVES? I think no, so it should
be fine to do
.name = "Skylake",
.features[FEATURE_XSAVE] = CPUID_XSAVE_XSAVEOPT |
CPUID_XSAVE_XGETBV1 | CPUID_XSAVE_XSAVEC
/* omitting CPUID_XSAVE_XSAVES because... */
Haswell-noTSX was added only because we already had a model with TSX.
If we hadn't we probably would have had:
- Haswell without TSX
- Broadwell without TSX
- Broadwell-EX with TSX (or something like that).
Thanks,
Paolo
next prev parent reply other threads:[~2016-05-12 12:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 8:13 [PATCH] target-i386: add Skylake-Client cpu mode Xiao Guangrong
2016-04-27 8:13 ` [Qemu-devel] " Xiao Guangrong
2016-04-27 11:56 ` Eduardo Habkost
2016-04-27 11:56 ` [Qemu-devel] " Eduardo Habkost
2016-04-28 17:34 ` Eduardo Habkost
2016-05-03 6:38 ` Xiao Guangrong
2016-05-03 16:11 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Client cpu mode) Eduardo Habkost
2016-05-03 16:11 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Eduardo Habkost
2016-05-03 17:44 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Xiao Guangrong
2016-05-03 17:44 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Xiao Guangrong
2016-05-03 17:53 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Dave Hansen
2016-05-03 17:53 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Dave Hansen
2016-05-03 18:23 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Eduardo Habkost
2016-05-03 18:23 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Eduardo Habkost
2016-05-03 18:29 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Dave Hansen
2016-05-03 18:29 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Dave Hansen
2016-05-09 13:44 ` XSAVES in GET_SUPPORTED_CPUID (was Re: [Qemu-devel] " Paolo Bonzini
2016-05-09 13:44 ` [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was " Paolo Bonzini
2016-05-12 12:03 ` Eduardo Habkost
2016-05-12 12:03 ` [Qemu-devel] " Eduardo Habkost
2016-05-12 12:06 ` Paolo Bonzini [this message]
2016-05-12 12:06 ` Paolo Bonzini
2016-05-20 21:39 ` [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model Eduardo Habkost
2016-05-20 21:39 ` [Qemu-devel] " Eduardo Habkost
2016-05-23 13:46 ` Paolo Bonzini
2016-05-23 13:46 ` [Qemu-devel] " Paolo Bonzini
2016-06-03 3:50 ` Xiao Guangrong
2016-06-03 3:50 ` [Qemu-devel] " Xiao Guangrong
2016-06-03 17:27 ` Eduardo Habkost
2016-06-03 17:27 ` [Qemu-devel] " Eduardo Habkost
2016-04-29 3:11 ` [PATCH] target-i386: add Skylake-Client cpu mode Huang, Kai
2016-04-29 3:11 ` [Qemu-devel] " Huang, Kai
2016-04-29 3:28 ` Xiao Guangrong
2016-04-29 3:28 ` [Qemu-devel] " Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573471D6.8050102@redhat.com \
--to=pbonzini@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=ehabkost@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@intel.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul.c.lai@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=ravi.v.shankar@intel.com \
--cc=robert.a.kasten@intel.com \
--cc=rth@twiddle.net \
--cc=ruwang@redhat.com \
--cc=stefanha@redhat.com \
--cc=virt-intel-list@redhat.com \
--cc=yong.y.wang@intel.com \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.