From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fuse: Document that dentry is unused in getxattr
Date: Thu, 26 May 2016 15:15:13 +0200 [thread overview]
Message-ID: <20160526131513.GC734@redhat.com> (raw)
In-Reply-To: <1464175827-5546-1-git-send-email-agruenba@redhat.com>
On Wed, May 25, 2016 at 01:30:27PM +0200, Andreas Gruenbacher wrote:
> For consistency with the other filesystems, rename the dentry argument
> to "unused" here.
>
Make sense, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> fs/fuse/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index b941905..5760e27 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1755,7 +1755,7 @@ static int fuse_setxattr(struct dentry *entry, const char *name,
> return err;
> }
>
> -static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode,
> +static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode,
> const char *name, void *value, size_t size)
> {
> struct fuse_conn *fc = get_fuse_conn(inode);
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
prev parent reply other threads:[~2016-05-26 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 11:30 [PATCH] fuse: Document that dentry is unused in getxattr Andreas Gruenbacher
2016-05-26 13:15 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526131513.GC734@redhat.com \
--to=cmaiolino@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.