* [PATCH] fuse: Document that dentry is unused in getxattr
@ 2016-05-25 11:30 Andreas Gruenbacher
2016-05-26 13:15 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Gruenbacher @ 2016-05-25 11:30 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-fsdevel, Andreas Gruenbacher
For consistency with the other filesystems, rename the dentry argument
to "unused" here.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/fuse/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index b941905..5760e27 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1755,7 +1755,7 @@ static int fuse_setxattr(struct dentry *entry, const char *name,
return err;
}
-static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode,
+static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode,
const char *name, void *value, size_t size)
{
struct fuse_conn *fc = get_fuse_conn(inode);
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fuse: Document that dentry is unused in getxattr
2016-05-25 11:30 [PATCH] fuse: Document that dentry is unused in getxattr Andreas Gruenbacher
@ 2016-05-26 13:15 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2016-05-26 13:15 UTC (permalink / raw)
To: linux-fsdevel
On Wed, May 25, 2016 at 01:30:27PM +0200, Andreas Gruenbacher wrote:
> For consistency with the other filesystems, rename the dentry argument
> to "unused" here.
>
Make sense, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> fs/fuse/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index b941905..5760e27 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1755,7 +1755,7 @@ static int fuse_setxattr(struct dentry *entry, const char *name,
> return err;
> }
>
> -static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode,
> +static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode,
> const char *name, void *value, size_t size)
> {
> struct fuse_conn *fc = get_fuse_conn(inode);
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-26 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-25 11:30 [PATCH] fuse: Document that dentry is unused in getxattr Andreas Gruenbacher
2016-05-26 13:15 ` Carlos Maiolino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.