All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Cole Robinson <crobinso@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM
Date: Thu, 26 May 2016 16:14:10 +0100	[thread overview]
Message-ID: <20160526151410.GH1683@redhat.com> (raw)
In-Reply-To: <CAFEAcA-G4rL8o-6gmQvXHMVUrvH9utZOQuFhDO=J9imtzophjA@mail.gmail.com>

On Thu, May 26, 2016 at 03:53:54PM +0100, Peter Maydell wrote:
> On 26 May 2016 at 15:46, Richard W.M. Jones <rjones@redhat.com> wrote:
> > The problem with this is if I'm using TCG fallback mode, how
> > can I specify the right gic-version?  ie:
> >
> >   -M virt,gic-version=host,accel=kvm:tcg
> >
> > Only qemu knows if KVM is going to be enabled.
> >
> > The same problem happens with '-cpu host' BTW.  I really want a "make
> > it work" option, as I've said on several previous occasions on this
> > list eg:
> > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04173.html
> 
> I agree that we really need to do better here (thinking about
> the problem is on my todo list but generally other more pressing
> issues intervene). I'd welcome suggestions for semantics which
> (a) do what you want (b) are reasonably in line with what we do
> on other host architectures (c) don't break existing command lines.
> (I think those are the main requirements.)
> 
> In the meantime I think this patch is correct for what we
> are currently trying to implement.

Agreed this patch is an improvement on segfaulting which is
what qemu does at the moment :-(

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v

WARNING: multiple messages have this Message-ID (diff)
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cole Robinson <crobinso@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM
Date: Thu, 26 May 2016 16:14:10 +0100	[thread overview]
Message-ID: <20160526151410.GH1683@redhat.com> (raw)
In-Reply-To: <CAFEAcA-G4rL8o-6gmQvXHMVUrvH9utZOQuFhDO=J9imtzophjA@mail.gmail.com>

On Thu, May 26, 2016 at 03:53:54PM +0100, Peter Maydell wrote:
> On 26 May 2016 at 15:46, Richard W.M. Jones <rjones@redhat.com> wrote:
> > The problem with this is if I'm using TCG fallback mode, how
> > can I specify the right gic-version?  ie:
> >
> >   -M virt,gic-version=host,accel=kvm:tcg
> >
> > Only qemu knows if KVM is going to be enabled.
> >
> > The same problem happens with '-cpu host' BTW.  I really want a "make
> > it work" option, as I've said on several previous occasions on this
> > list eg:
> > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04173.html
> 
> I agree that we really need to do better here (thinking about
> the problem is on my todo list but generally other more pressing
> issues intervene). I'd welcome suggestions for semantics which
> (a) do what you want (b) are reasonably in line with what we do
> on other host architectures (c) don't break existing command lines.
> (I think those are the main requirements.)
> 
> In the meantime I think this patch is correct for what we
> are currently trying to implement.

Agreed this patch is an improvement on segfaulting which is
what qemu does at the moment :-(

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v

  reply	other threads:[~2016-05-26 15:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 14:31 [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM Cole Robinson
2016-05-26 14:46 ` Richard W.M. Jones
2016-05-26 14:46   ` Richard W.M. Jones
2016-05-26 14:53   ` [Qemu-arm] " Peter Maydell
2016-05-26 14:53     ` Peter Maydell
2016-05-26 15:14     ` Richard W.M. Jones [this message]
2016-05-26 15:14       ` Richard W.M. Jones
2016-06-17 14:49     ` [Qemu-arm] " Peter Maydell
2016-06-17 14:49       ` Peter Maydell
2016-06-17 16:10       ` [Qemu-arm] " Richard W.M. Jones
2016-06-17 16:10         ` Richard W.M. Jones
2016-06-17 16:31         ` Peter Maydell
2016-06-17 16:31           ` Peter Maydell
2016-06-17 16:33           ` [Qemu-arm] " Richard W.M. Jones
2016-06-17 16:33             ` Richard W.M. Jones
2016-06-03 18:34 ` [Qemu-arm] " Peter Maydell
2016-06-03 18:34   ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526151410.GH1683@redhat.com \
    --to=rjones@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.