* [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-25 3:45 ` Baruch Siach
0 siblings, 0 replies; 10+ messages in thread
From: Baruch Siach @ 2016-05-25 3:45 UTC (permalink / raw)
To: David Woodhouse, Brian Norris
Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Baruch Siach,
Rafał Miłecki
Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
match.
Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
---
Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
index 68342eac2383..3733300de8dd 100644
--- a/Documentation/devicetree/bindings/mtd/nand.txt
+++ b/Documentation/devicetree/bindings/mtd/nand.txt
@@ -53,7 +53,8 @@ Example:
nand@0 {
reg = <0>;
- nand-ecc-mode = "soft_bch";
+ nand-ecc-mode = "soft";
+ nand-ecc-algo = "bch";
/* controller specific properties */
};
--
2.8.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-25 7:26 ` Rafał Miłecki
0 siblings, 0 replies; 10+ messages in thread
From: Rafał Miłecki @ 2016-05-25 7:26 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org
On 25 May 2016 at 05:45, Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Rafał Miłecki <zajec5@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-25 7:26 ` Rafał Miłecki
0 siblings, 0 replies; 10+ messages in thread
From: Rafał Miłecki @ 2016-05-25 7:26 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On 25 May 2016 at 05:45, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Acked-by: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-25 19:02 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2016-05-25 19:02 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris, linux-mtd, devicetree,
Rafał Miłecki
On Wed, May 25, 2016 at 06:45:10AM +0300, Baruch Siach wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-25 19:02 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2016-05-25 19:02 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rafał Miłecki
On Wed, May 25, 2016 at 06:45:10AM +0300, Baruch Siach wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-27 13:31 ` Boris Brezillon
0 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2016-05-27 13:31 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris, devicetree,
Rafał Miłecki, linux-mtd
Brian,
On Wed, 25 May 2016 06:45:10 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
I don't know if we should consider this as a bugfix. If that's the
case, can you take it directly in your tree with my
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks,
Boris
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
> index 68342eac2383..3733300de8dd 100644
> --- a/Documentation/devicetree/bindings/mtd/nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/nand.txt
> @@ -53,7 +53,8 @@ Example:
>
> nand@0 {
> reg = <0>;
> - nand-ecc-mode = "soft_bch";
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-27 13:31 ` Boris Brezillon
0 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2016-05-27 13:31 UTC (permalink / raw)
To: Baruch Siach
Cc: David Woodhouse, Brian Norris, devicetree-u79uwXL29TY76Z2rM5mHXA,
Rafał Miłecki,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Brian,
On Wed, 25 May 2016 06:45:10 +0300
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
I don't know if we should consider this as a bugfix. If that's the
case, can you take it directly in your tree with my
Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Boris
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
> index 68342eac2383..3733300de8dd 100644
> --- a/Documentation/devicetree/bindings/mtd/nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/nand.txt
> @@ -53,7 +53,8 @@ Example:
>
> nand@0 {
> reg = <0>;
> - nand-ecc-mode = "soft_bch";
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
2016-05-27 13:31 ` Boris Brezillon
@ 2016-05-27 16:58 ` Brian Norris
-1 siblings, 0 replies; 10+ messages in thread
From: Brian Norris @ 2016-05-27 16:58 UTC (permalink / raw)
To: Boris Brezillon
Cc: Baruch Siach, David Woodhouse, devicetree,
Rafał Miłecki, linux-mtd
On Fri, May 27, 2016 at 03:31:53PM +0200, Boris Brezillon wrote:
> On Wed, 25 May 2016 06:45:10 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
>
> > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> > match.
> >
> > Cc: Rafał Miłecki <zajec5@gmail.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> I don't know if we should consider this as a bugfix. If that's the
> case, can you take it directly in your tree with my
Well, I don't know if it's a "bugfix" per se, but it's obviously correct
and has approx 0 risk.
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Wow, thanks! Three acks! Y'all must really love documentation :)
Pushed to linux-mtd.git.
Brian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
@ 2016-05-27 16:58 ` Brian Norris
0 siblings, 0 replies; 10+ messages in thread
From: Brian Norris @ 2016-05-27 16:58 UTC (permalink / raw)
To: Boris Brezillon
Cc: Baruch Siach, David Woodhouse, devicetree-u79uwXL29TY76Z2rM5mHXA,
Rafał Miłecki,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Fri, May 27, 2016 at 03:31:53PM +0200, Boris Brezillon wrote:
> On Wed, 25 May 2016 06:45:10 +0300
> Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
>
> > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> > match.
> >
> > Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
>
> I don't know if we should consider this as a bugfix. If that's the
> case, can you take it directly in your tree with my
Well, I don't know if it's a "bugfix" per se, but it's obviously correct
and has approx 0 risk.
> Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Wow, thanks! Three acks! Y'all must really love documentation :)
Pushed to linux-mtd.git.
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread