All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	"Radek Dostál" <rd@radekdostal.com>,
	dri-devel@lists.freedesktop.org,
	"Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Julia Lemire" <jlemire@matrox.com>,
	"Dave Airlie" <airlied@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match
Date: Thu, 2 Jun 2016 14:30:40 +0300	[thread overview]
Message-ID: <20160602113040.GK4329@intel.com> (raw)
In-Reply-To: <20160602105217.GL10319@nuc-i3427.alporthouse.com>

On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote:
> On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dostál wrote:
> > On 06/01/2016 11:50 AM, Chris Wilson wrote:
> > >Fixes regression from
> > >
> > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2
> > >Author: Chris Wilson<chris@chris-wilson.co.uk>
> > >Date:   Wed Aug 6 10:08:32 2014 +0200
> > >
> > >     drm: Perform cmdline mode parsing during connector initialisation
> > >
> > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA).
> > 
> > please remove this from the commit message. The original bug is no
> > longer reproducible with 4.7-rc1
> 
> If there's no motivation for the patch anymore, it can just wither away
> in one of my old trees.
> 
> Does anyone care about pruning the autogenerated video= mode if a probed
> one matches? Presumably, it is still visible to userspace and switching
> to it will cause the same issue as before? Or was it always a driver
> bug (failing to set the mode)?

IMO the patch makes total sense even if it's not needed for this
particular bug. Feel free to add

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	"Radek Dostál" <rd@radekdostal.com>,
	dri-devel@lists.freedesktop.org,
	"Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Julia Lemire" <jlemire@matrox.com>,
	"Dave Airlie" <airlied@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match
Date: Thu, 2 Jun 2016 14:30:40 +0300	[thread overview]
Message-ID: <20160602113040.GK4329@intel.com> (raw)
In-Reply-To: <20160602105217.GL10319@nuc-i3427.alporthouse.com>

On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote:
> On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dost�l wrote:
> > On 06/01/2016 11:50 AM, Chris Wilson wrote:
> > >Fixes regression from
> > >
> > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2
> > >Author: Chris Wilson<chris@chris-wilson.co.uk>
> > >Date:   Wed Aug 6 10:08:32 2014 +0200
> > >
> > >     drm: Perform cmdline mode parsing during connector initialisation
> > >
> > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA).
> > 
> > please remove this from the commit message. The original bug is no
> > longer reproducible with 4.7-rc1
> 
> If there's no motivation for the patch anymore, it can just wither away
> in one of my old trees.
> 
> Does anyone care about pruning the autogenerated video= mode if a probed
> one matches? Presumably, it is still visible to userspace and switching
> to it will cause the same issue as before? Or was it always a driver
> bug (failing to set the mode)?

IMO the patch makes total sense even if it's not needed for this
particular bug. Feel free to add

Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>

-- 
Ville Syrj�l�
Intel OTC

  reply	other threads:[~2016-06-02 11:30 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19 21:05 [PATCH] drm: fb_helper: prefer to use mode, which is not DRM_MODE_TYPE_USERDEF Radek Dostal
2015-04-20  5:26 ` [PATCHv2] " Radek Dostal
2015-04-20  9:09   ` Chris Wilson
2015-04-20  9:09     ` Chris Wilson
2015-04-20  9:36     ` Radek Dostál
2015-04-20  9:46       ` Chris Wilson
2015-04-20  9:58         ` Chris Wilson
2015-04-20  9:58           ` Chris Wilson
2015-04-20 10:38           ` Radek Dostál
2015-04-20 10:48             ` Chris Wilson
2015-04-20 10:48               ` Chris Wilson
2015-04-20 10:57               ` Radek Dostál
2015-04-20 11:00                 ` Chris Wilson
2015-04-20 11:20                   ` Radek Dostál
2015-04-20 11:44                     ` Chris Wilson
2015-04-20 12:00                       ` Radek Dostál
2015-04-20 12:26   ` [PATCH] drm: Only create a cmdline mode if no probed modes match Chris Wilson
2015-04-20 13:06     ` Radek Dostál
2015-04-20 13:16       ` Chris Wilson
2015-04-20 13:28       ` [PATCH v2] " Chris Wilson
2015-04-20 13:41         ` Radek Dostál
2015-05-21 15:36           ` Chris Wilson
2015-05-21 15:36             ` Chris Wilson
2015-05-22  6:22         ` Jani Nikula
2015-05-22  6:22           ` Jani Nikula
2015-05-22  9:03         ` Ville Syrjälä
2015-05-22  9:03           ` Ville Syrjälä
2015-05-22  9:54           ` Chris Wilson
2015-05-22  9:54             ` Chris Wilson
2015-05-22 11:30             ` Ville Syrjälä
2015-05-22 11:30               ` Ville Syrjälä
2016-06-01  9:34     ` [PATCH v3] " Chris Wilson
2016-06-01  9:34       ` Chris Wilson
2016-06-01  9:43       ` Ville Syrjälä
2016-06-01  9:43         ` Ville Syrjälä
2016-06-01  9:46         ` Chris Wilson
2016-06-01  9:46           ` Chris Wilson
2016-06-01  9:47         ` Chris Wilson
2016-06-01  9:47           ` Chris Wilson
2016-06-01  9:56           ` Ville Syrjälä
2016-06-01  9:56             ` Ville Syrjälä
2016-06-01  9:50         ` [PATCH v4] " Chris Wilson
2016-06-01  9:50           ` Chris Wilson
2016-06-01 13:19           ` Alex Deucher
2016-06-01 13:19             ` Alex Deucher
2016-06-02  9:38           ` Radek Dostál
2016-06-02 10:52             ` Chris Wilson
2016-06-02 10:52               ` Chris Wilson
2016-06-02 11:30               ` Ville Syrjälä [this message]
2016-06-02 11:30                 ` Ville Syrjälä
2016-06-02 11:35                 ` Radek Dostál
2016-06-02 11:35                   ` Radek Dostál
2016-06-02 13:12                 ` Daniel Vetter
2016-06-02 13:12                   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602113040.GK4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jlemire@matrox.com \
    --cc=rd@radekdostal.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.