All of lore.kernel.org
 help / color / mirror / Atom feed
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: sun4i: fix LPAE warnings
Date: Fri, 3 Jun 2016 19:28:54 +0200	[thread overview]
Message-ID: <20160603172854.GE21013@ulmo.ba.sec> (raw)
In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com>

On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote:
> When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns
> into a 64-bit type, which causes warnings with some debug printks:
> =================
> In file included from
> drivers/gpu/drm/sun4i/sun4i_backend.c:13::
> drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer':
> drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning:
> format '%x' expects argument of type 'unsigned int', but argument 3 has
> type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
>   DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr);
>                    ^
> include/drm/drmP.h:207:34: note: in definition of macro
> 'DRM_DEBUG_DRIVER'
>     drm_ut_debug_printk(__func__, fmt, ##args); \
> .....
> 
> Use the proper printk format specifier [1] for dma_addr_t which takes
> care of those differences.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> [1] Documentation/printk-formats.txt
> ---
>  drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160603/11e11c45/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings
Date: Fri, 3 Jun 2016 19:28:54 +0200	[thread overview]
Message-ID: <20160603172854.GE21013@ulmo.ba.sec> (raw)
In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 1189 bytes --]

On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote:
> When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns
> into a 64-bit type, which causes warnings with some debug printks:
> =================
> In file included from
> drivers/gpu/drm/sun4i/sun4i_backend.c:13::
> drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer':
> drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning:
> format '%x' expects argument of type 'unsigned int', but argument 3 has
> type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
>   DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr);
>                    ^
> include/drm/drmP.h:207:34: note: in definition of macro
> 'DRM_DEBUG_DRIVER'
>     drm_ut_debug_printk(__func__, fmt, ##args); \
> .....
> 
> Use the proper printk format specifier [1] for dma_addr_t which takes
> care of those differences.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> [1] Documentation/printk-formats.txt
> ---
>  drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings
Date: Fri, 3 Jun 2016 19:28:54 +0200	[thread overview]
Message-ID: <20160603172854.GE21013@ulmo.ba.sec> (raw)
In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote:
> When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns
> into a 64-bit type, which causes warnings with some debug printks:
> =================
> In file included from
> drivers/gpu/drm/sun4i/sun4i_backend.c:13::
> drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer':
> drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning:
> format '%x' expects argument of type 'unsigned int', but argument 3 has
> type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
>   DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr);
>                    ^
> include/drm/drmP.h:207:34: note: in definition of macro
> 'DRM_DEBUG_DRIVER'
>     drm_ut_debug_printk(__func__, fmt, ##args); \
> .....
> 
> Use the proper printk format specifier [1] for dma_addr_t which takes
> care of those differences.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> [1] Documentation/printk-formats.txt
> ---
>  drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-03 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 16:57 [PATCH] drm: sun4i: fix LPAE warnings Andre Przywara
2016-06-03 16:57 ` Andre Przywara
2016-06-03 16:57 ` Andre Przywara
2016-06-03 17:28 ` Thierry Reding [this message]
2016-06-03 17:28   ` Thierry Reding
2016-06-03 17:28   ` Thierry Reding
2016-06-06 13:06 ` Arnd Bergmann
2016-06-06 13:06   ` Arnd Bergmann
2016-06-06 13:06   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603172854.GE21013@ulmo.ba.sec \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.