From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Sagi Grimberg <sagi-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org>
Cc: Sudip Mukherjee
<sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v2] IB/core: remove dead code
Date: Tue, 7 Jun 2016 05:42:59 -0700 [thread overview]
Message-ID: <20160607124259.GA3906@infradead.org> (raw)
In-Reply-To: <5756C0E0.7090303-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org>
On Tue, Jun 07, 2016 at 03:41:04PM +0300, Sagi Grimberg wrote:
> Actually it looks like the data-integrity insert/strip operation
> (where protection sg list does not exist) is broken.
>
> It looks that the protection scatterlist should be done only if
> prot_sg_count was provided...
>
> I don't have access to mlx5 devices at the moment (still waiting
> to get some...)
I've reported the brokenness in the existing iSER code when I started
working on signature MR support in the generic API. As no one helped
managed to figure out the issue or how it should operate I clone the
existing semantics, even given I knew they are broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagi@lightbits.io>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
leon@kernel.org
Subject: Re: [PATCH v2] IB/core: remove dead code
Date: Tue, 7 Jun 2016 05:42:59 -0700 [thread overview]
Message-ID: <20160607124259.GA3906@infradead.org> (raw)
In-Reply-To: <5756C0E0.7090303@lightbits.io>
On Tue, Jun 07, 2016 at 03:41:04PM +0300, Sagi Grimberg wrote:
> Actually it looks like the data-integrity insert/strip operation
> (where protection sg list does not exist) is broken.
>
> It looks that the protection scatterlist should be done only if
> prot_sg_count was provided...
>
> I don't have access to mlx5 devices at the moment (still waiting
> to get some...)
I've reported the brokenness in the existing iSER code when I started
working on signature MR support in the generic API. As no one helped
managed to figure out the issue or how it should operate I clone the
existing semantics, even given I knew they are broken.
next prev parent reply other threads:[~2016-06-07 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:15 [PATCH v2] IB/core: remove dead code Sudip Mukherjee
[not found] ` <1465247706-4418-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-07 7:33 ` Leon Romanovsky
2016-06-07 7:33 ` Leon Romanovsky
2016-06-07 12:41 ` Sagi Grimberg
2016-06-07 12:41 ` Sagi Grimberg
[not found] ` <5756C0E0.7090303-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org>
2016-06-07 12:42 ` Christoph Hellwig [this message]
2016-06-07 12:42 ` Christoph Hellwig
2016-06-07 13:14 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607124259.GA3906@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.