From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
Date: Tue, 7 Jun 2016 19:42:21 +0300 [thread overview]
Message-ID: <20160607164221.GI2425@tarshish> (raw)
In-Reply-To: <1465308710-18297-1-git-send-email-ben.dooks@codethink.co.uk>
Hi Ben,
On Tue, Jun 07, 2016 at 03:11:50PM +0100, Ben Dooks wrote:
> Change the dc_timer function to be static as it is not used outside
> this driver. This fixes the following warning:
>
> drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> drivers/clocksource/timer-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
> index a536eeb..96bb222 100644
> --- a/drivers/clocksource/timer-digicolor.c
> +++ b/drivers/clocksource/timer-digicolor.c
> @@ -63,7 +63,7 @@ struct digicolor_timer {
> int timer_id; /* one of TIMER_* */
> };
>
> -struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> +static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> {
> return container_of(ce, struct digicolor_timer, ce);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
Date: Tue, 7 Jun 2016 19:42:21 +0300 [thread overview]
Message-ID: <20160607164221.GI2425@tarshish> (raw)
In-Reply-To: <1465308710-18297-1-git-send-email-ben.dooks@codethink.co.uk>
Hi Ben,
On Tue, Jun 07, 2016 at 03:11:50PM +0100, Ben Dooks wrote:
> Change the dc_timer function to be static as it is not used outside
> this driver. This fixes the following warning:
>
> drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/clocksource/timer-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
> index a536eeb..96bb222 100644
> --- a/drivers/clocksource/timer-digicolor.c
> +++ b/drivers/clocksource/timer-digicolor.c
> @@ -63,7 +63,7 @@ struct digicolor_timer {
> int timer_id; /* one of TIMER_* */
> };
>
> -struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> +static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> {
> return container_of(ce, struct digicolor_timer, ce);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-06-07 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 14:11 [PATCH] clocksource/drivers/digicolor: fix warning of non-static function Ben Dooks
2016-06-07 14:11 ` Ben Dooks
2016-06-07 16:42 ` Baruch Siach [this message]
2016-06-07 16:42 ` Baruch Siach
2016-06-16 14:40 ` Daniel Lezcano
2016-06-16 14:40 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607164221.GI2425@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.