* [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
@ 2016-06-07 14:11 ` Ben Dooks
0 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2016-06-07 14:11 UTC (permalink / raw)
To: linux-arm-kernel
Change the dc_timer function to be static as it is not used outside
this driver. This fixes the following warning:
drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
drivers/clocksource/timer-digicolor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
index a536eeb..96bb222 100644
--- a/drivers/clocksource/timer-digicolor.c
+++ b/drivers/clocksource/timer-digicolor.c
@@ -63,7 +63,7 @@ struct digicolor_timer {
int timer_id; /* one of TIMER_* */
};
-struct digicolor_timer *dc_timer(struct clock_event_device *ce)
+static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
{
return container_of(ce, struct digicolor_timer, ce);
}
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
@ 2016-06-07 14:11 ` Ben Dooks
0 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2016-06-07 14:11 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Daniel Lezcano, Thomas Gleixner, Baruch Siach,
linux-arm-kernel, linux-kernel
Change the dc_timer function to be static as it is not used outside
this driver. This fixes the following warning:
drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/clocksource/timer-digicolor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
index a536eeb..96bb222 100644
--- a/drivers/clocksource/timer-digicolor.c
+++ b/drivers/clocksource/timer-digicolor.c
@@ -63,7 +63,7 @@ struct digicolor_timer {
int timer_id; /* one of TIMER_* */
};
-struct digicolor_timer *dc_timer(struct clock_event_device *ce)
+static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
{
return container_of(ce, struct digicolor_timer, ce);
}
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
2016-06-07 14:11 ` Ben Dooks
@ 2016-06-07 16:42 ` Baruch Siach
-1 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2016-06-07 16:42 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ben,
On Tue, Jun 07, 2016 at 03:11:50PM +0100, Ben Dooks wrote:
> Change the dc_timer function to be static as it is not used outside
> this driver. This fixes the following warning:
>
> drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> drivers/clocksource/timer-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
> index a536eeb..96bb222 100644
> --- a/drivers/clocksource/timer-digicolor.c
> +++ b/drivers/clocksource/timer-digicolor.c
> @@ -63,7 +63,7 @@ struct digicolor_timer {
> int timer_id; /* one of TIMER_* */
> };
>
> -struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> +static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> {
> return container_of(ce, struct digicolor_timer, ce);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
@ 2016-06-07 16:42 ` Baruch Siach
0 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2016-06-07 16:42 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
linux-kernel
Hi Ben,
On Tue, Jun 07, 2016 at 03:11:50PM +0100, Ben Dooks wrote:
> Change the dc_timer function to be static as it is not used outside
> this driver. This fixes the following warning:
>
> drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/clocksource/timer-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
> index a536eeb..96bb222 100644
> --- a/drivers/clocksource/timer-digicolor.c
> +++ b/drivers/clocksource/timer-digicolor.c
> @@ -63,7 +63,7 @@ struct digicolor_timer {
> int timer_id; /* one of TIMER_* */
> };
>
> -struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> +static struct digicolor_timer *dc_timer(struct clock_event_device *ce)
> {
> return container_of(ce, struct digicolor_timer, ce);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clocksource/drivers/digicolor: fix warning of non-static function
2016-06-07 14:11 ` Ben Dooks
@ 2016-06-16 14:40 ` Daniel Lezcano
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2016-06-16 14:40 UTC (permalink / raw)
To: linux-arm-kernel
On 06/07/2016 04:11 PM, Ben Dooks wrote:
> Change the dc_timer function to be static as it is not used outside
> this driver. This fixes the following warning:
>
> drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
Applied, thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-16 14:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 14:11 [PATCH] clocksource/drivers/digicolor: fix warning of non-static function Ben Dooks
2016-06-07 14:11 ` Ben Dooks
2016-06-07 16:42 ` Baruch Siach
2016-06-07 16:42 ` Baruch Siach
2016-06-16 14:40 ` Daniel Lezcano
2016-06-16 14:40 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.