From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagigrim@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
keith.busch@intel.com, axboe@kernel.dk,
linux-block@vger.kernel.org, ming.l@ssi.samsung.com,
linux-nvme@lists.infradead.org, sagi@lightbits.io
Subject: Re: [PATCH 11/11] nvme-fabrics: pass non-blocking flag to connect request allocation
Date: Wed, 8 Jun 2016 16:09:46 +0200 [thread overview]
Message-ID: <20160608140946.GA1020@lst.de> (raw)
In-Reply-To: <575823DD.8080000@gmail.com>
On Wed, Jun 08, 2016 at 04:55:41PM +0300, Sagi Grimberg wrote:
> Looks fine,
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>
> Would be nice to reduce the number of arguments
> passed to __nvme_submit_sync_cmd() at some point..
We're only adding them in our series.. But I agree that the number
of arguments is a bit of a mess, but I couldn't really come up with
something better.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 11/11] nvme-fabrics: pass non-blocking flag to connect request allocation
Date: Wed, 8 Jun 2016 16:09:46 +0200 [thread overview]
Message-ID: <20160608140946.GA1020@lst.de> (raw)
In-Reply-To: <575823DD.8080000@gmail.com>
On Wed, Jun 08, 2016@04:55:41PM +0300, Sagi Grimberg wrote:
> Looks fine,
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
>
> Would be nice to reduce the number of arguments
> passed to __nvme_submit_sync_cmd() at some point..
We're only adding them in our series.. But I agree that the number
of arguments is a bit of a mess, but I couldn't really come up with
something better.
next prev parent reply other threads:[~2016-06-08 14:09 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:30 NVMe over Fabrics: updates for req_op changes and misc fixes Christoph Hellwig
2016-06-08 12:30 ` Christoph Hellwig
2016-06-08 12:30 ` [PATCH 01/11] Revert "blk-mq: add blk_mq_alloc_request_hctx" Christoph Hellwig
2016-06-08 12:30 ` Christoph Hellwig
2016-06-08 13:58 ` Jeff Moyer
2016-06-08 13:58 ` Jeff Moyer
2016-06-08 14:10 ` Christoph Hellwig
2016-06-08 14:10 ` Christoph Hellwig
2016-06-08 14:13 ` Jeff Moyer
2016-06-08 14:13 ` Jeff Moyer
2016-06-08 12:30 ` [PATCH 02/11] blk-mq: add blk_mq_alloc_request_hctx Christoph Hellwig
2016-06-08 12:30 ` Christoph Hellwig
2016-06-08 13:43 ` Sagi Grimberg
2016-06-08 13:43 ` Sagi Grimberg
2016-06-08 12:30 ` [PATCH 03/11] nvme_rdma: update for req_op changes Christoph Hellwig
2016-06-08 12:30 ` Christoph Hellwig
2016-06-08 13:44 ` Sagi Grimberg
2016-06-08 13:44 ` Sagi Grimberg
2016-06-08 22:03 ` Ming Lin
2016-06-08 22:03 ` Ming Lin
2016-06-08 12:30 ` [PATCH 04/11] nvmet: " Christoph Hellwig
2016-06-08 12:30 ` Christoph Hellwig
2016-06-08 13:44 ` Sagi Grimberg
2016-06-08 13:44 ` Sagi Grimberg
2016-06-14 14:27 ` Christoph Hellwig
2016-06-14 14:27 ` Christoph Hellwig
2016-06-08 12:31 ` [PATCH 05/11] nvme-loop: set SGL flag on AER Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 12:31 ` [PATCH 06/11] nvme-rdma: " Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 12:31 ` [PATCH 07/11] nvmet: fix 64-bit division in nvmet_set_features Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 13:53 ` Sagi Grimberg
2016-06-08 13:53 ` Sagi Grimberg
2016-06-08 12:31 ` [PATCH 08/11] nvmet: fix eno.cocci warnings Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 22:09 ` Ming Lin
2016-06-08 22:09 ` Ming Lin
2016-06-08 12:31 ` [PATCH 09/11] nvmet-rdma: check for a valid adrfam Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 12:31 ` [PATCH 10/11] nvme: keep alive should use any queue Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 13:54 ` Sagi Grimberg
2016-06-08 13:54 ` Sagi Grimberg
2016-06-08 12:31 ` [PATCH 11/11] nvme-fabrics: pass non-blocking flag to connect request allocation Christoph Hellwig
2016-06-08 12:31 ` Christoph Hellwig
2016-06-08 13:55 ` Sagi Grimberg
2016-06-08 13:55 ` Sagi Grimberg
2016-06-08 14:09 ` Christoph Hellwig [this message]
2016-06-08 14:09 ` Christoph Hellwig
2016-06-08 22:21 ` NVMe over Fabrics: updates for req_op changes and misc fixes Ming Lin
2016-06-08 22:21 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608140946.GA1020@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.l@ssi.samsung.com \
--cc=sagi@lightbits.io \
--cc=sagigrim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.