All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support
@ 2016-05-17 20:16 ` Damien Riegel
  0 siblings, 0 replies; 9+ messages in thread
From: Damien Riegel @ 2016-05-17 20:16 UTC (permalink / raw)
  To: linux-arm-kernel

Enable FPGA's IRQ controller. It is in charge of dispatching interrupts
generated by IPs in the FPGA. The SoC is notified that an interrupt
occurred through a GPIO.

Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
---
 arch/arm/boot/dts/imx51-ts4800.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 0ff76a1..2c89988 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -149,6 +149,19 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0x1d000>;
 
+		fpga_irqc: fpga_irqc at 0,15000 {
+			compatible = "technologic,ts4800-irqc";
+			reg = <0x15000 0x1000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_interrupt_fpga>;
+
+			interrupt-parent = <&gpio2>;
+			interrupts= <9 IRQ_TYPE_LEVEL_HIGH>;
+
+			interrupt-controller;
+			#interrupt-cells = <1>;
+		};
+
 		syscon: syscon at b0010000 {
 			compatible = "syscon", "simple-mfd";
 			reg = <0x10000 0x3d>;
@@ -228,6 +241,12 @@
 		>;
 	};
 
+	pinctrl_interrupt_fpga: fpgaicgrp {
+		fsl,pins = <
+			MX51_PAD_EIM_D27__GPIO2_9		0xe5
+		>;
+	};
+
 	pinctrl_lcd: lcdgrp {
 		fsl,pins = <
 			MX51_PAD_DISP1_DAT0__DISP1_DAT0		0x5
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support
@ 2016-05-17 20:16 ` Damien Riegel
  0 siblings, 0 replies; 9+ messages in thread
From: Damien Riegel @ 2016-05-17 20:16 UTC (permalink / raw)
  To: devicetree, linux-kernel, linux-arm-kernel
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, kernel, Damien Riegel

Enable FPGA's IRQ controller. It is in charge of dispatching interrupts
generated by IPs in the FPGA. The SoC is notified that an interrupt
occurred through a GPIO.

Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
---
 arch/arm/boot/dts/imx51-ts4800.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 0ff76a1..2c89988 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -149,6 +149,19 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0x1d000>;
 
+		fpga_irqc: fpga_irqc@0,15000 {
+			compatible = "technologic,ts4800-irqc";
+			reg = <0x15000 0x1000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_interrupt_fpga>;
+
+			interrupt-parent = <&gpio2>;
+			interrupts= <9 IRQ_TYPE_LEVEL_HIGH>;
+
+			interrupt-controller;
+			#interrupt-cells = <1>;
+		};
+
 		syscon: syscon@b0010000 {
 			compatible = "syscon", "simple-mfd";
 			reg = <0x10000 0x3d>;
@@ -228,6 +241,12 @@
 		>;
 	};
 
+	pinctrl_interrupt_fpga: fpgaicgrp {
+		fsl,pins = <
+			MX51_PAD_EIM_D27__GPIO2_9		0xe5
+		>;
+	};
+
 	pinctrl_lcd: lcdgrp {
 		fsl,pins = <
 			MX51_PAD_DISP1_DAT0__DISP1_DAT0		0x5
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] ARM: dts: TS-4800: add CAN support
@ 2016-05-17 20:16   ` Damien Riegel
  0 siblings, 0 replies; 9+ messages in thread
From: Damien Riegel @ 2016-05-17 20:16 UTC (permalink / raw)
  To: linux-arm-kernel

This enables support for the CAN controller located in the FPGA.

Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
---
 arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 2c89988..41be82e 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -149,6 +149,16 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0x1d000>;
 
+		can at 0,1a000 {
+			compatible = "technologic,sja1000";
+			reg = <0x1a000 0x00000100>;
+			interrupt-parent = <&fpga_irqc>;
+			interrupts = <1>;
+			reg-io-width = <2>;
+			nxp,tx-output-config = <0x06>;
+			nxp,external-clock-frequency = <24000000>;
+		};
+
 		fpga_irqc: fpga_irqc at 0,15000 {
 			compatible = "technologic,ts4800-irqc";
 			reg = <0x15000 0x1000>;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] ARM: dts: TS-4800: add CAN support
@ 2016-05-17 20:16   ` Damien Riegel
  0 siblings, 0 replies; 9+ messages in thread
From: Damien Riegel @ 2016-05-17 20:16 UTC (permalink / raw)
  To: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King,
	kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/, Damien Riegel

This enables support for the CAN controller located in the FPGA.

Signed-off-by: Damien Riegel <damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
---
 arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 2c89988..41be82e 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -149,6 +149,16 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0x1d000>;
 
+		can@0,1a000 {
+			compatible = "technologic,sja1000";
+			reg = <0x1a000 0x00000100>;
+			interrupt-parent = <&fpga_irqc>;
+			interrupts = <1>;
+			reg-io-width = <2>;
+			nxp,tx-output-config = <0x06>;
+			nxp,external-clock-frequency = <24000000>;
+		};
+
 		fpga_irqc: fpga_irqc@0,15000 {
 			compatible = "technologic,ts4800-irqc";
 			reg = <0x15000 0x1000>;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] ARM: dts: TS-4800: add CAN support
@ 2016-05-17 20:16   ` Damien Riegel
  0 siblings, 0 replies; 9+ messages in thread
From: Damien Riegel @ 2016-05-17 20:16 UTC (permalink / raw)
  To: devicetree, linux-kernel, linux-arm-kernel
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, kernel, Damien Riegel

This enables support for the CAN controller located in the FPGA.

Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
---
 arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 2c89988..41be82e 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -149,6 +149,16 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0x1d000>;
 
+		can@0,1a000 {
+			compatible = "technologic,sja1000";
+			reg = <0x1a000 0x00000100>;
+			interrupt-parent = <&fpga_irqc>;
+			interrupts = <1>;
+			reg-io-width = <2>;
+			nxp,tx-output-config = <0x06>;
+			nxp,external-clock-frequency = <24000000>;
+		};
+
 		fpga_irqc: fpga_irqc@0,15000 {
 			compatible = "technologic,ts4800-irqc";
 			reg = <0x15000 0x1000>;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support
  2016-05-17 20:16 ` Damien Riegel
@ 2016-06-09 13:25   ` Shawn Guo
  -1 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2016-06-09 13:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, May 17, 2016 at 04:16:29PM -0400, Damien Riegel wrote:
> Enable FPGA's IRQ controller. It is in charge of dispatching interrupts
> generated by IPs in the FPGA. The SoC is notified that an interrupt
> occurred through a GPIO.
> 
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 0ff76a1..2c89988 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,19 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		fpga_irqc: fpga_irqc at 0,15000 {

Please use hyphen rather than underscore in node name.  Also
why do we need '0,' in unit-address?

> +			compatible = "technologic,ts4800-irqc";
> +			reg = <0x15000 0x1000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_interrupt_fpga>;
> +

Drop this newline.

> +			interrupt-parent = <&gpio2>;
> +			interrupts= <9 IRQ_TYPE_LEVEL_HIGH>;
> +

Ditto

Shawn

> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +
>  		syscon: syscon at b0010000 {
>  			compatible = "syscon", "simple-mfd";
>  			reg = <0x10000 0x3d>;
> @@ -228,6 +241,12 @@
>  		>;
>  	};
>  
> +	pinctrl_interrupt_fpga: fpgaicgrp {
> +		fsl,pins = <
> +			MX51_PAD_EIM_D27__GPIO2_9		0xe5
> +		>;
> +	};
> +
>  	pinctrl_lcd: lcdgrp {
>  		fsl,pins = <
>  			MX51_PAD_DISP1_DAT0__DISP1_DAT0		0x5
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support
@ 2016-06-09 13:25   ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2016-06-09 13:25 UTC (permalink / raw)
  To: Damien Riegel
  Cc: devicetree, linux-kernel, linux-arm-kernel, Mark Rutland,
	Pawel Moll, Ian Campbell, Russell King, Rob Herring, kernel,
	Sascha Hauer, Kumar Gala

On Tue, May 17, 2016 at 04:16:29PM -0400, Damien Riegel wrote:
> Enable FPGA's IRQ controller. It is in charge of dispatching interrupts
> generated by IPs in the FPGA. The SoC is notified that an interrupt
> occurred through a GPIO.
> 
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 0ff76a1..2c89988 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,19 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		fpga_irqc: fpga_irqc@0,15000 {

Please use hyphen rather than underscore in node name.  Also
why do we need '0,' in unit-address?

> +			compatible = "technologic,ts4800-irqc";
> +			reg = <0x15000 0x1000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_interrupt_fpga>;
> +

Drop this newline.

> +			interrupt-parent = <&gpio2>;
> +			interrupts= <9 IRQ_TYPE_LEVEL_HIGH>;
> +

Ditto

Shawn

> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +
>  		syscon: syscon@b0010000 {
>  			compatible = "syscon", "simple-mfd";
>  			reg = <0x10000 0x3d>;
> @@ -228,6 +241,12 @@
>  		>;
>  	};
>  
> +	pinctrl_interrupt_fpga: fpgaicgrp {
> +		fsl,pins = <
> +			MX51_PAD_EIM_D27__GPIO2_9		0xe5
> +		>;
> +	};
> +
>  	pinctrl_lcd: lcdgrp {
>  		fsl,pins = <
>  			MX51_PAD_DISP1_DAT0__DISP1_DAT0		0x5
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/2] ARM: dts: TS-4800: add CAN support
  2016-05-17 20:16   ` Damien Riegel
@ 2016-06-09 13:30     ` Shawn Guo
  -1 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2016-06-09 13:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
> 
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		can at 0,1a000 {
> +			compatible = "technologic,sja1000";
> +			reg = <0x1a000 0x00000100>;
> +			interrupt-parent = <&fpga_irqc>;
> +			interrupts = <1>;
> +			reg-io-width = <2>;
> +			nxp,tx-output-config = <0x06>;
> +			nxp,external-clock-frequency = <24000000>;
> +		};
> +

For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.

Shawn

>  		fpga_irqc: fpga_irqc at 0,15000 {
>  			compatible = "technologic,ts4800-irqc";
>  			reg = <0x15000 0x1000>;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] ARM: dts: TS-4800: add CAN support
@ 2016-06-09 13:30     ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2016-06-09 13:30 UTC (permalink / raw)
  To: Damien Riegel
  Cc: devicetree, linux-kernel, linux-arm-kernel, Mark Rutland,
	Pawel Moll, Ian Campbell, Russell King, Rob Herring, kernel,
	Sascha Hauer, Kumar Gala

On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
> 
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		can@0,1a000 {
> +			compatible = "technologic,sja1000";
> +			reg = <0x1a000 0x00000100>;
> +			interrupt-parent = <&fpga_irqc>;
> +			interrupts = <1>;
> +			reg-io-width = <2>;
> +			nxp,tx-output-config = <0x06>;
> +			nxp,external-clock-frequency = <24000000>;
> +		};
> +

For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.

Shawn

>  		fpga_irqc: fpga_irqc@0,15000 {
>  			compatible = "technologic,ts4800-irqc";
>  			reg = <0x15000 0x1000>;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-06-09 13:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 20:16 [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support Damien Riegel
2016-05-17 20:16 ` Damien Riegel
2016-05-17 20:16 ` [PATCH 2/2] ARM: dts: TS-4800: add CAN support Damien Riegel
2016-05-17 20:16   ` Damien Riegel
2016-05-17 20:16   ` Damien Riegel
2016-06-09 13:30   ` Shawn Guo
2016-06-09 13:30     ` Shawn Guo
2016-06-09 13:25 ` [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support Shawn Guo
2016-06-09 13:25   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.