From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Bruno Faccini <bruno.faccini@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date: Thu, 9 Jun 2016 18:28:33 -0700 [thread overview]
Message-ID: <20160610012833.GA6804@kroah.com> (raw)
In-Reply-To: <1465512347-11650-3-git-send-email-jsimmons@infradead.org>
On Thu, Jun 09, 2016 at 06:45:46PM -0400, James Simmons wrote:
> From: Bruno Faccini <bruno.faccini@intel.com>
>
> As part of LU-3848 and LU-4330, it has been discovered that LNET
> MEs and small MDs (<=128 Bytes) are allocated in <size-128> kmem_cache
> and thus can suffer quite frequent corruptions, from other modules or
> Kernel parts, that occur there. To avoid this, MEs and small-MDs
> specific kmem_cache have been created.
What? Who corrupts them? That shouldn't be possible, and on some
systems, even if you do ask for a separate slab, it will be merged
togther with others of the same size. So this patch doesn't do all that
much.
I think you are having some other problem here, changing to a separate
memory cache shouldn't solve corruption issues.
sorry,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Bruno Faccini <bruno.faccini@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date: Thu, 9 Jun 2016 18:28:33 -0700 [thread overview]
Message-ID: <20160610012833.GA6804@kroah.com> (raw)
In-Reply-To: <1465512347-11650-3-git-send-email-jsimmons@infradead.org>
On Thu, Jun 09, 2016 at 06:45:46PM -0400, James Simmons wrote:
> From: Bruno Faccini <bruno.faccini@intel.com>
>
> As part of LU-3848 and LU-4330, it has been discovered that LNET
> MEs and small MDs (<=128 Bytes) are allocated in <size-128> kmem_cache
> and thus can suffer quite frequent corruptions, from other modules or
> Kernel parts, that occur there. To avoid this, MEs and small-MDs
> specific kmem_cache have been created.
What? Who corrupts them? That shouldn't be possible, and on some
systems, even if you do ask for a separate slab, it will be merged
togther with others of the same size. So this patch doesn't do all that
much.
I think you are having some other problem here, changing to a separate
memory cache shouldn't solve corruption issues.
sorry,
greg k-h
next prev parent reply other threads:[~2016-06-10 1:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 22:45 [lustre-devel] [PATCH 0/3] staging: lustre: lnet: bug fixs for 4.7-rc2 James Simmons
2016-06-09 22:45 ` James Simmons
2016-06-09 22:45 ` [lustre-devel] [PATCH 1/3] staging: lustre: lnet: Don't access NULL NI on failure path James Simmons
2016-06-09 22:45 ` James Simmons
2016-06-09 22:45 ` [lustre-devel] [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches James Simmons
2016-06-09 22:45 ` James Simmons
2016-06-10 1:28 ` Greg Kroah-Hartman [this message]
2016-06-10 1:28 ` Greg Kroah-Hartman
2016-06-10 15:25 ` [lustre-devel] " Faccini, Bruno
2016-06-10 15:25 ` Faccini, Bruno
2016-06-10 16:36 ` [lustre-devel] " Greg Kroah-Hartman
2016-06-10 16:36 ` Greg Kroah-Hartman
2016-06-15 3:02 ` [lustre-devel] " James Simmons
2016-06-15 3:02 ` James Simmons
2016-06-18 3:32 ` [lustre-devel] " Greg Kroah-Hartman
2016-06-18 3:32 ` Greg Kroah-Hartman
2016-06-16 14:14 ` [lustre-devel] " Faccini, Bruno
2016-06-09 22:45 ` [lustre-devel] [PATCH 3/3] staging: lustre: lnet: optimize memory foot print for lnet_libmd James Simmons
2016-06-09 22:45 ` James Simmons
2016-06-10 1:28 ` [lustre-devel] " Greg Kroah-Hartman
2016-06-10 1:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610012833.GA6804@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=bruno.faccini@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.