All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>,
	"Faccini, Bruno" <bruno.faccini@intel.com>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date: Fri, 17 Jun 2016 20:32:03 -0700	[thread overview]
Message-ID: <20160618033203.GA13004@kroah.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1606150400230.17751@casper.infradead.org>

On Wed, Jun 15, 2016 at 04:02:40AM +0100, James Simmons wrote:
> 
> > > This may also possibly help to save cycles due to high usage and
> > > contention when using a generic kmem_cache (when they stay separate
> > > from others, thanks for the precision!).
> > 
> > Have you measured this?
> > 
> > This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,
> > which is why I pushed back on this.  If you want your own cache for
> > these variables, fine, I don't care, but that makes it a 4.8-rc1 patch
> > instead.
> > 
> > hope that helps explain things better,
> 
> As a side question when is the window to push patches of this class?
> Is it when 4.7-rc7 is merged to staging? 

You can send them to me anytime, I'll queue them up in my "-next" branch
to be merged in the next merge window.  Like I do for almost all lustre
patches that aren't bugfixes or regressions.

But I think you have a bigger problem here that you need to debug, using
a separate cache isn't going to solve that bug, only postpone you
finding it...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>,
	"Faccini, Bruno" <bruno.faccini@intel.com>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date: Fri, 17 Jun 2016 20:32:03 -0700	[thread overview]
Message-ID: <20160618033203.GA13004@kroah.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1606150400230.17751@casper.infradead.org>

On Wed, Jun 15, 2016 at 04:02:40AM +0100, James Simmons wrote:
> 
> > > This may also possibly help to save cycles due to high usage and
> > > contention when using a generic kmem_cache (when they stay separate
> > > from others, thanks for the precision!).
> > 
> > Have you measured this?
> > 
> > This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,
> > which is why I pushed back on this.  If you want your own cache for
> > these variables, fine, I don't care, but that makes it a 4.8-rc1 patch
> > instead.
> > 
> > hope that helps explain things better,
> 
> As a side question when is the window to push patches of this class?
> Is it when 4.7-rc7 is merged to staging? 

You can send them to me anytime, I'll queue them up in my "-next" branch
to be merged in the next merge window.  Like I do for almost all lustre
patches that aren't bugfixes or regressions.

But I think you have a bigger problem here that you need to debug, using
a separate cache isn't going to solve that bug, only postpone you
finding it...

thanks,

greg k-h

  reply	other threads:[~2016-06-18  3:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 22:45 [lustre-devel] [PATCH 0/3] staging: lustre: lnet: bug fixs for 4.7-rc2 James Simmons
2016-06-09 22:45 ` James Simmons
2016-06-09 22:45 ` [lustre-devel] [PATCH 1/3] staging: lustre: lnet: Don't access NULL NI on failure path James Simmons
2016-06-09 22:45   ` James Simmons
2016-06-09 22:45 ` [lustre-devel] [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches James Simmons
2016-06-09 22:45   ` James Simmons
2016-06-10  1:28   ` [lustre-devel] " Greg Kroah-Hartman
2016-06-10  1:28     ` Greg Kroah-Hartman
2016-06-10 15:25     ` [lustre-devel] " Faccini, Bruno
2016-06-10 15:25       ` Faccini, Bruno
2016-06-10 16:36       ` [lustre-devel] " Greg Kroah-Hartman
2016-06-10 16:36         ` Greg Kroah-Hartman
2016-06-15  3:02         ` [lustre-devel] " James Simmons
2016-06-15  3:02           ` James Simmons
2016-06-18  3:32           ` Greg Kroah-Hartman [this message]
2016-06-18  3:32             ` Greg Kroah-Hartman
2016-06-16 14:14         ` [lustre-devel] " Faccini, Bruno
2016-06-09 22:45 ` [lustre-devel] [PATCH 3/3] staging: lustre: lnet: optimize memory foot print for lnet_libmd James Simmons
2016-06-09 22:45   ` James Simmons
2016-06-10  1:28   ` [lustre-devel] " Greg Kroah-Hartman
2016-06-10  1:28     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160618033203.GA13004@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=bruno.faccini@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.