From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Fri, 10 Jun 2016 11:39:22 +0200 [thread overview]
Message-ID: <20160610093922.GR5242@lukather> (raw)
In-Reply-To: <20160603061336.16263-1-luoyi.ly@gmail.com>
On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly at gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
>
> Remove the extra empty line and add signed off.
>
> Signed-off-by: Luo Yi <luoyi.ly@gmail.com>
Please send a new patch.
> ---
> arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
> compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> };
>
> -
> &codec {
> status = "okay";
> };
> @@ -62,11 +61,8 @@
> interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
> interrupt-names = "host-wake";
> };
> -
> };
>
> &mmc3_pins_a {
> - /* AP6210 requires pull-up */
And that comment was fine, why did you remove it?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/d6dafede/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: luoyi.ly@gmail.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Fri, 10 Jun 2016 11:39:22 +0200 [thread overview]
Message-ID: <20160610093922.GR5242@lukather> (raw)
In-Reply-To: <20160603061336.16263-1-luoyi.ly@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
>
> Remove the extra empty line and add signed off.
>
> Signed-off-by: Luo Yi <luoyi.ly@gmail.com>
Please send a new patch.
> ---
> arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
> compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> };
>
> -
> &codec {
> status = "okay";
> };
> @@ -62,11 +61,8 @@
> interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
> interrupt-names = "host-wake";
> };
> -
> };
>
> &mmc3_pins_a {
> - /* AP6210 requires pull-up */
And that comment was fine, why did you remove it?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-10 9:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 2:36 [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly at gmail.com
2016-06-02 2:36 ` luoyi.ly
2016-06-02 2:36 ` luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w
2016-06-02 2:55 ` [linux-sunxi] " Julian Calaby
2016-06-02 2:55 ` Julian Calaby
2016-06-02 2:55 ` Julian Calaby
2016-06-02 8:16 ` Maxime Ripard
2016-06-02 8:16 ` Maxime Ripard
2016-06-02 8:16 ` Maxime Ripard
2016-06-02 9:15 ` [linux-sunxi] " Bernhard Nortmann
2016-06-02 9:15 ` Bernhard Nortmann
2016-06-02 9:15 ` Bernhard Nortmann
2016-06-03 6:13 ` [linux-sunxi] " luoyi.ly at gmail.com
2016-06-03 6:13 ` luoyi.ly
2016-06-03 6:13 ` luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w
2016-06-10 9:39 ` Maxime Ripard [this message]
2016-06-10 9:39 ` Maxime Ripard
2016-06-10 9:38 ` Maxime Ripard
2016-06-10 9:38 ` Maxime Ripard
2016-06-10 9:38 ` Maxime Ripard
2016-06-13 3:01 ` [linux-sunxi] " Chen-Yu Tsai
2016-06-13 3:01 ` Chen-Yu Tsai
2016-06-13 3:01 ` Chen-Yu Tsai
2016-06-15 20:52 ` [linux-sunxi] " Maxime Ripard
2016-06-15 20:52 ` Maxime Ripard
2016-06-15 20:52 ` Maxime Ripard
2016-06-16 3:05 ` [linux-sunxi] " Chen-Yu Tsai
2016-06-16 3:05 ` Chen-Yu Tsai
2016-06-16 3:05 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610093922.GR5242@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.