All of lore.kernel.org
 help / color / mirror / Atom feed
From: bernhard.nortmann@web.de (Bernhard Nortmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Thu, 2 Jun 2016 11:15:55 +0200	[thread overview]
Message-ID: <574FF94B.3020309@web.de> (raw)
In-Reply-To: <20160602081638.GG4908@lukather>

Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann

WARNING: multiple messages have this Message-ID (diff)
From: Bernhard Nortmann <bernhard.nortmann-S0/GAf8tV78@public.gmane.org>
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	Julian Calaby
	<julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Mailing List,
	Arm"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Thu, 2 Jun 2016 11:15:55 +0200	[thread overview]
Message-ID: <574FF94B.3020309@web.de> (raw)
In-Reply-To: <20160602081638.GG4908@lukather>

Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann

WARNING: multiple messages have this Message-ID (diff)
From: Bernhard Nortmann <bernhard.nortmann@web.de>
To: maxime.ripard@free-electrons.com,
	Julian Calaby <julian.calaby@gmail.com>
Cc: luoyi.ly@gmail.com, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Chen-Yu Tsai <wens@csie.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Thu, 2 Jun 2016 11:15:55 +0200	[thread overview]
Message-ID: <574FF94B.3020309@web.de> (raw)
In-Reply-To: <20160602081638.GG4908@lukather>

Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann

  reply	other threads:[~2016-06-02  9:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  2:36 [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly at gmail.com
2016-06-02  2:36 ` luoyi.ly
2016-06-02  2:36 ` luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w
2016-06-02  2:55 ` [linux-sunxi] " Julian Calaby
2016-06-02  2:55   ` Julian Calaby
2016-06-02  2:55   ` Julian Calaby
2016-06-02  8:16   ` Maxime Ripard
2016-06-02  8:16     ` Maxime Ripard
2016-06-02  8:16     ` Maxime Ripard
2016-06-02  9:15     ` Bernhard Nortmann [this message]
2016-06-02  9:15       ` [linux-sunxi] " Bernhard Nortmann
2016-06-02  9:15       ` Bernhard Nortmann
2016-06-03  6:13       ` [linux-sunxi] " luoyi.ly at gmail.com
2016-06-03  6:13         ` luoyi.ly
2016-06-03  6:13         ` luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w
2016-06-10  9:39         ` Maxime Ripard
2016-06-10  9:39           ` Maxime Ripard
2016-06-10  9:38       ` Maxime Ripard
2016-06-10  9:38         ` Maxime Ripard
2016-06-10  9:38         ` Maxime Ripard
2016-06-13  3:01         ` [linux-sunxi] " Chen-Yu Tsai
2016-06-13  3:01           ` Chen-Yu Tsai
2016-06-13  3:01           ` Chen-Yu Tsai
2016-06-15 20:52           ` [linux-sunxi] " Maxime Ripard
2016-06-15 20:52             ` Maxime Ripard
2016-06-15 20:52             ` Maxime Ripard
2016-06-16  3:05             ` [linux-sunxi] " Chen-Yu Tsai
2016-06-16  3:05               ` Chen-Yu Tsai
2016-06-16  3:05               ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574FF94B.3020309@web.de \
    --to=bernhard.nortmann@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.