From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
stanimir.varbanov@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: dts: qcom: Remove size elements from pmic reg
Date: Fri, 10 Jun 2016 13:26:12 -0700 [thread overview]
Message-ID: <20160610202612.GP1256@tuxbot> (raw)
In-Reply-To: <1463634020-17252-5-git-send-email-andy.gross@linaro.org>
On Wed 18 May 22:00 PDT 2016, Andy Gross wrote:
> The #size-cells for the pmics are 0, but we specify a size in the
> reg property so that MPP and GPIO modules can figure out how many
> pins there are. Now that we've done that by counting irqs, we can
> remove the size elements in the reg properties and be DT
> compliant.
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm/boot/dts/qcom-pma8084.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> index 4e9bd3f..ea7fce3 100644
> --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> @@ -12,15 +12,15 @@
>
> rtc@6000 {
> compatible = "qcom,pm8941-rtc";
> - reg = <0x6000 0x100>,
> - <0x6100 0x100>;
> + reg = <0x6000>,
> + <0x6100>;
> reg-names = "rtc", "alarm";
> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> };
>
> pma8084_gpios: gpios@c000 {
> compatible = "qcom,pma8084-gpio", "qcom,spmi-gpio";
> - reg = <0xc000 0x1600>;
> + reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> @@ -49,7 +49,7 @@
>
> pma8084_mpps: mpps@a000 {
> compatible = "qcom,pma8084-mpp", "qcom,spmi-mpp";
> - reg = <0xa000 0x800>;
> + reg = <0xa000>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupts = <0 0xa0 0 IRQ_TYPE_NONE>,
> @@ -64,7 +64,7 @@
>
> pma8084_temp: temp-alarm@2400 {
> compatible = "qcom,spmi-temp-alarm";
> - reg = <0x2400 0x100>;
> + reg = <0x2400>;
> interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> #thermal-sensor-cells = <0>;
> io-channels = <&pma8084_vadc VADC_DIE_TEMP>;
> @@ -73,7 +73,7 @@
>
> pma8084_vadc: vadc@3100 {
> compatible = "qcom,spmi-vadc";
> - reg = <0x3100 0x100>;
> + reg = <0x3100>;
> interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: dts: qcom: Remove size elements from pmic reg
Date: Fri, 10 Jun 2016 13:26:12 -0700 [thread overview]
Message-ID: <20160610202612.GP1256@tuxbot> (raw)
In-Reply-To: <1463634020-17252-5-git-send-email-andy.gross@linaro.org>
On Wed 18 May 22:00 PDT 2016, Andy Gross wrote:
> The #size-cells for the pmics are 0, but we specify a size in the
> reg property so that MPP and GPIO modules can figure out how many
> pins there are. Now that we've done that by counting irqs, we can
> remove the size elements in the reg properties and be DT
> compliant.
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm/boot/dts/qcom-pma8084.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> index 4e9bd3f..ea7fce3 100644
> --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> @@ -12,15 +12,15 @@
>
> rtc at 6000 {
> compatible = "qcom,pm8941-rtc";
> - reg = <0x6000 0x100>,
> - <0x6100 0x100>;
> + reg = <0x6000>,
> + <0x6100>;
> reg-names = "rtc", "alarm";
> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> };
>
> pma8084_gpios: gpios at c000 {
> compatible = "qcom,pma8084-gpio", "qcom,spmi-gpio";
> - reg = <0xc000 0x1600>;
> + reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> @@ -49,7 +49,7 @@
>
> pma8084_mpps: mpps at a000 {
> compatible = "qcom,pma8084-mpp", "qcom,spmi-mpp";
> - reg = <0xa000 0x800>;
> + reg = <0xa000>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupts = <0 0xa0 0 IRQ_TYPE_NONE>,
> @@ -64,7 +64,7 @@
>
> pma8084_temp: temp-alarm at 2400 {
> compatible = "qcom,spmi-temp-alarm";
> - reg = <0x2400 0x100>;
> + reg = <0x2400>;
> interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> #thermal-sensor-cells = <0>;
> io-channels = <&pma8084_vadc VADC_DIE_TEMP>;
> @@ -73,7 +73,7 @@
>
> pma8084_vadc: vadc at 3100 {
> compatible = "qcom,spmi-vadc";
> - reg = <0x3100 0x100>;
> + reg = <0x3100>;
> interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-06-10 20:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 5:00 [PATCH 0/5] Qualcomm Suspend to Idle Support Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-05-19 5:00 ` [PATCH 1/5] soc: qcom: Add suspend to idle support Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-06-09 7:39 ` Ulf Hansson
2016-06-09 7:39 ` Ulf Hansson
2016-06-09 18:09 ` Andy Gross
2016-06-09 18:09 ` Andy Gross
2016-06-10 8:47 ` Ulf Hansson
2016-06-10 8:47 ` Ulf Hansson
2016-06-10 15:26 ` Andy Gross
2016-06-10 15:26 ` Andy Gross
2016-06-13 16:12 ` Daniel Lezcano
2016-06-13 16:12 ` Daniel Lezcano
2016-05-19 5:00 ` [PATCH 2/5] arm: defconfig: Enable PM8941 pwr key Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-06-10 20:25 ` Bjorn Andersson
2016-06-10 20:25 ` Bjorn Andersson
2016-05-19 5:00 ` [PATCH 3/5] arm64: dts: msm8916: Add spc compat tag Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-05-19 19:52 ` Stanimir Varbanov
2016-05-19 19:52 ` Stanimir Varbanov
2016-05-19 20:16 ` Andy Gross
2016-05-19 20:16 ` Andy Gross
2016-06-10 15:48 ` Mark Rutland
2016-06-10 15:48 ` Mark Rutland
2016-06-10 16:12 ` Andy Gross
2016-06-10 16:12 ` Andy Gross
2016-06-10 16:25 ` Mark Rutland
2016-06-10 16:25 ` Mark Rutland
2016-06-10 16:47 ` Andy Gross
2016-06-10 16:47 ` Andy Gross
2016-06-10 21:16 ` Lina Iyer
2016-06-10 21:16 ` Lina Iyer
2016-06-10 21:52 ` Andy Gross
2016-06-10 21:52 ` Andy Gross
2016-06-13 11:00 ` Mark Rutland
2016-06-13 11:00 ` Mark Rutland
2016-06-13 13:48 ` Lorenzo Pieralisi
2016-06-13 13:48 ` Lorenzo Pieralisi
2016-06-16 8:12 ` Andy Gross
2016-06-16 8:12 ` Andy Gross
2016-06-10 16:31 ` Lorenzo Pieralisi
2016-06-10 16:31 ` Lorenzo Pieralisi
2016-06-10 16:52 ` Andy Gross
2016-06-10 16:52 ` Andy Gross
2016-06-10 17:06 ` Lorenzo Pieralisi
2016-06-10 17:06 ` Lorenzo Pieralisi
2016-06-10 17:27 ` Andy Gross
2016-06-10 17:27 ` Andy Gross
2016-06-10 20:59 ` Lorenzo Pieralisi
2016-06-10 20:59 ` Lorenzo Pieralisi
2016-05-19 5:00 ` [PATCH 4/5] ARM: dts: qcom: Remove size elements from pmic reg Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-06-10 20:26 ` Bjorn Andersson [this message]
2016-06-10 20:26 ` Bjorn Andersson
2016-05-19 5:00 ` [PATCH 5/5] ARM: dts: qcom: pma8084: Add pwrkey entry Andy Gross
2016-05-19 5:00 ` Andy Gross
2016-06-10 20:29 ` Bjorn Andersson
2016-06-10 20:29 ` Bjorn Andersson
2016-05-20 6:09 ` [PATCH 0/5] Qualcomm Suspend to Idle Support Pramod Gurav
2016-05-20 6:09 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610202612.GP1256@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.