All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	stanimir.varbanov@linaro.org
Subject: Re: [PATCH 1/5] soc: qcom: Add suspend to idle support
Date: Mon, 13 Jun 2016 18:12:11 +0200	[thread overview]
Message-ID: <20160613161211.GG10634@linaro.org> (raw)
In-Reply-To: <20160609180902.GJ13357@hector.attlocal.net>

On Thu, Jun 09, 2016 at 01:09:02PM -0500, Andy Gross wrote:
> On Thu, Jun 09, 2016 at 09:39:34AM +0200, Ulf Hansson wrote:
> > + Daniel
> > 
> > On 19 May 2016 at 07:00, Andy Gross <andy.gross@linaro.org> wrote:

[ ... ]

> > I don't think this will work!
> > 
> > When building a multi defconfig for ARM, you might overwrite the
> > suspend_ops (there's only one set) as here you don't know that it's
> > actually the QCOM platform that is running, right!?
> > 
> > Perhaps this code actually belongs closer to the cpuidle driver?
> 
> Hmmmm, I might have to get creative.  I originally had a DT entry for the pm,
> but that doesn't make sense as this is purely a software construct.  The db410c
> uses the arm cpuidle driver so I can't really hook it in there.  I'll have to
> come up with something else.

IMO, the generic ARM driver should be revisited to add support for suspend 
to idle.


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] soc: qcom: Add suspend to idle support
Date: Mon, 13 Jun 2016 18:12:11 +0200	[thread overview]
Message-ID: <20160613161211.GG10634@linaro.org> (raw)
In-Reply-To: <20160609180902.GJ13357@hector.attlocal.net>

On Thu, Jun 09, 2016 at 01:09:02PM -0500, Andy Gross wrote:
> On Thu, Jun 09, 2016 at 09:39:34AM +0200, Ulf Hansson wrote:
> > + Daniel
> > 
> > On 19 May 2016 at 07:00, Andy Gross <andy.gross@linaro.org> wrote:

[ ... ]

> > I don't think this will work!
> > 
> > When building a multi defconfig for ARM, you might overwrite the
> > suspend_ops (there's only one set) as here you don't know that it's
> > actually the QCOM platform that is running, right!?
> > 
> > Perhaps this code actually belongs closer to the cpuidle driver?
> 
> Hmmmm, I might have to get creative.  I originally had a DT entry for the pm,
> but that doesn't make sense as this is purely a software construct.  The db410c
> uses the arm cpuidle driver so I can't really hook it in there.  I'll have to
> come up with something else.

IMO, the generic ARM driver should be revisited to add support for suspend 
to idle.

  parent reply	other threads:[~2016-06-13 16:12 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19  5:00 [PATCH 0/5] Qualcomm Suspend to Idle Support Andy Gross
2016-05-19  5:00 ` Andy Gross
2016-05-19  5:00 ` [PATCH 1/5] soc: qcom: Add suspend to idle support Andy Gross
2016-05-19  5:00   ` Andy Gross
2016-06-09  7:39   ` Ulf Hansson
2016-06-09  7:39     ` Ulf Hansson
2016-06-09 18:09     ` Andy Gross
2016-06-09 18:09       ` Andy Gross
2016-06-10  8:47       ` Ulf Hansson
2016-06-10  8:47         ` Ulf Hansson
2016-06-10 15:26         ` Andy Gross
2016-06-10 15:26           ` Andy Gross
2016-06-13 16:12       ` Daniel Lezcano [this message]
2016-06-13 16:12         ` Daniel Lezcano
2016-05-19  5:00 ` [PATCH 2/5] arm: defconfig: Enable PM8941 pwr key Andy Gross
2016-05-19  5:00   ` Andy Gross
2016-06-10 20:25   ` Bjorn Andersson
2016-06-10 20:25     ` Bjorn Andersson
2016-05-19  5:00 ` [PATCH 3/5] arm64: dts: msm8916: Add spc compat tag Andy Gross
2016-05-19  5:00   ` Andy Gross
2016-05-19 19:52   ` Stanimir Varbanov
2016-05-19 19:52     ` Stanimir Varbanov
2016-05-19 20:16     ` Andy Gross
2016-05-19 20:16       ` Andy Gross
2016-06-10 15:48   ` Mark Rutland
2016-06-10 15:48     ` Mark Rutland
2016-06-10 16:12     ` Andy Gross
2016-06-10 16:12       ` Andy Gross
2016-06-10 16:25       ` Mark Rutland
2016-06-10 16:25         ` Mark Rutland
2016-06-10 16:47         ` Andy Gross
2016-06-10 16:47           ` Andy Gross
2016-06-10 21:16           ` Lina Iyer
2016-06-10 21:16             ` Lina Iyer
2016-06-10 21:52             ` Andy Gross
2016-06-10 21:52               ` Andy Gross
2016-06-13 11:00           ` Mark Rutland
2016-06-13 11:00             ` Mark Rutland
2016-06-13 13:48             ` Lorenzo Pieralisi
2016-06-13 13:48               ` Lorenzo Pieralisi
2016-06-16  8:12               ` Andy Gross
2016-06-16  8:12                 ` Andy Gross
2016-06-10 16:31       ` Lorenzo Pieralisi
2016-06-10 16:31         ` Lorenzo Pieralisi
2016-06-10 16:52         ` Andy Gross
2016-06-10 16:52           ` Andy Gross
2016-06-10 17:06           ` Lorenzo Pieralisi
2016-06-10 17:06             ` Lorenzo Pieralisi
2016-06-10 17:27             ` Andy Gross
2016-06-10 17:27               ` Andy Gross
2016-06-10 20:59               ` Lorenzo Pieralisi
2016-06-10 20:59                 ` Lorenzo Pieralisi
2016-05-19  5:00 ` [PATCH 4/5] ARM: dts: qcom: Remove size elements from pmic reg Andy Gross
2016-05-19  5:00   ` Andy Gross
2016-06-10 20:26   ` Bjorn Andersson
2016-06-10 20:26     ` Bjorn Andersson
2016-05-19  5:00 ` [PATCH 5/5] ARM: dts: qcom: pma8084: Add pwrkey entry Andy Gross
2016-05-19  5:00   ` Andy Gross
2016-06-10 20:29   ` Bjorn Andersson
2016-06-10 20:29     ` Bjorn Andersson
2016-05-20  6:09 ` [PATCH 0/5] Qualcomm Suspend to Idle Support Pramod Gurav
2016-05-20  6:09   ` Pramod Gurav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613161211.GG10634@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.