All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] i.MX: system.c: Replace magic numbers
Date: Sat, 11 Jun 2016 21:39:59 +0800	[thread overview]
Message-ID: <20160611133959.GN20243@tiger> (raw)
In-Reply-To: <1465313366-5182-3-git-send-email-andrew.smirnov@gmail.com>

On Tue, Jun 07, 2016 at 08:29:26AM -0700, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/include/asm/hardware/cache-l2x0.h | 7 +++++++

I need Russell's ACK on this file.

Shawn

>  arch/arm/mach-imx/system.c                 | 5 ++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h
> index 3a5ec1c..5e27162 100644
> --- a/arch/arm/include/asm/hardware/cache-l2x0.h
> +++ b/arch/arm/include/asm/hardware/cache-l2x0.h
> @@ -61,6 +61,13 @@
>  #define L2X0_LINE_TAG			0xF30
>  #define L2X0_DEBUG_CTRL			0xF40
>  #define L310_PREFETCH_CTRL		0xF60
> +#define   L310_DOUBLE_LINEFILL_EN			BIT(30)
> +#define   L310_INSTRUCTION_PREFETCH_EN			BIT(29)
> +#define   L310_DATA_PREFETCH_EN				BIT(28)
> +#define   L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS		BIT(27)
> +#define   L310_PREFETCH_DROP_EN				BIT(24)
> +#define   L310_INCR_DOUBLE_LINEFILL_EN			BIT(23)
> +#define   L310_ESCLUSIVE_SEQUENCE_EN			BIT(21)
>  #define L310_POWER_CTRL			0xF80
>  #define   L310_DYNAMIC_CLK_GATING_EN	(1 << 1)
>  #define   L310_STNDBY_MODE_EN		(1 << 0)
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> index b153376..bd9a96b 100644
> --- a/arch/arm/mach-imx/system.c
> +++ b/arch/arm/mach-imx/system.c
> @@ -109,7 +109,10 @@ void __init imx_init_l2cache(void)
>  	if (!(readl_relaxed(l2x0_base + L2X0_CTRL) & L2X0_CTRL_EN)) {
>  		/* Configure the L2 PREFETCH and POWER registers */
>  		val = readl_relaxed(l2x0_base + L310_PREFETCH_CTRL);
> -		val |= 0x70800000;
> +		val |=  L310_DOUBLE_LINEFILL_EN |
> +		        L310_INSTRUCTION_PREFETCH_EN |
> +			L310_DATA_PREFETCH_EN |
> +			L310_INCR_DOUBLE_LINEFILL_EN;
>  		writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
>  	}
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers
Date: Sat, 11 Jun 2016 21:39:59 +0800	[thread overview]
Message-ID: <20160611133959.GN20243@tiger> (raw)
In-Reply-To: <1465313366-5182-3-git-send-email-andrew.smirnov@gmail.com>

On Tue, Jun 07, 2016 at 08:29:26AM -0700, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/include/asm/hardware/cache-l2x0.h | 7 +++++++

I need Russell's ACK on this file.

Shawn

>  arch/arm/mach-imx/system.c                 | 5 ++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h
> index 3a5ec1c..5e27162 100644
> --- a/arch/arm/include/asm/hardware/cache-l2x0.h
> +++ b/arch/arm/include/asm/hardware/cache-l2x0.h
> @@ -61,6 +61,13 @@
>  #define L2X0_LINE_TAG			0xF30
>  #define L2X0_DEBUG_CTRL			0xF40
>  #define L310_PREFETCH_CTRL		0xF60
> +#define   L310_DOUBLE_LINEFILL_EN			BIT(30)
> +#define   L310_INSTRUCTION_PREFETCH_EN			BIT(29)
> +#define   L310_DATA_PREFETCH_EN				BIT(28)
> +#define   L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS		BIT(27)
> +#define   L310_PREFETCH_DROP_EN				BIT(24)
> +#define   L310_INCR_DOUBLE_LINEFILL_EN			BIT(23)
> +#define   L310_ESCLUSIVE_SEQUENCE_EN			BIT(21)
>  #define L310_POWER_CTRL			0xF80
>  #define   L310_DYNAMIC_CLK_GATING_EN	(1 << 1)
>  #define   L310_STNDBY_MODE_EN		(1 << 0)
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> index b153376..bd9a96b 100644
> --- a/arch/arm/mach-imx/system.c
> +++ b/arch/arm/mach-imx/system.c
> @@ -109,7 +109,10 @@ void __init imx_init_l2cache(void)
>  	if (!(readl_relaxed(l2x0_base + L2X0_CTRL) & L2X0_CTRL_EN)) {
>  		/* Configure the L2 PREFETCH and POWER registers */
>  		val = readl_relaxed(l2x0_base + L310_PREFETCH_CTRL);
> -		val |= 0x70800000;
> +		val |=  L310_DOUBLE_LINEFILL_EN |
> +		        L310_INSTRUCTION_PREFETCH_EN |
> +			L310_DATA_PREFETCH_EN |
> +			L310_INCR_DOUBLE_LINEFILL_EN;
>  		writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
>  	}
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-06-11 13:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 15:29 [PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-07 15:29 ` Andrey Smirnov
2016-06-07 15:29 ` [PATCH 2/3] i.MX: system.c: Remove redundant errat 752271 code Andrey Smirnov
2016-06-07 15:29   ` Andrey Smirnov
2016-06-07 15:29 ` [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-07 15:29   ` Andrey Smirnov
2016-06-11 13:39   ` Shawn Guo [this message]
2016-06-11 13:39     ` Shawn Guo
  -- strict thread matches above, loose matches on Subject: below --
2016-06-13  5:55 [PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-13  5:55 ` [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-13  5:55   ` Andrey Smirnov
2016-06-13  9:24   ` Arnd Bergmann
2016-06-13  9:24     ` Arnd Bergmann
2016-06-13  9:41     ` Russell King - ARM Linux
2016-06-13  9:41       ` Russell King - ARM Linux
2016-06-13  9:28   ` Russell King - ARM Linux
2016-06-13  9:28     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160611133959.GN20243@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.