From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] i.MX: system.c: Replace magic numbers
Date: Mon, 13 Jun 2016 11:24:02 +0200 [thread overview]
Message-ID: <7839599.pSVM3KJL9Z@wuerfel> (raw)
In-Reply-To: <1465797329-22537-3-git-send-email-andrew.smirnov@gmail.com>
On Sunday, June 12, 2016 10:55:29 PM CEST Andrey Smirnov wrote:
> @@ -61,6 +61,13 @@
> #define L2X0_LINE_TAG 0xF30
> #define L2X0_DEBUG_CTRL 0xF40
> #define L310_PREFETCH_CTRL 0xF60
> +#define L310_DOUBLE_LINEFILL_EN BIT(30)
> +#define L310_INSTRUCTION_PREFETCH_EN BIT(29)
> +#define L310_DATA_PREFETCH_EN BIT(28)
> +#define L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS BIT(27)
> +#define L310_PREFETCH_DROP_EN BIT(24)
> +#define L310_INCR_DOUBLE_LINEFILL_EN BIT(23)
> +#define L310_ESCLUSIVE_SEQUENCE_EN BIT(21)
> #define L310_POWER_CTRL 0xF80
> #define L310_DYNAMIC_CLK_GATING_EN (1 << 1)
> #define L310_STNDBY_MODE_EN (1 << 0)
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
>
Most of these macros seem to all exist further down in the file already
under slightly differnet names, e.g.
#define L310_PREFETCH_CTRL_DBL_LINEFILL_INCR BIT(23)
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers
Date: Mon, 13 Jun 2016 11:24:02 +0200 [thread overview]
Message-ID: <7839599.pSVM3KJL9Z@wuerfel> (raw)
In-Reply-To: <1465797329-22537-3-git-send-email-andrew.smirnov@gmail.com>
On Sunday, June 12, 2016 10:55:29 PM CEST Andrey Smirnov wrote:
> @@ -61,6 +61,13 @@
> #define L2X0_LINE_TAG 0xF30
> #define L2X0_DEBUG_CTRL 0xF40
> #define L310_PREFETCH_CTRL 0xF60
> +#define L310_DOUBLE_LINEFILL_EN BIT(30)
> +#define L310_INSTRUCTION_PREFETCH_EN BIT(29)
> +#define L310_DATA_PREFETCH_EN BIT(28)
> +#define L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS BIT(27)
> +#define L310_PREFETCH_DROP_EN BIT(24)
> +#define L310_INCR_DOUBLE_LINEFILL_EN BIT(23)
> +#define L310_ESCLUSIVE_SEQUENCE_EN BIT(21)
> #define L310_POWER_CTRL 0xF80
> #define L310_DYNAMIC_CLK_GATING_EN (1 << 1)
> #define L310_STNDBY_MODE_EN (1 << 0)
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
>
Most of these macros seem to all exist further down in the file already
under slightly differnet names, e.g.
#define L310_PREFETCH_CTRL_DBL_LINEFILL_INCR BIT(23)
Arnd
next prev parent reply other threads:[~2016-06-13 9:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 5:55 [PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-13 5:55 ` Andrey Smirnov
2016-06-13 5:55 ` [RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov
2016-06-13 5:55 ` Andrey Smirnov
2016-06-13 5:55 ` [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-13 5:55 ` Andrey Smirnov
2016-06-13 9:24 ` Arnd Bergmann [this message]
2016-06-13 9:24 ` Arnd Bergmann
2016-06-13 9:41 ` Russell King - ARM Linux
2016-06-13 9:41 ` Russell King - ARM Linux
2016-06-13 9:28 ` Russell King - ARM Linux
2016-06-13 9:28 ` Russell King - ARM Linux
2016-06-13 9:24 ` [PATCH 1/3] i.MX: system.c: Convert goto to if statement Arnd Bergmann
2016-06-13 9:24 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2016-06-07 15:29 Andrey Smirnov
2016-06-07 15:29 ` [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-07 15:29 ` Andrey Smirnov
2016-06-11 13:39 ` Shawn Guo
2016-06-11 13:39 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7839599.pSVM3KJL9Z@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.