From: Alexander Duyck <aduyck@mirantis.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net-next PATCH 09/15] mlx4_en: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port
Date: Mon, 13 Jun 2016 10:49:12 -0700 [thread overview]
Message-ID: <20160613174912.15186.33016.stgit@localhost.localdomain> (raw)
In-Reply-To: <20160613173750.15186.24381.stgit@localhost.localdomain>
This change replaces the network device operations for adding or removing a
VXLAN port with operations that are more generically defined to be used for
any UDP offload port but provide a type. As such by just adding a line to
verify that the offload type is VXLAN we can maintain the same
functionality.
In addition I updated the socket address family check so that instead of
excluding IPv6 we instead abort of type is not IPv4. This makes much more
sense as we should only be supporting IPv4 outer addresses on this
hardware.
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 +++++++++++++++---------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 973391bfe286..d4d5fdffbcee 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1694,7 +1694,7 @@ int mlx4_en_start_port(struct net_device *dev)
#ifdef CONFIG_MLX4_EN_VXLAN
if (priv->mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
- vxlan_get_rx_port(dev);
+ udp_tunnel_get_rx_port(dev);
#endif
priv->port_up = true;
netif_tx_start_all_queues(dev);
@@ -2392,15 +2392,19 @@ static void mlx4_en_del_vxlan_offloads(struct work_struct *work)
}
static void mlx4_en_add_vxlan_port(struct net_device *dev,
- sa_family_t sa_family, __be16 port)
+ sa_family_t sa_family, __be16 port,
+ unsigned int type)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
__be16 current_port;
- if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
+ if (type != UDP_ENC_OFFLOAD_TYPE_VXLAN)
+ return;
+
+ if (sa_family != AF_INET)
return;
- if (sa_family == AF_INET6)
+ if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
return;
current_port = priv->vxlan_port;
@@ -2415,15 +2419,19 @@ static void mlx4_en_add_vxlan_port(struct net_device *dev,
}
static void mlx4_en_del_vxlan_port(struct net_device *dev,
- sa_family_t sa_family, __be16 port)
+ sa_family_t sa_family, __be16 port,
+ unsigned int type)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
__be16 current_port;
- if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
+ if (type != UDP_ENC_OFFLOAD_TYPE_VXLAN)
+ return;
+
+ if (sa_family != AF_INET)
return;
- if (sa_family == AF_INET6)
+ if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
return;
current_port = priv->vxlan_port;
@@ -2507,8 +2515,8 @@ static const struct net_device_ops mlx4_netdev_ops = {
#endif
.ndo_get_phys_port_id = mlx4_en_get_phys_port_id,
#ifdef CONFIG_MLX4_EN_VXLAN
- .ndo_add_vxlan_port = mlx4_en_add_vxlan_port,
- .ndo_del_vxlan_port = mlx4_en_del_vxlan_port,
+ .ndo_add_udp_enc_port = mlx4_en_add_vxlan_port,
+ .ndo_del_udp_enc_port = mlx4_en_del_vxlan_port,
.ndo_features_check = mlx4_en_features_check,
#endif
.ndo_set_tx_maxrate = mlx4_en_set_tx_maxrate,
@@ -2545,8 +2553,8 @@ static const struct net_device_ops mlx4_netdev_ops_master = {
#endif
.ndo_get_phys_port_id = mlx4_en_get_phys_port_id,
#ifdef CONFIG_MLX4_EN_VXLAN
- .ndo_add_vxlan_port = mlx4_en_add_vxlan_port,
- .ndo_del_vxlan_port = mlx4_en_del_vxlan_port,
+ .ndo_add_udp_enc_port = mlx4_en_add_vxlan_port,
+ .ndo_del_udp_enc_port = mlx4_en_del_vxlan_port,
.ndo_features_check = mlx4_en_features_check,
#endif
.ndo_set_tx_maxrate = mlx4_en_set_tx_maxrate,
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <aduyck@mirantis.com>
To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Cc: hannes@redhat.com, jesse@kernel.org, jbenc@redhat.com,
alexander.duyck@gmail.com, saeedm@mellanox.com,
ariel.elior@qlogic.com, tom@herbertland.com,
Dept-GELinuxNICDev@qlogic.com, davem@davemloft.net,
eugenia@mellanox.com
Subject: [net-next PATCH 09/15] mlx4_en: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port
Date: Mon, 13 Jun 2016 10:49:12 -0700 [thread overview]
Message-ID: <20160613174912.15186.33016.stgit@localhost.localdomain> (raw)
In-Reply-To: <20160613173750.15186.24381.stgit@localhost.localdomain>
This change replaces the network device operations for adding or removing a
VXLAN port with operations that are more generically defined to be used for
any UDP offload port but provide a type. As such by just adding a line to
verify that the offload type is VXLAN we can maintain the same
functionality.
In addition I updated the socket address family check so that instead of
excluding IPv6 we instead abort of type is not IPv4. This makes much more
sense as we should only be supporting IPv4 outer addresses on this
hardware.
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 +++++++++++++++---------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 973391bfe286..d4d5fdffbcee 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1694,7 +1694,7 @@ int mlx4_en_start_port(struct net_device *dev)
#ifdef CONFIG_MLX4_EN_VXLAN
if (priv->mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
- vxlan_get_rx_port(dev);
+ udp_tunnel_get_rx_port(dev);
#endif
priv->port_up = true;
netif_tx_start_all_queues(dev);
@@ -2392,15 +2392,19 @@ static void mlx4_en_del_vxlan_offloads(struct work_struct *work)
}
static void mlx4_en_add_vxlan_port(struct net_device *dev,
- sa_family_t sa_family, __be16 port)
+ sa_family_t sa_family, __be16 port,
+ unsigned int type)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
__be16 current_port;
- if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
+ if (type != UDP_ENC_OFFLOAD_TYPE_VXLAN)
+ return;
+
+ if (sa_family != AF_INET)
return;
- if (sa_family == AF_INET6)
+ if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
return;
current_port = priv->vxlan_port;
@@ -2415,15 +2419,19 @@ static void mlx4_en_add_vxlan_port(struct net_device *dev,
}
static void mlx4_en_del_vxlan_port(struct net_device *dev,
- sa_family_t sa_family, __be16 port)
+ sa_family_t sa_family, __be16 port,
+ unsigned int type)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
__be16 current_port;
- if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
+ if (type != UDP_ENC_OFFLOAD_TYPE_VXLAN)
+ return;
+
+ if (sa_family != AF_INET)
return;
- if (sa_family == AF_INET6)
+ if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
return;
current_port = priv->vxlan_port;
@@ -2507,8 +2515,8 @@ static const struct net_device_ops mlx4_netdev_ops = {
#endif
.ndo_get_phys_port_id = mlx4_en_get_phys_port_id,
#ifdef CONFIG_MLX4_EN_VXLAN
- .ndo_add_vxlan_port = mlx4_en_add_vxlan_port,
- .ndo_del_vxlan_port = mlx4_en_del_vxlan_port,
+ .ndo_add_udp_enc_port = mlx4_en_add_vxlan_port,
+ .ndo_del_udp_enc_port = mlx4_en_del_vxlan_port,
.ndo_features_check = mlx4_en_features_check,
#endif
.ndo_set_tx_maxrate = mlx4_en_set_tx_maxrate,
@@ -2545,8 +2553,8 @@ static const struct net_device_ops mlx4_netdev_ops_master = {
#endif
.ndo_get_phys_port_id = mlx4_en_get_phys_port_id,
#ifdef CONFIG_MLX4_EN_VXLAN
- .ndo_add_vxlan_port = mlx4_en_add_vxlan_port,
- .ndo_del_vxlan_port = mlx4_en_del_vxlan_port,
+ .ndo_add_udp_enc_port = mlx4_en_add_vxlan_port,
+ .ndo_del_udp_enc_port = mlx4_en_del_vxlan_port,
.ndo_features_check = mlx4_en_features_check,
#endif
.ndo_set_tx_maxrate = mlx4_en_set_tx_maxrate,
next prev parent reply other threads:[~2016-06-13 17:49 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 17:47 [Intel-wired-lan] [net-next PATCH 00/15] Future-proof tunnel offload handlers Alexander Duyck
2016-06-13 17:47 ` Alexander Duyck
2016-06-13 17:47 ` [Intel-wired-lan] [net-next PATCH 01/15] net: Combine GENEVE and VXLAN port offload notifiers into single functions Alexander Duyck
2016-06-13 17:47 ` Alexander Duyck
2016-06-13 19:55 ` [Intel-wired-lan] " Tom Herbert
2016-06-13 19:55 ` Tom Herbert
2016-06-13 20:24 ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 20:24 ` Alexander Duyck
2016-06-13 20:36 ` [Intel-wired-lan] " Tom Herbert
2016-06-13 20:36 ` Tom Herbert
2016-06-13 21:51 ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 21:51 ` Alexander Duyck
2016-06-13 22:17 ` [Intel-wired-lan] " Tom Herbert
2016-06-13 22:17 ` Tom Herbert
2016-06-13 23:12 ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 23:12 ` Alexander Duyck
2016-06-14 0:28 ` [Intel-wired-lan] " Tom Herbert
2016-06-14 0:28 ` Tom Herbert
2016-06-14 2:50 ` [Intel-wired-lan] " Alexander Duyck
2016-06-14 2:50 ` Alexander Duyck
2016-06-14 3:13 ` [Intel-wired-lan] " Tom Herbert
2016-06-15 7:22 ` David Miller
2016-06-15 7:22 ` David Miller
2016-06-15 16:12 ` [Intel-wired-lan] " Tom Herbert
2016-06-15 16:12 ` Tom Herbert
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 02/15] net: Merge VXLAN and GENEVE push notifiers into a single notifier Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 17:57 ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 17:57 ` Hannes Frederic Sowa
2016-06-13 19:31 ` [Intel-wired-lan] " Tom Herbert
2016-06-13 19:31 ` Tom Herbert
2016-06-13 19:47 ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 19:47 ` Alexander Duyck
2016-06-13 21:08 ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 21:08 ` Hannes Frederic Sowa
2016-06-13 21:58 ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 21:58 ` Alexander Duyck
2016-06-13 20:03 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 20:03 ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 03/15] bnx2x: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 18:48 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 18:48 ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 18:41 ` [Intel-wired-lan] " Jesse Gross
2016-06-13 18:41 ` Jesse Gross
2016-06-13 19:14 ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 19:14 ` Hannes Frederic Sowa
2016-06-13 19:16 ` [Intel-wired-lan] " Alex Duyck
2016-06-13 19:16 ` Alex Duyck
2016-06-13 19:16 ` [Intel-wired-lan] " Michael Chan
2016-06-13 19:16 ` Michael Chan
2016-06-13 19:31 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 19:31 ` kbuild test robot
2016-06-13 19:45 ` kbuild test robot
2016-06-13 19:45 ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 05/15] benet: " Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 06/15] fm10k: " Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 07/15] i40e: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 08/15] ixgbe: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:48 ` Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck [this message]
2016-06-13 17:49 ` [net-next PATCH 09/15] mlx4_en: " Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 10/15] mlx5_en: " Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 11/15] nfp: " Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 12/15] qede: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 13/15] qlcnic: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 14/15] net: Remove deprecated tunnel specific UDP offload functions Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck
2016-06-13 17:50 ` [Intel-wired-lan] [net-next PATCH 15/15] vxlan: Add new UDP encapsulation offload type for VXLAN-GPE Alexander Duyck
2016-06-13 17:50 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613174912.15186.33016.stgit@localhost.localdomain \
--to=aduyck@mirantis.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.