All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Duyck <aduyck@mirantis.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net-next PATCH 14/15] net: Remove deprecated tunnel specific UDP offload functions
Date: Mon, 13 Jun 2016 10:49:58 -0700	[thread overview]
Message-ID: <20160613174958.15186.68608.stgit@localhost.localdomain> (raw)
In-Reply-To: <20160613173750.15186.24381.stgit@localhost.localdomain>

Now that we have all the drivers using udp_tunnel_get_rx_ports,
ndo_add_udp_enc_rx_port, and ndo_del_udp_enc_rx_port we can drop the
function calls that were specific to VXLAN and GENEVE.

Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
 include/linux/netdevice.h |   12 ------------
 include/net/geneve.h      |    5 -----
 include/net/vxlan.h       |    5 -----
 net/ipv4/udp_tunnel.c     |   41 ++---------------------------------------
 4 files changed, 2 insertions(+), 61 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e959b6348f91..ee3266d8aeaf 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1257,18 +1257,6 @@ struct net_device_ops {
 							struct netdev_phys_item_id *ppid);
 	int			(*ndo_get_phys_port_name)(struct net_device *dev,
 							  char *name, size_t len);
-	void			(*ndo_add_vxlan_port)(struct  net_device *dev,
-						      sa_family_t sa_family,
-						      __be16 port);
-	void			(*ndo_del_vxlan_port)(struct  net_device *dev,
-						      sa_family_t sa_family,
-						      __be16 port);
-	void			(*ndo_add_geneve_port)(struct  net_device *dev,
-						       sa_family_t sa_family,
-						       __be16 port);
-	void			(*ndo_del_geneve_port)(struct  net_device *dev,
-						       sa_family_t sa_family,
-						       __be16 port);
 	void			(*ndo_add_udp_enc_port)(struct  net_device *dev,
 						       sa_family_t sa_family,
 						       __be16 port,
diff --git a/include/net/geneve.h b/include/net/geneve.h
index 7638ec62c5e1..ec0327d4331b 100644
--- a/include/net/geneve.h
+++ b/include/net/geneve.h
@@ -59,11 +59,6 @@ struct genevehdr {
 	struct geneve_opt options[];
 };
 
-static inline void geneve_get_rx_port(struct net_device *netdev)
-{
-	udp_tunnel_get_rx_port(netdev);
-}
-
 #ifdef CONFIG_INET
 struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
 					u8 name_assign_type, u16 dst_port);
diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index 2c4f8fcd5a3b..a958cbea8676 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -393,11 +393,6 @@ static inline __be32 vxlan_compute_rco(unsigned int start, unsigned int offset)
 	return vni_field;
 }
 
-static inline void vxlan_get_rx_port(struct net_device *netdev)
-{
-	udp_tunnel_get_rx_port(netdev);
-}
-
 static inline unsigned short vxlan_get_sk_family(struct vxlan_sock *vs)
 {
 	return vs->sock->sk->sk_family;
diff --git a/net/ipv4/udp_tunnel.c b/net/ipv4/udp_tunnel.c
index a22677cd41d8..39dfe9e0e498 100644
--- a/net/ipv4/udp_tunnel.c
+++ b/net/ipv4/udp_tunnel.c
@@ -83,28 +83,10 @@ void udp_tunnel_push_rx_port(struct net_device *dev, struct socket *sock,
 	sa_family_t sa_family = sk->sk_family;
 	__be16 port = inet_sk(sk)->inet_sport;
 
-	if (dev->netdev_ops->ndo_add_udp_enc_port) {
+	if (dev->netdev_ops->ndo_add_udp_enc_port)
 		dev->netdev_ops->ndo_add_udp_enc_port(dev, sa_family,
 						      port, type);
-		return;
-	}
 
-	switch (type) {
-	case UDP_ENC_OFFLOAD_TYPE_VXLAN:
-		if (!dev->netdev_ops->ndo_add_vxlan_port)
-			break;
-
-		dev->netdev_ops->ndo_add_vxlan_port(dev, sa_family, port);
-		break;
-	case UDP_ENC_OFFLOAD_TYPE_GENEVE:
-		if (!dev->netdev_ops->ndo_add_geneve_port)
-			break;
-
-		dev->netdev_ops->ndo_add_geneve_port(dev, sa_family, port);
-		break;
-	default:
-		break;
-	}
 }
 EXPORT_SYMBOL_GPL(udp_tunnel_push_rx_port);
 
@@ -128,28 +110,9 @@ static void udp_tunnel_pull_rx_port(struct net_device *dev,
 	sa_family_t sa_family = sk->sk_family;
 	__be16 port = inet_sk(sk)->inet_sport;
 
-	if (dev->netdev_ops->ndo_del_udp_enc_port) {
+	if (dev->netdev_ops->ndo_del_udp_enc_port)
 		dev->netdev_ops->ndo_del_udp_enc_port(dev, sa_family,
 						      port, type);
-		return;
-	}
-
-	switch (type) {
-	case UDP_ENC_OFFLOAD_TYPE_VXLAN:
-		if (!dev->netdev_ops->ndo_del_vxlan_port)
-			break;
-
-		dev->netdev_ops->ndo_del_vxlan_port(dev, sa_family, port);
-		break;
-	case UDP_ENC_OFFLOAD_TYPE_GENEVE:
-		if (!dev->netdev_ops->ndo_del_geneve_port)
-			break;
-
-		dev->netdev_ops->ndo_del_geneve_port(dev, sa_family, port);
-		break;
-	default:
-		break;
-	}
 }
 
 /* Notify netdevs that UDP port is no more listening */


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <aduyck@mirantis.com>
To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Cc: hannes@redhat.com, jesse@kernel.org, jbenc@redhat.com,
	alexander.duyck@gmail.com, saeedm@mellanox.com,
	ariel.elior@qlogic.com, tom@herbertland.com,
	Dept-GELinuxNICDev@qlogic.com, davem@davemloft.net,
	eugenia@mellanox.com
Subject: [net-next PATCH 14/15] net: Remove deprecated tunnel specific UDP offload functions
Date: Mon, 13 Jun 2016 10:49:58 -0700	[thread overview]
Message-ID: <20160613174958.15186.68608.stgit@localhost.localdomain> (raw)
In-Reply-To: <20160613173750.15186.24381.stgit@localhost.localdomain>

Now that we have all the drivers using udp_tunnel_get_rx_ports,
ndo_add_udp_enc_rx_port, and ndo_del_udp_enc_rx_port we can drop the
function calls that were specific to VXLAN and GENEVE.

Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
 include/linux/netdevice.h |   12 ------------
 include/net/geneve.h      |    5 -----
 include/net/vxlan.h       |    5 -----
 net/ipv4/udp_tunnel.c     |   41 ++---------------------------------------
 4 files changed, 2 insertions(+), 61 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e959b6348f91..ee3266d8aeaf 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1257,18 +1257,6 @@ struct net_device_ops {
 							struct netdev_phys_item_id *ppid);
 	int			(*ndo_get_phys_port_name)(struct net_device *dev,
 							  char *name, size_t len);
-	void			(*ndo_add_vxlan_port)(struct  net_device *dev,
-						      sa_family_t sa_family,
-						      __be16 port);
-	void			(*ndo_del_vxlan_port)(struct  net_device *dev,
-						      sa_family_t sa_family,
-						      __be16 port);
-	void			(*ndo_add_geneve_port)(struct  net_device *dev,
-						       sa_family_t sa_family,
-						       __be16 port);
-	void			(*ndo_del_geneve_port)(struct  net_device *dev,
-						       sa_family_t sa_family,
-						       __be16 port);
 	void			(*ndo_add_udp_enc_port)(struct  net_device *dev,
 						       sa_family_t sa_family,
 						       __be16 port,
diff --git a/include/net/geneve.h b/include/net/geneve.h
index 7638ec62c5e1..ec0327d4331b 100644
--- a/include/net/geneve.h
+++ b/include/net/geneve.h
@@ -59,11 +59,6 @@ struct genevehdr {
 	struct geneve_opt options[];
 };
 
-static inline void geneve_get_rx_port(struct net_device *netdev)
-{
-	udp_tunnel_get_rx_port(netdev);
-}
-
 #ifdef CONFIG_INET
 struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
 					u8 name_assign_type, u16 dst_port);
diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index 2c4f8fcd5a3b..a958cbea8676 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -393,11 +393,6 @@ static inline __be32 vxlan_compute_rco(unsigned int start, unsigned int offset)
 	return vni_field;
 }
 
-static inline void vxlan_get_rx_port(struct net_device *netdev)
-{
-	udp_tunnel_get_rx_port(netdev);
-}
-
 static inline unsigned short vxlan_get_sk_family(struct vxlan_sock *vs)
 {
 	return vs->sock->sk->sk_family;
diff --git a/net/ipv4/udp_tunnel.c b/net/ipv4/udp_tunnel.c
index a22677cd41d8..39dfe9e0e498 100644
--- a/net/ipv4/udp_tunnel.c
+++ b/net/ipv4/udp_tunnel.c
@@ -83,28 +83,10 @@ void udp_tunnel_push_rx_port(struct net_device *dev, struct socket *sock,
 	sa_family_t sa_family = sk->sk_family;
 	__be16 port = inet_sk(sk)->inet_sport;
 
-	if (dev->netdev_ops->ndo_add_udp_enc_port) {
+	if (dev->netdev_ops->ndo_add_udp_enc_port)
 		dev->netdev_ops->ndo_add_udp_enc_port(dev, sa_family,
 						      port, type);
-		return;
-	}
 
-	switch (type) {
-	case UDP_ENC_OFFLOAD_TYPE_VXLAN:
-		if (!dev->netdev_ops->ndo_add_vxlan_port)
-			break;
-
-		dev->netdev_ops->ndo_add_vxlan_port(dev, sa_family, port);
-		break;
-	case UDP_ENC_OFFLOAD_TYPE_GENEVE:
-		if (!dev->netdev_ops->ndo_add_geneve_port)
-			break;
-
-		dev->netdev_ops->ndo_add_geneve_port(dev, sa_family, port);
-		break;
-	default:
-		break;
-	}
 }
 EXPORT_SYMBOL_GPL(udp_tunnel_push_rx_port);
 
@@ -128,28 +110,9 @@ static void udp_tunnel_pull_rx_port(struct net_device *dev,
 	sa_family_t sa_family = sk->sk_family;
 	__be16 port = inet_sk(sk)->inet_sport;
 
-	if (dev->netdev_ops->ndo_del_udp_enc_port) {
+	if (dev->netdev_ops->ndo_del_udp_enc_port)
 		dev->netdev_ops->ndo_del_udp_enc_port(dev, sa_family,
 						      port, type);
-		return;
-	}
-
-	switch (type) {
-	case UDP_ENC_OFFLOAD_TYPE_VXLAN:
-		if (!dev->netdev_ops->ndo_del_vxlan_port)
-			break;
-
-		dev->netdev_ops->ndo_del_vxlan_port(dev, sa_family, port);
-		break;
-	case UDP_ENC_OFFLOAD_TYPE_GENEVE:
-		if (!dev->netdev_ops->ndo_del_geneve_port)
-			break;
-
-		dev->netdev_ops->ndo_del_geneve_port(dev, sa_family, port);
-		break;
-	default:
-		break;
-	}
 }
 
 /* Notify netdevs that UDP port is no more listening */

  parent reply	other threads:[~2016-06-13 17:49 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 17:47 [Intel-wired-lan] [net-next PATCH 00/15] Future-proof tunnel offload handlers Alexander Duyck
2016-06-13 17:47 ` Alexander Duyck
2016-06-13 17:47 ` [Intel-wired-lan] [net-next PATCH 01/15] net: Combine GENEVE and VXLAN port offload notifiers into single functions Alexander Duyck
2016-06-13 17:47   ` Alexander Duyck
2016-06-13 19:55   ` [Intel-wired-lan] " Tom Herbert
2016-06-13 19:55     ` Tom Herbert
2016-06-13 20:24     ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 20:24       ` Alexander Duyck
2016-06-13 20:36       ` [Intel-wired-lan] " Tom Herbert
2016-06-13 20:36         ` Tom Herbert
2016-06-13 21:51         ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 21:51           ` Alexander Duyck
2016-06-13 22:17           ` [Intel-wired-lan] " Tom Herbert
2016-06-13 22:17             ` Tom Herbert
2016-06-13 23:12             ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 23:12               ` Alexander Duyck
2016-06-14  0:28               ` [Intel-wired-lan] " Tom Herbert
2016-06-14  0:28                 ` Tom Herbert
2016-06-14  2:50                 ` [Intel-wired-lan] " Alexander Duyck
2016-06-14  2:50                   ` Alexander Duyck
2016-06-14  3:13                   ` [Intel-wired-lan] " Tom Herbert
2016-06-15  7:22                   ` David Miller
2016-06-15  7:22                     ` David Miller
2016-06-15 16:12                     ` [Intel-wired-lan] " Tom Herbert
2016-06-15 16:12                       ` Tom Herbert
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 02/15] net: Merge VXLAN and GENEVE push notifiers into a single notifier Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 17:57   ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 17:57     ` Hannes Frederic Sowa
2016-06-13 19:31     ` [Intel-wired-lan] " Tom Herbert
2016-06-13 19:31       ` Tom Herbert
2016-06-13 19:47     ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 19:47       ` Alexander Duyck
2016-06-13 21:08       ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 21:08         ` Hannes Frederic Sowa
2016-06-13 21:58         ` [Intel-wired-lan] " Alexander Duyck
2016-06-13 21:58           ` Alexander Duyck
2016-06-13 20:03   ` [Intel-wired-lan] " kbuild test robot
2016-06-13 20:03     ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 03/15] bnx2x: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 18:48   ` [Intel-wired-lan] " kbuild test robot
2016-06-13 18:48     ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 18:41   ` [Intel-wired-lan] " Jesse Gross
2016-06-13 18:41     ` Jesse Gross
2016-06-13 19:14     ` [Intel-wired-lan] " Hannes Frederic Sowa
2016-06-13 19:14       ` Hannes Frederic Sowa
2016-06-13 19:16       ` [Intel-wired-lan] " Alex Duyck
2016-06-13 19:16         ` Alex Duyck
2016-06-13 19:16     ` [Intel-wired-lan] " Michael Chan
2016-06-13 19:16       ` Michael Chan
2016-06-13 19:31   ` [Intel-wired-lan] " kbuild test robot
2016-06-13 19:31     ` kbuild test robot
2016-06-13 19:45   ` kbuild test robot
2016-06-13 19:45     ` kbuild test robot
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 05/15] benet: " Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 06/15] fm10k: " Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 07/15] i40e: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 17:48 ` [Intel-wired-lan] [net-next PATCH 08/15] ixgbe: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:48   ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 09/15] mlx4_en: " Alexander Duyck
2016-06-13 17:49   ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 10/15] mlx5_en: " Alexander Duyck
2016-06-13 17:49   ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 11/15] nfp: " Alexander Duyck
2016-06-13 17:49   ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 12/15] qede: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:49   ` Alexander Duyck
2016-06-13 17:49 ` [Intel-wired-lan] [net-next PATCH 13/15] qlcnic: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:49   ` Alexander Duyck
2016-06-13 17:49 ` Alexander Duyck [this message]
2016-06-13 17:49   ` [net-next PATCH 14/15] net: Remove deprecated tunnel specific UDP offload functions Alexander Duyck
2016-06-13 17:50 ` [Intel-wired-lan] [net-next PATCH 15/15] vxlan: Add new UDP encapsulation offload type for VXLAN-GPE Alexander Duyck
2016-06-13 17:50   ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613174958.15186.68608.stgit@localhost.localdomain \
    --to=aduyck@mirantis.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.