From: marcelo.leitner@gmail.com
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, vyasevich@gmail.com,
daniel@iogearbox.net, xiaolong.ye@intel.com,
eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate
Date: Thu, 16 Jun 2016 21:13:22 +0000 [thread overview]
Message-ID: <20160616211322.GW22680@localhost.localdomain> (raw)
In-Reply-To: <20160616.141139.1258089118185183298.davem@davemloft.net>
On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Thu, 16 Jun 2016 01:15:06 +0800
>
> > Commit d46e416c11c8 ("sctp: sctp should change socket state when
> > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate,
> > but inet_accept doesn't allow the sk_state other than ESTABLISHED/
> > CLOSED for sctp. So we will change sk_state to CLOSED, instead of
> > CLOSING, as actually sk is closed already there.
> >
> > Fixes: commit d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received")
> > Reported-by: Ye Xiaolong <xiaolong.ye@intel.com>
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Applied.
I thought Xin was going to post a version with that tag Fixed, but ok.
Patch is good to me, fwiw.
WARNING: multiple messages have this Message-ID (diff)
From: marcelo.leitner@gmail.com
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, vyasevich@gmail.com,
daniel@iogearbox.net, xiaolong.ye@intel.com,
eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate
Date: Thu, 16 Jun 2016 18:13:22 -0300 [thread overview]
Message-ID: <20160616211322.GW22680@localhost.localdomain> (raw)
In-Reply-To: <20160616.141139.1258089118185183298.davem@davemloft.net>
On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Thu, 16 Jun 2016 01:15:06 +0800
>
> > Commit d46e416c11c8 ("sctp: sctp should change socket state when
> > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate,
> > but inet_accept doesn't allow the sk_state other than ESTABLISHED/
> > CLOSED for sctp. So we will change sk_state to CLOSED, instead of
> > CLOSING, as actually sk is closed already there.
> >
> > Fixes: commit d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received")
> > Reported-by: Ye Xiaolong <xiaolong.ye@intel.com>
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Applied.
I thought Xin was going to post a version with that tag Fixed, but ok.
Patch is good to me, fwiw.
next prev parent reply other threads:[~2016-06-16 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 17:15 [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate Xin Long
2016-06-15 17:15 ` Xin Long
2016-06-15 19:20 ` Sergei Shtylyov
2016-06-15 19:20 ` Sergei Shtylyov
2016-06-16 21:11 ` David Miller
2016-06-16 21:11 ` David Miller
2016-06-16 21:13 ` marcelo.leitner [this message]
2016-06-16 21:13 ` marcelo.leitner
2016-06-16 21:26 ` David Miller
2016-06-16 21:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616211322.GW22680@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.