All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, john@phrozen.org
Subject: Re: [PATCH v3 8/8] MTD: xway: add missing write_buf and read_buf to nand driver
Date: Sun, 19 Jun 2016 18:32:45 +0200	[thread overview]
Message-ID: <20160619183245.5e8b0005@bbrezillon> (raw)
In-Reply-To: <1466352497-6806-9-git-send-email-hauke@hauke-m.de>

On Sun, 19 Jun 2016 18:08:17 +0200
Hauke Mehrtens <hauke@hauke-m.de> wrote:

Still no descriptions...

> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  drivers/mtd/nand/xway_nand.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> index 282258f..8f208cb 100644
> --- a/drivers/mtd/nand/xway_nand.c
> +++ b/drivers/mtd/nand/xway_nand.c
> @@ -130,6 +130,22 @@ static unsigned char xway_read_byte(struct mtd_info *mtd)
>  	return xway_readb(mtd, NAND_READ_DATA);
>  }
>  
> +static void xway_read_buf(struct mtd_info *mtd, u_char *buf, int len)
> +{
> +	int i;
> +
> +	for (i = 0; i < len; i++)
> +		buf[i] = xway_readb(mtd, NAND_WRITE_DATA);
> +}
> +
> +static void xway_write_buf(struct mtd_info *mtd, const u_char *buf, int len)
> +{
> +	int i;
> +
> +	for (i = 0; i < len; i++)
> +		xway_writeb(mtd, NAND_WRITE_DATA, buf[i]);
> +}
> +
>  /*
>   * Probe for the NAND device.
>   */
> @@ -162,6 +178,8 @@ static int xway_nand_probe(struct platform_device *pdev)
>  	data->chip.cmd_ctrl = xway_cmd_ctrl;
>  	data->chip.dev_ready = xway_dev_ready;
>  	data->chip.select_chip = xway_select_chip;
> +	data->chip.write_buf = xway_write_buf;
> +	data->chip.read_buf = xway_read_buf;
>  	data->chip.read_byte = xway_read_byte;
>  	data->chip.chip_delay = 30;
>  

      reply	other threads:[~2016-06-19 16:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-19 16:08 [PATCH v3 0/8] MTD: xway: fix driver Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 1/8] MTD: xway: add some more documentation Hauke Mehrtens
2016-06-19 16:14   ` Boris Brezillon
2016-06-19 16:32     ` Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 2/8] MTD: xway: convert to normal platform driver Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 3/8] MTD: xway: the latched command should be persistent Hauke Mehrtens
2016-06-19 16:22   ` Boris Brezillon
2016-06-19 16:08 ` [PATCH v3 4/8] MTD: xway: use generic reset function Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 5/8] MTD: xway: fix nand locking Hauke Mehrtens
2016-06-19 16:26   ` Boris Brezillon
2016-06-19 16:34     ` Hauke Mehrtens
2016-06-19 16:40       ` Boris Brezillon
2016-06-19 16:08 ` [PATCH v3 6/8] MTD: xway: extract read and write function Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 7/8] MTD: xway: add nandaddr to own struct Hauke Mehrtens
2016-06-19 16:29   ` Boris Brezillon
2016-06-19 16:32     ` Boris Brezillon
2016-06-19 16:35       ` Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 8/8] MTD: xway: add missing write_buf and read_buf to nand driver Hauke Mehrtens
2016-06-19 16:32   ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160619183245.5e8b0005@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.