From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, john@phrozen.org
Subject: Re: [PATCH v3 5/8] MTD: xway: fix nand locking
Date: Sun, 19 Jun 2016 18:40:27 +0200 [thread overview]
Message-ID: <20160619184027.4da93d3a@bbrezillon> (raw)
In-Reply-To: <9936f935-bf7f-83b8-c7f6-5631f9e68c01@hauke-m.de>
On Sun, 19 Jun 2016 18:34:30 +0200
Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >> @@ -113,14 +115,8 @@ static unsigned char xway_read_byte(struct mtd_info *mtd)
> >> {
> >> struct nand_chip *this = mtd_to_nand(mtd);
> >> unsigned long nandaddr = (unsigned long) this->IO_ADDR_R;
> >> - unsigned long flags;
> >> - int ret;
> >>
> >> - spin_lock_irqsave(&ebu_lock, flags);
> >> - ret = ltq_r8((void __iomem *)(nandaddr + NAND_READ_DATA));
> >> - spin_unlock_irqrestore(&ebu_lock, flags);
> >> -
> >> - return ret;
> >> + return ltq_r8((void __iomem *)(nandaddr + NAND_READ_DATA));
> >
> > Drop the cast and use this->IO_ADDR_R here.
>
> This will be done in the following patch, here I am only chaining the
> locking.
My bad, you're right.
next prev parent reply other threads:[~2016-06-19 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 16:08 [PATCH v3 0/8] MTD: xway: fix driver Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 1/8] MTD: xway: add some more documentation Hauke Mehrtens
2016-06-19 16:14 ` Boris Brezillon
2016-06-19 16:32 ` Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 2/8] MTD: xway: convert to normal platform driver Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 3/8] MTD: xway: the latched command should be persistent Hauke Mehrtens
2016-06-19 16:22 ` Boris Brezillon
2016-06-19 16:08 ` [PATCH v3 4/8] MTD: xway: use generic reset function Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 5/8] MTD: xway: fix nand locking Hauke Mehrtens
2016-06-19 16:26 ` Boris Brezillon
2016-06-19 16:34 ` Hauke Mehrtens
2016-06-19 16:40 ` Boris Brezillon [this message]
2016-06-19 16:08 ` [PATCH v3 6/8] MTD: xway: extract read and write function Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 7/8] MTD: xway: add nandaddr to own struct Hauke Mehrtens
2016-06-19 16:29 ` Boris Brezillon
2016-06-19 16:32 ` Boris Brezillon
2016-06-19 16:35 ` Hauke Mehrtens
2016-06-19 16:08 ` [PATCH v3 8/8] MTD: xway: add missing write_buf and read_buf to nand driver Hauke Mehrtens
2016-06-19 16:32 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160619184027.4da93d3a@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.