All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Mon, 27 Jun 2016 10:09:34 +0200	[thread overview]
Message-ID: <20160627080934.GS4000@lukather> (raw)
In-Reply-To: <57701053.9090903@gmail.com>

On Sun, Jun 26, 2016 at 10:26:43AM -0700, Florian Fainelli wrote:
> Le 26/06/2016 01:05, Maxime Ripard a ?crit :
> > Hi Florian,
> > 
> > On Sat, Jun 25, 2016 at 07:59:23PM -0700, Florian Fainelli wrote:
> >> Le 23/06/2016 22:48, Chen-Yu Tsai a ?crit :
> >>>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> index 5ee43d8bf174..697582397dcf 100644
> >>>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> @@ -110,13 +110,67 @@
> >>>>  &gmac {
> >>>>         pinctrl-names = "default";
> >>>>         pinctrl-0 = <&gmac_pins_rgmii_a>;
> >>>> -       phy = <&phy1>;
> >>>>         phy-mode = "rgmii";
> >>>>         phy-supply = <&reg_gmac_3v3>;
> >>>>         status = "okay";
> >>>>
> >>>> -       phy1: ethernet-phy at 1 {
> >>>> -               reg = <1>;
> >>>> +       fixed-link {
> >>>> +               speed = <1000>;
> >>>> +               full-duplex;
> >>>> +       };
> >>>> +
> >>>> +       mdio1 {
> >>>
> >>> mdio will suffice.
> >>
> >> There is another label in sun7i-a20.dtsi named mdio which is for the
> >> MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
> >> one we want here, we want the MDIO controller associated with the
> >> Synopsys GMAC.
> > 
> > Yes, but it's in a different node, and you're not using any labels, so
> > I don't really see how that would conflict.
> 
> Fair enough, I sent a v2 which uses "mdio-gmac" as a label, should I
> respin a v3 which just uses "mdio"?

Yes, please do, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160627/a5cbbb7b/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Mon, 27 Jun 2016 10:09:34 +0200	[thread overview]
Message-ID: <20160627080934.GS4000@lukather> (raw)
In-Reply-To: <57701053.9090903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

On Sun, Jun 26, 2016 at 10:26:43AM -0700, Florian Fainelli wrote:
> Le 26/06/2016 01:05, Maxime Ripard a écrit :
> > Hi Florian,
> > 
> > On Sat, Jun 25, 2016 at 07:59:23PM -0700, Florian Fainelli wrote:
> >> Le 23/06/2016 22:48, Chen-Yu Tsai a écrit :
> >>>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> index 5ee43d8bf174..697582397dcf 100644
> >>>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >>>> @@ -110,13 +110,67 @@
> >>>>  &gmac {
> >>>>         pinctrl-names = "default";
> >>>>         pinctrl-0 = <&gmac_pins_rgmii_a>;
> >>>> -       phy = <&phy1>;
> >>>>         phy-mode = "rgmii";
> >>>>         phy-supply = <&reg_gmac_3v3>;
> >>>>         status = "okay";
> >>>>
> >>>> -       phy1: ethernet-phy@1 {
> >>>> -               reg = <1>;
> >>>> +       fixed-link {
> >>>> +               speed = <1000>;
> >>>> +               full-duplex;
> >>>> +       };
> >>>> +
> >>>> +       mdio1 {
> >>>
> >>> mdio will suffice.
> >>
> >> There is another label in sun7i-a20.dtsi named mdio which is for the
> >> MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
> >> one we want here, we want the MDIO controller associated with the
> >> Synopsys GMAC.
> > 
> > Yes, but it's in a different node, and you're not using any labels, so
> > I don't really see how that would conflict.
> 
> Fair enough, I sent a v2 which uses "mdio-gmac" as a label, should I
> respin a v3 which just uses "mdio"?

Yes, please do, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-27  8:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  0:14 [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes Florian Fainelli
2016-06-12  0:14 ` Florian Fainelli
2016-06-12  0:14 ` Florian Fainelli
2016-06-12  0:14   ` Florian Fainelli
2016-06-24  5:48   ` Chen-Yu Tsai
2016-06-24  5:48     ` Chen-Yu Tsai
2016-06-24  5:51     ` Chen-Yu Tsai
2016-06-24  5:51       ` Chen-Yu Tsai
2016-06-26  2:59     ` Florian Fainelli
2016-06-26  2:59       ` Florian Fainelli
2016-06-26  8:05       ` Maxime Ripard
2016-06-26  8:05         ` Maxime Ripard
2016-06-26 17:26         ` Florian Fainelli
2016-06-26 17:26           ` Florian Fainelli
2016-06-27  8:09           ` Maxime Ripard [this message]
2016-06-27  8:09             ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627080934.GS4000@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.