All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Sat, 25 Jun 2016 19:59:23 -0700	[thread overview]
Message-ID: <576F450B.3080207@gmail.com> (raw)
In-Reply-To: <CAGb2v64u74cXG0R-MSMtDBxBpg2tFoifQwqbvWL-+3pG=GLVTQ@mail.gmail.com>

Le 23/06/2016 22:48, Chen-Yu Tsai a ?crit :
>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> index 5ee43d8bf174..697582397dcf 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> @@ -110,13 +110,67 @@
>>  &gmac {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&gmac_pins_rgmii_a>;
>> -       phy = <&phy1>;
>>         phy-mode = "rgmii";
>>         phy-supply = <&reg_gmac_3v3>;
>>         status = "okay";
>>
>> -       phy1: ethernet-phy at 1 {
>> -               reg = <1>;
>> +       fixed-link {
>> +               speed = <1000>;
>> +               full-duplex;
>> +       };
>> +
>> +       mdio1 {
> 
> mdio will suffice.

There is another label in sun7i-a20.dtsi named mdio which is for the
MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
one we want here, we want the MDIO controller associated with the
Synopsys GMAC.

> 
>> +               compatible = "snps,dwmac-mdio";
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +
>> +               switch: ethernet-switch at 30 {
> 
> 30 decimal or 0x30 hex? We typically use hex values here.

30 decimal, will fix that.
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Sat, 25 Jun 2016 19:59:23 -0700	[thread overview]
Message-ID: <576F450B.3080207@gmail.com> (raw)
In-Reply-To: <CAGb2v64u74cXG0R-MSMtDBxBpg2tFoifQwqbvWL-+3pG=GLVTQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Le 23/06/2016 22:48, Chen-Yu Tsai a écrit :
>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> index 5ee43d8bf174..697582397dcf 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> @@ -110,13 +110,67 @@
>>  &gmac {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&gmac_pins_rgmii_a>;
>> -       phy = <&phy1>;
>>         phy-mode = "rgmii";
>>         phy-supply = <&reg_gmac_3v3>;
>>         status = "okay";
>>
>> -       phy1: ethernet-phy@1 {
>> -               reg = <1>;
>> +       fixed-link {
>> +               speed = <1000>;
>> +               full-duplex;
>> +       };
>> +
>> +       mdio1 {
> 
> mdio will suffice.

There is another label in sun7i-a20.dtsi named mdio which is for the
MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
one we want here, we want the MDIO controller associated with the
Synopsys GMAC.

> 
>> +               compatible = "snps,dwmac-mdio";
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +
>> +               switch: ethernet-switch@30 {
> 
> 30 decimal or 0x30 hex? We typically use hex values here.

30 decimal, will fix that.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-06-26  2:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  0:14 [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes Florian Fainelli
2016-06-12  0:14 ` Florian Fainelli
2016-06-12  0:14 ` Florian Fainelli
2016-06-12  0:14   ` Florian Fainelli
2016-06-24  5:48   ` Chen-Yu Tsai
2016-06-24  5:48     ` Chen-Yu Tsai
2016-06-24  5:51     ` Chen-Yu Tsai
2016-06-24  5:51       ` Chen-Yu Tsai
2016-06-26  2:59     ` Florian Fainelli [this message]
2016-06-26  2:59       ` Florian Fainelli
2016-06-26  8:05       ` Maxime Ripard
2016-06-26  8:05         ` Maxime Ripard
2016-06-26 17:26         ` Florian Fainelli
2016-06-26 17:26           ` Florian Fainelli
2016-06-27  8:09           ` Maxime Ripard
2016-06-27  8:09             ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576F450B.3080207@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.