From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Vladimir Davydov <vdavydov@parallels.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix
Date: Wed, 29 Jun 2016 21:22:33 +0200 [thread overview]
Message-ID: <20160629192232.GA19097@redhat.com> (raw)
In-Reply-To: <1467201562-6709-1-git-send-email-mhocko@kernel.org>
On 06/29, Michal Hocko wrote:
>
> But it seems that further changes I am
> planning in this area will benefit from stable task->mm in this path
Oh, so I hope you will cleanup this later,
> Just pull the task->mm !=
> NULL check inside the function.
OK, but this means it will always return false if the task is a zombie
leader.
I am not really arguing and this is not that bad, but this doesn't look
nice and imo asks for cleanup.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Vladimir Davydov <vdavydov@parallels.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix
Date: Wed, 29 Jun 2016 21:22:33 +0200 [thread overview]
Message-ID: <20160629192232.GA19097@redhat.com> (raw)
In-Reply-To: <1467201562-6709-1-git-send-email-mhocko@kernel.org>
On 06/29, Michal Hocko wrote:
>
> But it seems that further changes I am
> planning in this area will benefit from stable task->mm in this path
Oh, so I hope you will cleanup this later,
> Just pull the task->mm !=
> NULL check inside the function.
OK, but this means it will always return false if the task is a zombie
leader.
I am not really arguing and this is not that bad, but this doesn't look
nice and imo asks for cleanup.
Oleg.
next prev parent reply other threads:[~2016-06-29 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 11:59 [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Michal Hocko
2016-06-29 11:59 ` Michal Hocko
2016-06-29 19:22 ` Oleg Nesterov [this message]
2016-06-29 19:22 ` Oleg Nesterov
2016-06-30 8:19 ` Michal Hocko
2016-06-30 8:19 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629192232.GA19097@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.