From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: y2038@lists.linaro.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jan Kara <jack@suse.com>
Subject: Re: [PATCH] jbd2: make journal y2038 safe
Date: Thu, 30 Jun 2016 11:49:38 -0400 [thread overview]
Message-ID: <20160630154938.GG2028@thunk.org> (raw)
In-Reply-To: <20160619155347.GB2734@quack2.suse.cz>
On Sun, Jun 19, 2016 at 05:53:47PM +0200, Jan Kara wrote:
> On Fri 17-06-16 17:39:00, Arnd Bergmann wrote:
> > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
> > nanoseconds, which avoids an overflow in 2038, but it gets the numbers
> > from current_kernel_time(), which uses 'long' seconds on 32-bit
> > architectures.
> >
> > This simply changes the code to call current_kernel_time64() so
> > we use 64-bit seconds consistently.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Arnd Bergmann <arnd@arndb.de>, Jan Kara <jack@suse.com>,
y2038@lists.linaro.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: make journal y2038 safe
Date: Thu, 30 Jun 2016 11:49:38 -0400 [thread overview]
Message-ID: <20160630154938.GG2028@thunk.org> (raw)
In-Reply-To: <20160619155347.GB2734@quack2.suse.cz>
On Sun, Jun 19, 2016 at 05:53:47PM +0200, Jan Kara wrote:
> On Fri 17-06-16 17:39:00, Arnd Bergmann wrote:
> > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
> > nanoseconds, which avoids an overflow in 2038, but it gets the numbers
> > from current_kernel_time(), which uses 'long' seconds on 32-bit
> > architectures.
> >
> > This simply changes the code to call current_kernel_time64() so
> > we use 64-bit seconds consistently.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2016-06-30 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:39 [PATCH] jbd2: make journal y2038 safe Arnd Bergmann
2016-06-17 15:39 ` Arnd Bergmann
2016-06-19 15:53 ` Jan Kara
2016-06-19 15:53 ` Jan Kara
2016-06-30 15:49 ` Theodore Ts'o [this message]
2016-06-30 15:49 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630154938.GG2028@thunk.org \
--to=tytso@mit.edu \
--cc=arnd@arndb.de \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.