All of lore.kernel.org
 help / color / mirror / Atom feed
From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] bus: brcmstb_gisb: make it explicitly non-modular
Date: Sun, 3 Jul 2016 13:30:37 -0400	[thread overview]
Message-ID: <20160703173040.23612-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160703173040.23612-1-paul.gortmaker@windriver.com>

The Kconfig for this driver is currently:

config BRCMSTB_GISB_ARB
        bool "Broadcom STB GISB bus arbiter"

...meaning that it currently is not being built as a module by anyone.
Lets remove all modular references, so that when reading the driver
there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

Cc: Brian Norris <computersforpeace@gmail.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/bus/brcmstb_gisb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 72fe0a5a8bf3..2616d8208777 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -13,7 +13,6 @@
 
 #include <linux/init.h>
 #include <linux/types.h>
-#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/sysfs.h>
@@ -438,5 +437,4 @@ static int __init brcm_gisb_driver_init(void)
 	return platform_driver_probe(&brcmstb_gisb_arb_driver,
 				     brcmstb_gisb_arb_probe);
 }
-
-module_init(brcm_gisb_driver_init);
+device_initcall(brcm_gisb_driver_init);
-- 
2.8.4

WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 1/4] bus: brcmstb_gisb: make it explicitly non-modular
Date: Sun, 3 Jul 2016 13:30:37 -0400	[thread overview]
Message-ID: <20160703173040.23612-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160703173040.23612-1-paul.gortmaker@windriver.com>

The Kconfig for this driver is currently:

config BRCMSTB_GISB_ARB
        bool "Broadcom STB GISB bus arbiter"

...meaning that it currently is not being built as a module by anyone.
Lets remove all modular references, so that when reading the driver
there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

Cc: Brian Norris <computersforpeace@gmail.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/bus/brcmstb_gisb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 72fe0a5a8bf3..2616d8208777 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -13,7 +13,6 @@
 
 #include <linux/init.h>
 #include <linux/types.h>
-#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/sysfs.h>
@@ -438,5 +437,4 @@ static int __init brcm_gisb_driver_init(void)
 	return platform_driver_probe(&brcmstb_gisb_arb_driver,
 				     brcmstb_gisb_arb_probe);
 }
-
-module_init(brcm_gisb_driver_init);
+device_initcall(brcm_gisb_driver_init);
-- 
2.8.4

  reply	other threads:[~2016-07-03 17:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 17:30 [PATCH v2 0/4] bus: remove unused modular code from non-modular drivers Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker [this message]
2016-07-03 17:30   ` [PATCH 1/4] bus: brcmstb_gisb: make it explicitly non-modular Paul Gortmaker
2016-07-14 22:34   ` Florian Fainelli
2016-07-14 22:34     ` Florian Fainelli
2016-07-03 17:30 ` [PATCH 2/4] bus: imx-weim: " Paul Gortmaker
2016-07-03 17:30   ` Paul Gortmaker
     [not found] ` <20160703173040.23612-1-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-07-03 17:30   ` [PATCH 3/4] bus: tegra-aconnect: " Paul Gortmaker
2016-07-03 17:30     ` Paul Gortmaker
2016-07-03 17:30     ` Paul Gortmaker
2016-07-04  9:17     ` Jon Hunter
2016-07-04  9:17       ` Jon Hunter
2016-07-04  9:17       ` Jon Hunter
2016-07-04 13:41       ` Paul Gortmaker
2016-07-04 13:41         ` Paul Gortmaker
2016-07-04 13:41         ` Paul Gortmaker
     [not found]         ` <20160704134123.GV26134-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-07-04 13:47           ` Jon Hunter
2016-07-04 13:47             ` Jon Hunter
2016-07-04 13:47             ` Jon Hunter
2016-07-03 17:30 ` [PATCH 4/4] bus: simple-pm-bus: convert bool SIMPLE_PM_BUS to tristate Paul Gortmaker
2016-07-03 17:30   ` Paul Gortmaker
2016-07-04 14:18   ` Geert Uytterhoeven
2016-07-04 14:18     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160703173040.23612-2-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.