From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] bus: imx-weim: make it explicitly non-modular
Date: Sun, 3 Jul 2016 13:30:38 -0400 [thread overview]
Message-ID: <20160703173040.23612-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160703173040.23612-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/bus/Kconfig:config IMX_WEIM
drivers/bus/Kconfig: bool "Freescale EIM DRIVER
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Alison Chaiken <alison_chaiken@mentor.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/bus/imx-weim.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 4bd361d64270..cdc75b1b264d 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -7,7 +7,7 @@
* License version 2. This program is licensed "as is" without any
* warranty of any kind, whether express or implied.
*/
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
@@ -57,7 +57,6 @@ static const struct of_device_id weim_id_table[] = {
{ .compatible = "fsl,imx51-weim", .data = &imx51_weim_devtype, },
{ }
};
-MODULE_DEVICE_TABLE(of, weim_id_table);
static int __init imx_weim_gpr_setup(struct platform_device *pdev)
{
@@ -209,8 +208,4 @@ static struct platform_driver weim_driver = {
.of_match_table = weim_id_table,
},
};
-module_platform_driver_probe(weim_driver, weim_probe);
-
-MODULE_AUTHOR("Freescale Semiconductor Inc.");
-MODULE_DESCRIPTION("i.MX EIM Controller Driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver_probe(weim_driver, weim_probe);
--
2.8.4
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Shawn Guo <shawn.guo@linaro.org>,
Alison Chaiken <alison_chaiken@mentor.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Wolfram Sang <wsa@the-dreams.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 2/4] bus: imx-weim: make it explicitly non-modular
Date: Sun, 3 Jul 2016 13:30:38 -0400 [thread overview]
Message-ID: <20160703173040.23612-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160703173040.23612-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/bus/Kconfig:config IMX_WEIM
drivers/bus/Kconfig: bool "Freescale EIM DRIVER
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Alison Chaiken <alison_chaiken@mentor.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/bus/imx-weim.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 4bd361d64270..cdc75b1b264d 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -7,7 +7,7 @@
* License version 2. This program is licensed "as is" without any
* warranty of any kind, whether express or implied.
*/
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
@@ -57,7 +57,6 @@ static const struct of_device_id weim_id_table[] = {
{ .compatible = "fsl,imx51-weim", .data = &imx51_weim_devtype, },
{ }
};
-MODULE_DEVICE_TABLE(of, weim_id_table);
static int __init imx_weim_gpr_setup(struct platform_device *pdev)
{
@@ -209,8 +208,4 @@ static struct platform_driver weim_driver = {
.of_match_table = weim_id_table,
},
};
-module_platform_driver_probe(weim_driver, weim_probe);
-
-MODULE_AUTHOR("Freescale Semiconductor Inc.");
-MODULE_DESCRIPTION("i.MX EIM Controller Driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver_probe(weim_driver, weim_probe);
--
2.8.4
next prev parent reply other threads:[~2016-07-03 17:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 17:30 [PATCH v2 0/4] bus: remove unused modular code from non-modular drivers Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-03 17:30 ` [PATCH 1/4] bus: brcmstb_gisb: make it explicitly non-modular Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-14 22:34 ` Florian Fainelli
2016-07-14 22:34 ` Florian Fainelli
2016-07-03 17:30 ` Paul Gortmaker [this message]
2016-07-03 17:30 ` [PATCH 2/4] bus: imx-weim: " Paul Gortmaker
[not found] ` <20160703173040.23612-1-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-07-03 17:30 ` [PATCH 3/4] bus: tegra-aconnect: " Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-04 9:17 ` Jon Hunter
2016-07-04 9:17 ` Jon Hunter
2016-07-04 9:17 ` Jon Hunter
2016-07-04 13:41 ` Paul Gortmaker
2016-07-04 13:41 ` Paul Gortmaker
2016-07-04 13:41 ` Paul Gortmaker
[not found] ` <20160704134123.GV26134-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-07-04 13:47 ` Jon Hunter
2016-07-04 13:47 ` Jon Hunter
2016-07-04 13:47 ` Jon Hunter
2016-07-03 17:30 ` [PATCH 4/4] bus: simple-pm-bus: convert bool SIMPLE_PM_BUS to tristate Paul Gortmaker
2016-07-03 17:30 ` Paul Gortmaker
2016-07-04 14:18 ` Geert Uytterhoeven
2016-07-04 14:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703173040.23612-3-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.