From: "Bruno Prémont" <bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Michael Haas
<michael.haas-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org>,
Wens <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/4] power: add axp20x-battery driver
Date: Tue, 5 Jul 2016 14:43:17 +0200 [thread overview]
Message-ID: <20160705144317.4a654376@pluto.restena.lu> (raw)
In-Reply-To: <112861467708458-tvSLaYVQeptuio3avFS2gg@public.gmane.org>
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote:
> I read the datasheet of axp20x, and then found that this driver does
> not support backup RTC battery.
> (But maybe backup battery do not need a driver -- at least on IBM PC
> it has no driver)
A driver is needed to enable/disable the RTC battery charging (unless
uboot does it).
However all the driver can do according to datasheet is configure the
charge voltage/current or disable charging completely.
Monitoring RTC battery is not possible, neither is presence detection.
So driver should just apply configuration it finds in device-tree and
eventually share that information via power supply class.
> And I don't know whether the axp20x has default Li-ion/LiPo battery
> OCV parameter. (axp22x seems to be have a set of default OCV)
It seems to have default OCV parameters as well. With empty RTC
battery OCV values are present.
> You can test this driver on AXP20x. (I think I didn't access to
> AXP22x-specified registers in the power supply code)
Bruno
WARNING: multiple messages have this Message-ID (diff)
From: bonbons@linux-vserver.org (Bruno Prémont)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver
Date: Tue, 5 Jul 2016 14:43:17 +0200 [thread overview]
Message-ID: <20160705144317.4a654376@pluto.restena.lu> (raw)
In-Reply-To: <112861467708458@web7h.yandex.ru>
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote:
> I read the datasheet of axp20x, and then found that this driver does
> not support backup RTC battery.
> (But maybe backup battery do not need a driver -- at least on IBM PC
> it has no driver)
A driver is needed to enable/disable the RTC battery charging (unless
uboot does it).
However all the driver can do according to datasheet is configure the
charge voltage/current or disable charging completely.
Monitoring RTC battery is not possible, neither is presence detection.
So driver should just apply configuration it finds in device-tree and
eventually share that information via power supply class.
> And I don't know whether the axp20x has default Li-ion/LiPo battery
> OCV parameter. (axp22x seems to be have a set of default OCV)
It seems to have default OCV parameters as well. With empty RTC
battery OCV values are present.
> You can test this driver on AXP20x. (I think I didn't access to
> AXP22x-specified registers in the power supply code)
Bruno
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Michael Haas <michael.haas@mailbox.org>, Wens <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org,
robh+dt@kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver
Date: Tue, 5 Jul 2016 14:43:17 +0200 [thread overview]
Message-ID: <20160705144317.4a654376@pluto.restena.lu> (raw)
In-Reply-To: <112861467708458@web7h.yandex.ru>
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote:
> I read the datasheet of axp20x, and then found that this driver does
> not support backup RTC battery.
> (But maybe backup battery do not need a driver -- at least on IBM PC
> it has no driver)
A driver is needed to enable/disable the RTC battery charging (unless
uboot does it).
However all the driver can do according to datasheet is configure the
charge voltage/current or disable charging completely.
Monitoring RTC battery is not possible, neither is presence detection.
So driver should just apply configuration it finds in device-tree and
eventually share that information via power supply class.
> And I don't know whether the axp20x has default Li-ion/LiPo battery
> OCV parameter. (axp22x seems to be have a set of default OCV)
It seems to have default OCV parameters as well. With empty RTC
battery OCV values are present.
> You can test this driver on AXP20x. (I think I didn't access to
> AXP22x-specified registers in the power supply code)
Bruno
next prev parent reply other threads:[~2016-07-05 12:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:29 [PATCH 1/4] mfd: axp20x: add adc volatile ranges for axp22x Icenowy Zheng
2016-07-01 9:29 ` Icenowy Zheng
[not found] ` <20160701092926.32005-1-icenowy-ymACFijhrKM@public.gmane.org>
2016-07-01 9:29 ` [PATCH 2/4] power: add axp20x-battery driver Icenowy Zheng
2016-07-01 9:29 ` Icenowy Zheng
[not found] ` <20160701092926.32005-2-icenowy-ymACFijhrKM@public.gmane.org>
2016-07-05 5:26 ` Michael Haas
2016-07-05 5:26 ` [linux-sunxi] " Michael Haas
2016-07-05 5:26 ` Michael Haas
[not found] ` <577B44FD.6040404-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org>
2016-07-05 8:33 ` Icenowy Zheng
2016-07-05 8:33 ` [linux-sunxi] " Icenowy Zheng
[not found] ` <4101467707611-tvSLaYVQeptuio3avFS2gg@public.gmane.org>
2016-07-05 9:25 ` maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
2016-07-05 9:25 ` [linux-sunxi] " maxime.ripard
2016-07-05 9:25 ` maxime.ripard at free-electrons.com
2016-07-05 10:09 ` Icenowy Zheng
2016-07-05 10:09 ` [linux-sunxi] " Icenowy Zheng
2016-07-05 12:45 ` Bruno Prémont
2016-07-05 12:45 ` [linux-sunxi] " Bruno Prémont
2016-07-05 12:45 ` Bruno Prémont
2016-07-06 4:34 ` Michael Haas
2016-07-06 4:34 ` [linux-sunxi] " Michael Haas
2016-07-06 4:34 ` Michael Haas
[not found] ` <577C8A6D.8000409-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org>
2016-07-06 7:48 ` Icenowy Zheng
2016-07-06 7:48 ` [linux-sunxi] " Icenowy Zheng
2016-07-05 8:47 ` Icenowy Zheng
2016-07-05 8:47 ` [linux-sunxi] " Icenowy Zheng
[not found] ` <112861467708458-tvSLaYVQeptuio3avFS2gg@public.gmane.org>
2016-07-05 12:43 ` Bruno Prémont [this message]
2016-07-05 12:43 ` Bruno Prémont
2016-07-05 12:43 ` Bruno Prémont
2016-07-01 9:29 ` [PATCH 3/4] ARM: sun8i: add axp20x-battery node for axp22x Icenowy Zheng
2016-07-01 9:29 ` Icenowy Zheng
2016-07-01 9:29 ` [PATCH 4/4] ARM: sun8i: enable axp22x-battery on A23/33 Q8 tablets Icenowy Zheng
2016-07-01 9:29 ` Icenowy Zheng
2016-08-05 7:46 ` [PATCH 1/4] mfd: axp20x: add adc volatile ranges for axp22x Lee Jones
2016-08-05 7:46 ` Lee Jones
2016-08-05 7:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705144317.4a654376@pluto.restena.lu \
--to=bonbons-ud5fbsm0p/xeiooadzr8i9i2o/jbrioy@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=icenowy-ymACFijhrKM@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=michael.haas-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.