Re: [PATCH 2/4] power: add axp20x-battery driver

[Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>]

05.07.2016, 17:25, "maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" <maxime.ripard@free-electrons.com>:
> On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote:
>>  05.07.2016, 13:26, "Michael Haas" <michael.haas-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org>:
>>  > Hi,
>>  >
>>  > nice work! Is this in any way related to Bruno Prémonts driver for the
>>  > axp20x?
>>  >
>>  > I've got a reworked version of that lying around, but it's not quite
>>  > ready for submission. Do you know what pieces are missing in your driver
>>  > for axp20x support - as opposed to axp22x, which is already working?
>>
>>  Therotically, it can run on axp20x. However, I have currently no
>>  test device. (Still waiting for my C.H.I.P.) So I can only promise
>>  it to run on axp22x.
>
> Still, it looks like you just took Bruno's driver, stripped out the
> axp20x parts and added the one to deal with axp22x.
>
> This makes the driver look weird, by being called axp20x, without
> actually supporting those PMICs, but having some axp22x variables
> right in the middle. And that's awfully inconsistent.
>
> I'd rather have you add the AXP20x driver directly, and then add the
> needed stuff for the AXP22x.
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

I modified axp20x_usb_power.c to suite the battery.

No axp22x-specified register is used in this driver.
I think this driver may now also work properly on axp20x, however
I have currently no device with axp20x.
(I didn't enter linux-sunxi when A10/13/20 is popular... So I'm waiting for
my CHIP)

This driver didn't implement OCV value tweak.

In fact, OCV value tweaking is even not documented in the datasheet
of both axp20x and axp22x.

Can you test it with axp20x? (It seems that the shipment of CHIP is so slow)

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.