From: Mel Gorman <mgorman@techsingularity.net>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg
Date: Fri, 15 Jul 2016 16:01:40 +0100 [thread overview]
Message-ID: <20160715150140.GP9806@techsingularity.net> (raw)
In-Reply-To: <20160715144534.GA8644@bbox>
On Fri, Jul 15, 2016 at 11:45:34PM +0900, Minchan Kim wrote:
> > +static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> > + enum lru_list lru, unsigned long *nr_zone_taken,
> > + unsigned long nr_taken)
> > +{
> > +#ifdef CONFIG_HIGHMEM
>
> If you think it's really worth to optimize it for non-highmem system,
> we don't need to account nr_zone_taken in *isolate_lru_pages*
> from the beginning for non-highmem system, either.
>
It becomes a mess of ifdefs and given the marginal overhead, I left it
for now.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg
Date: Fri, 15 Jul 2016 16:01:40 +0100 [thread overview]
Message-ID: <20160715150140.GP9806@techsingularity.net> (raw)
In-Reply-To: <20160715144534.GA8644@bbox>
On Fri, Jul 15, 2016 at 11:45:34PM +0900, Minchan Kim wrote:
> > +static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> > + enum lru_list lru, unsigned long *nr_zone_taken,
> > + unsigned long nr_taken)
> > +{
> > +#ifdef CONFIG_HIGHMEM
>
> If you think it's really worth to optimize it for non-highmem system,
> we don't need to account nr_zone_taken in *isolate_lru_pages*
> from the beginning for non-highmem system, either.
>
It becomes a mess of ifdefs and given the marginal overhead, I left it
for now.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-07-15 15:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 13:09 [PATCH 0/5] Follow-up fixes to node-lru series v2 Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-15 13:09 ` [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-15 15:42 ` Minchan Kim
2016-07-15 15:42 ` Minchan Kim
2016-07-18 16:14 ` Johannes Weiner
2016-07-18 16:14 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 2/5] mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction_ready -fix Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-15 15:50 ` Minchan Kim
2016-07-15 15:50 ` Minchan Kim
2016-07-18 16:15 ` Johannes Weiner
2016-07-18 16:15 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 3/5] mm, pagevec: Release/reacquire lru_lock on pgdat change Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-15 15:53 ` Minchan Kim
2016-07-15 15:53 ` Minchan Kim
2016-07-18 16:20 ` Johannes Weiner
2016-07-18 16:20 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 4/5] mm: show node_pages_scanned per node, not zone Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-16 10:14 ` Minchan Kim
2016-07-16 10:14 ` Minchan Kim
2016-07-15 13:09 ` [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Mel Gorman
2016-07-15 13:09 ` Mel Gorman
2016-07-15 14:45 ` Minchan Kim
2016-07-15 14:45 ` Minchan Kim
2016-07-15 15:01 ` Mel Gorman [this message]
2016-07-15 15:01 ` Mel Gorman
2016-07-15 15:54 ` Minchan Kim
2016-07-15 15:54 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715150140.GP9806@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.