All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, jic23@kernel.org,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	maxime.ripard@free-electrons.com, wens@csie.org,
	lee.jones@linaro.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	antoine.tenart@free-electrons.com
Subject: Re: [PATCH v3 1/4] hwmon: iio_hwmon: delay probing with late_initcall
Date: Tue, 26 Jul 2016 09:48:58 +0200	[thread overview]
Message-ID: <20160726094858.3aa96e18@free-electrons.com> (raw)
In-Reply-To: <1469519027-11387-2-git-send-email-quentin.schulz@free-electrons.com>

Hello,

On Tue, 26 Jul 2016 09:43:44 +0200, Quentin Schulz wrote:

> -module_platform_driver(iio_hwmon_driver);
> +static struct platform_driver * const drivers[] = {
> +	&iio_hwmon_driver,
> +};
> +
> +static int __init iio_hwmon_late_init(void)
> +{
> +	return platform_register_drivers(drivers, ARRAY_SIZE(drivers));

Why not platform_register_driver() ?

This would avoid the need to declare an array with just one entry.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] hwmon: iio_hwmon: delay probing with late_initcall
Date: Tue, 26 Jul 2016 09:48:58 +0200	[thread overview]
Message-ID: <20160726094858.3aa96e18@free-electrons.com> (raw)
In-Reply-To: <1469519027-11387-2-git-send-email-quentin.schulz@free-electrons.com>

Hello,

On Tue, 26 Jul 2016 09:43:44 +0200, Quentin Schulz wrote:

> -module_platform_driver(iio_hwmon_driver);
> +static struct platform_driver * const drivers[] = {
> +	&iio_hwmon_driver,
> +};
> +
> +static int __init iio_hwmon_late_init(void)
> +{
> +	return platform_register_drivers(drivers, ARRAY_SIZE(drivers));

Why not platform_register_driver() ?

This would avoid the need to declare an array with just one entry.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-26  7:48 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26  7:43 [PATCH v3 0/4] add support for Allwinner SoCs ADC Quentin Schulz
2016-07-26  7:43 ` Quentin Schulz
2016-07-26  7:43 ` [PATCH v3 1/4] hwmon: iio_hwmon: delay probing with late_initcall Quentin Schulz
2016-07-26  7:43   ` Quentin Schulz
2016-07-26  7:48   ` Thomas Petazzoni [this message]
2016-07-26  7:48     ` Thomas Petazzoni
2016-07-26  7:55     ` Quentin Schulz
2016-07-26  7:55       ` Quentin Schulz
2016-07-26  8:21   ` Alexander Stein
2016-07-26  8:21     ` Alexander Stein
2016-07-26  8:24     ` Quentin Schulz
2016-07-26  8:24       ` Quentin Schulz
2016-07-26  9:05       ` Alexander Stein
2016-07-26  9:05         ` Alexander Stein
2016-07-26  9:33         ` Quentin Schulz
2016-07-26  9:33           ` Quentin Schulz
2016-07-26 10:00           ` Alexander Stein
2016-07-26 10:00             ` Alexander Stein
2016-07-26 10:07             ` Quentin Schulz
2016-07-26 10:07               ` Quentin Schulz
2016-07-26 16:04             ` Guenter Roeck
2016-07-26 16:04               ` Guenter Roeck
2016-08-15 15:40               ` Jonathan Cameron
2016-08-15 15:40                 ` Jonathan Cameron
2016-08-15 17:07                 ` Guenter Roeck
2016-08-15 17:07                   ` Guenter Roeck
2016-08-15 21:35                   ` Jonathan Cameron
2016-08-15 21:35                     ` Jonathan Cameron
2016-08-15 21:35                     ` Jonathan Cameron
2016-09-01  7:15                     ` Quentin Schulz
2016-09-01  7:15                       ` Quentin Schulz
2016-09-01  9:03                       ` Quentin Schulz
2016-09-01  9:03                         ` Quentin Schulz
2016-09-03 19:32                         ` Jonathan Cameron
2016-09-03 19:32                           ` Jonathan Cameron
2016-08-15 15:36           ` Jonathan Cameron
2016-08-15 15:36             ` Jonathan Cameron
2016-07-26  7:43 ` [PATCH v3 2/4] mfd: add support for Allwinner SoCs ADC Quentin Schulz
2016-07-26  7:43   ` Quentin Schulz
2016-07-29  6:49   ` Maxime Ripard
2016-07-29  6:49     ` Maxime Ripard
2016-07-26  7:43 ` [PATCH v3 3/4] mfd: mfd-core: reattach mfd of_node to cells without of_compatible Quentin Schulz
2016-07-26  7:43   ` Quentin Schulz
2016-08-09 13:48   ` Lee Jones
2016-08-09 13:48     ` Lee Jones
2016-08-24  6:38     ` Maxime Ripard
2016-08-24  6:38       ` Maxime Ripard
2016-08-31 11:56       ` Lee Jones
2016-08-31 11:56         ` Lee Jones
2016-09-01  8:35         ` Quentin Schulz
2016-09-01  8:35           ` Quentin Schulz
2016-07-26  7:43 ` [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC Quentin Schulz
2016-07-26  7:43   ` Quentin Schulz
2016-07-29  7:12   ` Maxime Ripard
2016-07-29  7:12     ` Maxime Ripard
2016-08-04  8:41     ` Quentin Schulz
2016-08-04  8:41       ` Quentin Schulz
2016-08-24  6:41       ` Maxime Ripard
2016-08-24  6:41         ` Maxime Ripard
2016-08-04  9:56   ` Russell King - ARM Linux
2016-08-04  9:56     ` Russell King - ARM Linux
2016-08-04 10:27     ` Quentin Schulz
2016-08-04 10:27       ` Quentin Schulz
2016-08-21 19:27   ` Jonathan Cameron
2016-08-21 19:27     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726094858.3aa96e18@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=jdelvare@suse.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maxime.ripard@free-electrons.com \
    --cc=pmeerw@pmeerw.net \
    --cc=quentin.schulz@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.