From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Colin Lord <clord@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize
Date: Tue, 2 Aug 2016 09:28:17 +0800 [thread overview]
Message-ID: <20160802012817.GD680@ad.usersys.redhat.com> (raw)
In-Reply-To: <5847efbb-8c5a-4e3f-6b53-daa7768abcba@redhat.com>
On Mon, 08/01 12:31, Paolo Bonzini wrote:
> > +
> > +static void sdl_init_fn(void)
> > +{
> > + sdl_register_init_fun(sdl_display_init_do);
> > +}
> > +
> > +sdl_init(sdl_init_fn);
>
> Can you use __attribute__((constructor)) instead of going through the
> burden of defining a new type? The registration function only does a
> single assignment, so it doesn't really have ordering dependencies.
Yeah, it makes sense! Thanks.
Fam
next prev parent reply other threads:[~2016-08-02 1:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 6:26 [Qemu-devel] [PATCH for 2.8 0/3] Modularize SDL Fam Zheng
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 1/3] rules.mak: Don't extract libs from .mo-libs in link command Fam Zheng
2016-08-01 10:24 ` Paolo Bonzini
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 2/3] configure: Add CONFIG_SDL2 Fam Zheng
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize Fam Zheng
2016-07-27 23:23 ` Colin Lord
2016-07-28 5:17 ` Fam Zheng
2016-07-28 7:43 ` Fam Zheng
2016-08-01 10:33 ` Paolo Bonzini
2016-08-01 10:31 ` Paolo Bonzini
2016-08-02 1:28 ` Fam Zheng [this message]
2016-08-01 10:39 ` Daniel P. Berrange
2016-08-01 11:53 ` Gerd Hoffmann
2016-08-02 1:22 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802012817.GD680@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=clord@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.