Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

[Fam Zheng <famz@redhat.com>]

On Mon, 08/01 13:53, Gerd Hoffmann wrote:
> On Mi, 2016-07-27 at 14:26 +0800, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> more verbose commit message please, especially for those (like me) who
> have not worked yet with modules.

Yeah, my bad. Maybe I should have put RFC to the subject too.

> 
> Will sdl be loaded unconditionally?
> Or only with -display sdl?
> What happens if the module is not present?

Only with -display sdl, and report error + exit if the module is not present.

> 
> The main benefit I see in modularizing the ui is that we can move the ui
> modules (and the UI libs dependency chain) to a separate rpm subpackage,
> can we start that with this series applied?

Yes, that is the intention, but we need v2 to fix SDL audio and baum to achieve
that.

Colin also tested that not loading gui shared libraries (gtk?) speeds up
starting up.

> 
> Can modules have dependencies on other modules?  When it comes to
> modularizing spice we will need that as qxl has a spice dependency ...

Yes. spice's modules init function can call module_call_init(MODULE_INIT_QXL),
then check if QXL is available after that.

Fam