From: mhiramat@kernel.org (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date: Wed, 3 Aug 2016 00:08:09 +0900 [thread overview]
Message-ID: <20160803000809.2cf4f06d9e977c8cf06244a2@kernel.org> (raw)
In-Reply-To: <20160802141503.1e8d8796@lxorguk.ukuu.org.uk>
On Tue, 2 Aug 2016 14:15:03 +0100
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote:
> On Tue, 2 Aug 2016 18:33:22 +0800
> Baole Ni <baolex.ni@intel.com> wrote:
>
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
>
> If you are going to do this then please generate one patch per subsystem,
> and just do a couple of subsystems initially until everyone is happy with
> how it is being converted, then send out more subsystem by subsystem.
+1
Moreover, please DO NOT use same subject and same description for each patch (explain
what you did and why for each one), unless it will be just spamming git-log...
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@kernel.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Baole Ni <baolex.ni@intel.com>,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date: Wed, 3 Aug 2016 00:08:09 +0900 [thread overview]
Message-ID: <20160803000809.2cf4f06d9e977c8cf06244a2@kernel.org> (raw)
In-Reply-To: <20160802141503.1e8d8796@lxorguk.ukuu.org.uk>
On Tue, 2 Aug 2016 14:15:03 +0100
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote:
> On Tue, 2 Aug 2016 18:33:22 +0800
> Baole Ni <baolex.ni@intel.com> wrote:
>
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
>
> If you are going to do this then please generate one patch per subsystem,
> and just do a couple of subsystems initially until everyone is happy with
> how it is being converted, then send out more subsystem by subsystem.
+1
Moreover, please DO NOT use same subject and same description for each patch (explain
what you did and why for each one), unless it will be just spamming git-log...
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-08-02 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:33 [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 10:33 ` Baole Ni
2016-08-02 11:29 ` Russell King - ARM Linux
2016-08-02 11:29 ` Russell King - ARM Linux
2016-08-02 13:15 ` One Thousand Gnomes
2016-08-02 13:15 ` One Thousand Gnomes
2016-08-02 15:08 ` Masami Hiramatsu [this message]
2016-08-02 15:08 ` Masami Hiramatsu
2016-08-02 17:42 ` Pavel Machek
2016-08-02 17:42 ` Pavel Machek
2016-08-02 17:52 ` Joe Perches
2016-08-02 17:52 ` Joe Perches
2016-08-02 17:54 ` Pavel Machek
2016-08-02 17:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803000809.2cf4f06d9e977c8cf06244a2@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.