From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Dave Hansen <dave.hansen@intel.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH] fadump: Register the memory reserved by fadump
Date: Thu, 4 Aug 2016 20:57:43 +0530 [thread overview]
Message-ID: <20160804152743.GD11268@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160804140934.GM2799@techsingularity.net>
* Mel Gorman <mgorman@techsingularity.net> [2016-08-04 15:09:34]:
> >
> > Suggested-by: Mel Gorman <mgorman@techsingularity.net>
>
> I didn't suggest this specifically. While it happens to be safe on ppc64,
> it potentially overwrites any future caller of set_dma_reserve. While the
> only other one is for the e820 map, it may be better to change the API
> to inc_dma_reserve?
>
> It's also unfortunate that it's called dma_reserve because it has
> nothing to do with DMA or ZONE_DMA. inc_kernel_reserve may be more
> appropriate?
Yup Agree. Will redo and send out.
>
> --
> Mel Gorman
> SUSE Labs
>
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Dave Hansen <dave.hansen@intel.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH] fadump: Register the memory reserved by fadump
Date: Thu, 4 Aug 2016 20:57:43 +0530 [thread overview]
Message-ID: <20160804152743.GD11268@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160804140934.GM2799@techsingularity.net>
* Mel Gorman <mgorman@techsingularity.net> [2016-08-04 15:09:34]:
> >
> > Suggested-by: Mel Gorman <mgorman@techsingularity.net>
>
> I didn't suggest this specifically. While it happens to be safe on ppc64,
> it potentially overwrites any future caller of set_dma_reserve. While the
> only other one is for the e820 map, it may be better to change the API
> to inc_dma_reserve?
>
> It's also unfortunate that it's called dma_reserve because it has
> nothing to do with DMA or ZONE_DMA. inc_kernel_reserve may be more
> appropriate?
Yup Agree. Will redo and send out.
>
> --
> Mel Gorman
> SUSE Labs
>
--
Thanks and Regards
Srikar Dronamraju
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-04 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 13:42 [PATCH] fadump: Register the memory reserved by fadump Srikar Dronamraju
2016-08-04 13:42 ` Srikar Dronamraju
2016-08-04 14:09 ` Mel Gorman
2016-08-04 14:09 ` Mel Gorman
2016-08-04 15:27 ` Srikar Dronamraju [this message]
2016-08-04 15:27 ` Srikar Dronamraju
2016-08-05 7:07 ` Michael Ellerman
2016-08-05 7:07 ` Michael Ellerman
2016-08-05 7:28 ` Srikar Dronamraju
2016-08-05 7:28 ` Srikar Dronamraju
2016-08-05 9:25 ` Michael Ellerman
2016-08-05 9:25 ` Michael Ellerman
2016-08-05 10:06 ` Mel Gorman
2016-08-05 10:06 ` Mel Gorman
2016-08-10 6:02 ` Michael Ellerman
2016-08-10 6:02 ` Michael Ellerman
2016-08-10 6:40 ` Srikar Dronamraju
2016-08-10 6:40 ` Srikar Dronamraju
2016-08-10 6:57 ` Michael Ellerman
2016-08-10 6:57 ` Michael Ellerman
2016-08-10 9:21 ` Srikar Dronamraju
2016-08-10 9:21 ` Srikar Dronamraju
2016-08-10 7:51 ` Mel Gorman
2016-08-10 7:51 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804152743.GD11268@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=dave.hansen@intel.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.