* [PATCH] drm/i915: Disable stolen on 865G
@ 2016-08-04 9:56 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2016-08-04 9:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, stable
It appears our calculation for the address of stolen memory is incorrect
for 865G, so for the time being disable our use of that memory.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
index e1791fe96674..8b501ddbc784 100644
--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
@@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
* always at TOUD? Ie. is it always the last
* one to be allocated by the BIOS?
*/
+ if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
I865_TOUD, &toud);
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/i915: Disable stolen on 865G
@ 2016-08-04 9:56 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2016-08-04 9:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson, Ville Syrjälä, Daniel Vetter, stable
It appears our calculation for the address of stolen memory is incorrect
for 865G, so for the time being disable our use of that memory.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
index e1791fe96674..8b501ddbc784 100644
--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
@@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
* always at TOUD? Ie. is it always the last
* one to be allocated by the BIOS?
*/
+ if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
I865_TOUD, &toud);
--
2.8.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Ro.CI.BAT: failure for drm/i915: Disable stolen on 865G
2016-08-04 9:56 ` Chris Wilson
(?)
@ 2016-08-04 11:11 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2016-08-04 11:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable stolen on 865G
URL : https://patchwork.freedesktop.org/series/10651/
State : failure
== Summary ==
Series 10651v1 drm/i915: Disable stolen on 865G
http://patchwork.freedesktop.org/api/1.0/series/10651/revisions/1/mbox
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> INCOMPLETE (fi-snb-i7-2600)
Test gem_flink_basic:
Subgroup bad-flink:
pass -> INCOMPLETE (fi-skl-i7-6700k)
Test kms_cursor_legacy:
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (ro-hsw-i7-4770r)
pass -> FAIL (ro-skl3-i5-6260u)
pass -> FAIL (ro-bdw-i5-5250u)
Subgroup basic-flip-vs-cursor-varying-size:
pass -> FAIL (ro-skl3-i5-6260u)
fail -> PASS (ro-bdw-i5-5250u)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (ro-byt-n2820)
fi-hsw-i7-4770k total:240 pass:218 dwarn:0 dfail:0 fail:0 skip:22
fi-kbl-qkkr total:240 pass:182 dwarn:29 dfail:0 fail:3 skip:26
fi-skl-i5-6260u total:240 pass:224 dwarn:0 dfail:0 fail:2 skip:14
fi-skl-i7-6700k total:111 pass:87 dwarn:0 dfail:0 fail:0 skip:23
fi-snb-i7-2600 total:107 pass:77 dwarn:0 dfail:0 fail:0 skip:29
ro-bdw-i5-5250u total:240 pass:219 dwarn:4 dfail:0 fail:1 skip:16
ro-bdw-i7-5557U total:240 pass:224 dwarn:0 dfail:0 fail:0 skip:16
ro-bdw-i7-5600u total:240 pass:207 dwarn:0 dfail:0 fail:1 skip:32
ro-bsw-n3050 total:240 pass:194 dwarn:0 dfail:0 fail:4 skip:42
ro-byt-n2820 total:240 pass:196 dwarn:0 dfail:0 fail:4 skip:40
ro-hsw-i3-4010u total:240 pass:214 dwarn:0 dfail:0 fail:0 skip:26
ro-hsw-i7-4770r total:240 pass:214 dwarn:0 dfail:0 fail:0 skip:26
ro-ilk-i7-620lm total:240 pass:174 dwarn:0 dfail:0 fail:1 skip:65
ro-ilk1-i5-650 total:235 pass:173 dwarn:0 dfail:0 fail:2 skip:60
ro-ivb-i7-3770 total:240 pass:205 dwarn:0 dfail:0 fail:0 skip:35
ro-ivb2-i7-3770 total:240 pass:209 dwarn:0 dfail:0 fail:0 skip:31
ro-skl3-i5-6260u total:240 pass:222 dwarn:0 dfail:0 fail:4 skip:14
ro-snb-i7-2620M total:240 pass:198 dwarn:0 dfail:0 fail:1 skip:41
Results at /archive/results/CI_IGT_test/RO_Patchwork_1704/
62d2738 drm-intel-nightly: 2016y-08m-04d-10h-19m-00s UTC integration manifest
5b062ca drm/i915: Disable stolen on 865G
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
2016-08-04 9:56 ` Chris Wilson
@ 2016-08-04 16:31 ` Daniel Vetter
-1 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2016-08-04 16:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx, stable
On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> It appears our calculation for the address of stolen memory is incorrect
> for 865G, so for the time being disable our use of that memory.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: stable@vger.kernel.org
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index e1791fe96674..8b501ddbc784 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
> * always at TOUD? Ie. is it always the last
> * one to be allocated by the BIOS?
> */
> + if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
> pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
> I865_TOUD, &toud);
>
> --
> 2.8.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
@ 2016-08-04 16:31 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2016-08-04 16:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Ville Syrjälä, Daniel Vetter, stable
On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> It appears our calculation for the address of stolen memory is incorrect
> for 865G, so for the time being disable our use of that memory.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: stable@vger.kernel.org
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index e1791fe96674..8b501ddbc784 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
> * always at TOUD? Ie. is it always the last
> * one to be allocated by the BIOS?
> */
> + if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
> pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
> I865_TOUD, &toud);
>
> --
> 2.8.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
2016-08-04 16:31 ` Daniel Vetter
@ 2016-08-04 16:44 ` Ville Syrjälä
-1 siblings, 0 replies; 9+ messages in thread
From: Ville Syrjälä @ 2016-08-04 16:44 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, intel-gfx, stable
On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> > It appears our calculation for the address of stolen memory is incorrect
> > for 865G, so for the time being disable our use of that memory.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: stable@vger.kernel.org
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
There's a potentially better patch (one that actually fixes the stolen
base calculation) attached to the bug.
> > ---
> > drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > index e1791fe96674..8b501ddbc784 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
> > * always at TOUD? Ie. is it always the last
> > * one to be allocated by the BIOS?
> > */
> > + if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
> > pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
> > I865_TOUD, &toud);
> >
> > --
> > 2.8.1
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
@ 2016-08-04 16:44 ` Ville Syrjälä
0 siblings, 0 replies; 9+ messages in thread
From: Ville Syrjälä @ 2016-08-04 16:44 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Chris Wilson, intel-gfx, Daniel Vetter, stable
On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> > It appears our calculation for the address of stolen memory is incorrect
> > for 865G, so for the time being disable our use of that memory.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: stable@vger.kernel.org
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
There's a potentially better patch (one that actually fixes the stolen
base calculation) attached to the bug.
> > ---
> > drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > index e1791fe96674..8b501ddbc784 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
> > * always at TOUD? Ie. is it always the last
> > * one to be allocated by the BIOS?
> > */
> > + if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
> > pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
> > I865_TOUD, &toud);
> >
> > --
> > 2.8.1
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Ville Syrj�l�
Intel OTC
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
2016-08-04 16:44 ` Ville Syrjälä
@ 2016-08-04 16:53 ` Chris Wilson
-1 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2016-08-04 16:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Daniel Vetter, intel-gfx, stable
On Thu, Aug 04, 2016 at 07:44:14PM +0300, Ville Syrjälä wrote:
> On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote:
> > On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> > > It appears our calculation for the address of stolen memory is incorrect
> > > for 865G, so for the time being disable our use of that memory.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> > > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: stable@vger.kernel.org
> >
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> There's a potentially better patch (one that actually fixes the stolen
> base calculation) attached to the bug.
Yup, holding off on this and thanks for the patch :)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Disable stolen on 865G
@ 2016-08-04 16:53 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2016-08-04 16:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Daniel Vetter, intel-gfx, Daniel Vetter, stable
On Thu, Aug 04, 2016 at 07:44:14PM +0300, Ville Syrj�l� wrote:
> On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote:
> > On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> > > It appears our calculation for the address of stolen memory is incorrect
> > > for 865G, so for the time being disable our use of that memory.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> > > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: stable@vger.kernel.org
> >
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> There's a potentially better patch (one that actually fixes the stolen
> base calculation) attached to the bug.
Yup, holding off on this and thanks for the patch :)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-08-04 17:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 9:56 [PATCH] drm/i915: Disable stolen on 865G Chris Wilson
2016-08-04 9:56 ` Chris Wilson
2016-08-04 11:11 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-04 16:31 ` [PATCH] " Daniel Vetter
2016-08-04 16:31 ` Daniel Vetter
2016-08-04 16:44 ` Ville Syrjälä
2016-08-04 16:44 ` Ville Syrjälä
2016-08-04 16:53 ` Chris Wilson
2016-08-04 16:53 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.