All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbeldan@baylibre.com (Karl Beldan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit
Date: Fri, 5 Aug 2016 14:45:07 +0000	[thread overview]
Message-ID: <20160805144507.GA24855@gobelin> (raw)
In-Reply-To: <57A49F3A.9030306@ti.com>

On Fri, Aug 05, 2016 at 07:44:18PM +0530, Sekhar Nori wrote:
> On Thursday 04 August 2016 08:13 PM, Karl Beldan wrote:
> > The LCDK is the successor to the late Hawkboard and has the same machine
> > number.
> > Among the differences are the flash (16bits vs 8bits) and some pins
> > (MMC, LEDs, buttons, some external connectors), however the main
> > components remain the same (eth. PHY, Audio Codec, Video decoder and
> > DAC) except for the main PMIC, different and hard-wired on the LCDK (the
> > LDOs and DCDCs are always ON).
> > A DT-only boot with this addition gives functional uart, reboot via
> > watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC
> > although davinci_mmc doesn't call yet the mmc core OF facilities).
> > 
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> 
> C6748 is a pin-compatible DSP-only part which does not run Linux. The
> OMAP-L138 and C6748 LCDKs are physically different boards. So, I would
> just stick with subject line ".. for the OMAP-L138 LCDK board"
> 
That was my understanding but LCDK stands for L138-C6748-Dev-Kit right ?
Anyways, I'll remove the said references as per your request.

> > ---
> >  Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
> >  arch/arm/boot/dts/Makefile                        |  1 +
> >  arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
> >  arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
> >  4 files changed, 77 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/davinci.txt b/Documentation/devicetree/bindings/arm/davinci.txt
> > index cfaeda4..1482c74 100644
> > --- a/Documentation/devicetree/bindings/arm/davinci.txt
> > +++ b/Documentation/devicetree/bindings/arm/davinci.txt
> > @@ -5,6 +5,10 @@ DA850/OMAP-L138/AM18x Evaluation Module (EVM) board
> >  Required root node properties:
> >      - compatible = "ti,da850-evm", "ti,da850";
> >  
> > +DA850/OMAP-L138/AM18x L138/C6748 Development Kit (LCDK) board
> 
> here too, drop reference to C6748.
> 
Ditto.

> > +Required root node properties:
> > +    - compatible = "ti,omapl138-lcdk", "ti,da850";
> 
> let the compatible be "ti,da850-lcdk" for consistency.
> 
Kevin pointed that out.

> > +
> >  EnBW AM1808 based CMC board
> >  Required root node properties:
> >      - compatible = "enbw,cmc", "ti,da850;
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 414b427..da3f69b 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
> >  dtb-$(CONFIG_ARCH_BRCMSTB) += \
> >  	bcm7445-bcm97445svmb.dtb
> >  dtb-$(CONFIG_ARCH_DAVINCI) += \
> > +	omapl138-lcdk.dtb \
> >  	da850-enbw-cmc.dtb \
> >  	da850-evm.dtb
> >  dtb-$(CONFIG_ARCH_DIGICOLOR) += \
> > diff --git a/arch/arm/boot/dts/omapl138-lcdk.dts b/arch/arm/boot/dts/omapl138-lcdk.dts
> > new file mode 100644
> > index 0000000..fad3b6d
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omapl138-lcdk.dts
> > @@ -0,0 +1,71 @@
> > +/*
> > + * Copyright (c) 2016 BayLibre, Inc.
> > + *
> > + * Licensed under GPLv2 or later.
> 
> are you sure about "or later"?
> 
I will remove it.
 
Karl

WARNING: multiple messages have this Message-ID (diff)
From: Karl Beldan <kbeldan-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	karl.beldan+oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit
Date: Fri, 5 Aug 2016 14:45:07 +0000	[thread overview]
Message-ID: <20160805144507.GA24855@gobelin> (raw)
In-Reply-To: <57A49F3A.9030306-l0cyMroinI0@public.gmane.org>

On Fri, Aug 05, 2016 at 07:44:18PM +0530, Sekhar Nori wrote:
> On Thursday 04 August 2016 08:13 PM, Karl Beldan wrote:
> > The LCDK is the successor to the late Hawkboard and has the same machine
> > number.
> > Among the differences are the flash (16bits vs 8bits) and some pins
> > (MMC, LEDs, buttons, some external connectors), however the main
> > components remain the same (eth. PHY, Audio Codec, Video decoder and
> > DAC) except for the main PMIC, different and hard-wired on the LCDK (the
> > LDOs and DCDCs are always ON).
> > A DT-only boot with this addition gives functional uart, reboot via
> > watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC
> > although davinci_mmc doesn't call yet the mmc core OF facilities).
> > 
> > Signed-off-by: Karl Beldan <kbeldan-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> 
> C6748 is a pin-compatible DSP-only part which does not run Linux. The
> OMAP-L138 and C6748 LCDKs are physically different boards. So, I would
> just stick with subject line ".. for the OMAP-L138 LCDK board"
> 
That was my understanding but LCDK stands for L138-C6748-Dev-Kit right ?
Anyways, I'll remove the said references as per your request.

> > ---
> >  Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
> >  arch/arm/boot/dts/Makefile                        |  1 +
> >  arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
> >  arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
> >  4 files changed, 77 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/davinci.txt b/Documentation/devicetree/bindings/arm/davinci.txt
> > index cfaeda4..1482c74 100644
> > --- a/Documentation/devicetree/bindings/arm/davinci.txt
> > +++ b/Documentation/devicetree/bindings/arm/davinci.txt
> > @@ -5,6 +5,10 @@ DA850/OMAP-L138/AM18x Evaluation Module (EVM) board
> >  Required root node properties:
> >      - compatible = "ti,da850-evm", "ti,da850";
> >  
> > +DA850/OMAP-L138/AM18x L138/C6748 Development Kit (LCDK) board
> 
> here too, drop reference to C6748.
> 
Ditto.

> > +Required root node properties:
> > +    - compatible = "ti,omapl138-lcdk", "ti,da850";
> 
> let the compatible be "ti,da850-lcdk" for consistency.
> 
Kevin pointed that out.

> > +
> >  EnBW AM1808 based CMC board
> >  Required root node properties:
> >      - compatible = "enbw,cmc", "ti,da850;
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 414b427..da3f69b 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
> >  dtb-$(CONFIG_ARCH_BRCMSTB) += \
> >  	bcm7445-bcm97445svmb.dtb
> >  dtb-$(CONFIG_ARCH_DAVINCI) += \
> > +	omapl138-lcdk.dtb \
> >  	da850-enbw-cmc.dtb \
> >  	da850-evm.dtb
> >  dtb-$(CONFIG_ARCH_DIGICOLOR) += \
> > diff --git a/arch/arm/boot/dts/omapl138-lcdk.dts b/arch/arm/boot/dts/omapl138-lcdk.dts
> > new file mode 100644
> > index 0000000..fad3b6d
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omapl138-lcdk.dts
> > @@ -0,0 +1,71 @@
> > +/*
> > + * Copyright (c) 2016 BayLibre, Inc.
> > + *
> > + * Licensed under GPLv2 or later.
> 
> are you sure about "or later"?
> 
I will remove it.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-08-05 14:45 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 14:43 [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Karl Beldan
2016-08-04 14:43 ` Karl Beldan
2016-08-04 18:29 ` Rob Herring
2016-08-04 18:29   ` Rob Herring
2016-08-04 21:03   ` Karl Beldan
2016-08-04 21:03     ` Karl Beldan
2016-08-04 21:13     ` Rob Herring
2016-08-04 21:13       ` Rob Herring
2016-08-04 23:43       ` Karl Beldan
2016-08-04 23:43         ` Karl Beldan
2016-10-13  7:14         ` Karl Beldan
2016-10-13  7:14           ` Karl Beldan
2016-08-04 19:15 ` Kevin Hilman
2016-08-04 19:15   ` Kevin Hilman
2016-08-04 20:58   ` Karl Beldan
2016-08-04 20:58     ` Karl Beldan
     [not found]   ` <20160804200522.GB15878@gobelin>
2016-08-05  0:25     ` Kevin Hilman
2016-08-05  0:25       ` Kevin Hilman
2016-08-05 14:00   ` Sekhar Nori
2016-08-05 14:00     ` Sekhar Nori
2016-08-05 14:12 ` [PATCH v2 0/3] Support for the L138/C6748 Dev Kit (LCDK) Karl Beldan
2016-08-05 14:12   ` Karl Beldan
2016-08-05 14:12   ` [PATCH v2 1/3] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-10 18:35     ` Rob Herring
2016-08-10 18:35       ` Rob Herring
2016-08-05 14:12   ` [PATCH v2 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-05 14:12   ` [PATCH v2 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-05 14:14 ` [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Sekhar Nori
2016-08-05 14:14   ` Sekhar Nori
2016-08-05 14:45   ` Karl Beldan [this message]
2016-08-05 14:45     ` Karl Beldan
2016-08-05 14:52     ` Sekhar Nori
2016-08-05 14:52       ` Sekhar Nori
2016-08-05 14:59 ` [PATCH v3 0/3] Support for the LCDK Karl Beldan
2016-08-05 14:59   ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 1/3] ARM: dts: da850: Add basic DTS " Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 20:29 ` [PATCH v4 0/3] Support for the LCDK Karl Beldan
2016-08-05 20:29   ` Karl Beldan
2016-08-05 20:29   ` [PATCH v4 1/3] ARM: dts: da850: Add basic DTS " Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 20:29   ` [PATCH v4 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 23:45     ` Kevin Hilman
2016-08-05 23:45       ` Kevin Hilman
2016-08-05 20:29   ` [PATCH v4 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 23:46     ` Kevin Hilman
2016-08-05 23:46       ` Kevin Hilman
2016-08-09 11:59   ` [PATCH v4 0/3] Support for the LCDK Sekhar Nori
2016-08-09 11:59     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805144507.GA24855@gobelin \
    --to=kbeldan@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.